refactor(e2e): remove build step from CI and improve dependency polling logic

Author: jeffsmale90

.github/workflows/end-to-end-tests.yml

@@ -47,10 +47,5 @@ jobs:
       - name: Install Yarn dependencies
         run: yarn install
 
-      - name: Run build
-        run: yarn build
-        env:
-          NODE_ENV: production
-
       - name: Run end-to-end tests
         run: yarn test:e2e

packages/delegator-e2e/src/await-dependencies.ts

@@ -24,17 +24,15 @@ const waitFor = async (name: string, url: string) => {
   });
 
   do {
-    if (!isAvailable) {
+    if (isAvailable === undefined) {
       // Only add a delay if it's not the first time
       await new Promise((resolve) => setTimeout(resolve, POLL_INTERVAL_MS));
     }
 
     await client
       .request({ method: 'web3_clientVersion' })
       .then(() => (isAvailable = true))
-      .catch((e: any) => {
-        isAvailable = (e as Error).name !== 'HttpRequestError';
-      });
+      .catch(() => (isAvailable = false));
   } while (!isAvailable);
 
   console.log(`${name} is available`);
@@ -61,13 +59,15 @@ const deployEnvironment = async () => {
 };
 
 (async () => {
+  console.log('Waiting for blockchain node');
   await waitFor('Blockchain node', nodeUrl);
+  const bundlerAndPaymasterReady = Promise.all([
+    waitFor('Bundler', bundlerUrl),
+    waitFor('Mock paymaster', paymasterUrl),
+  ]);
 
   const environment = await deployEnvironment();
   await writeFile('./.gator-env.json', JSON.stringify(environment, null, 2));
 
-  await Promise.all([
-    waitFor('Bundler', bundlerUrl),
-    waitFor('Mock paymaster', paymasterUrl),
-  ]);
+  await bundlerAndPaymasterReady;
 })();