Skip to content

Commit b340133

Browse files
committed
feat: improve types by replacing 0x${string} with proper viem types
1 parent 4c6937b commit b340133

9 files changed

Lines changed: 75 additions & 71 deletions

File tree

packages/delegation-deployments/src/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import type { Address } from 'viem';
12
import {
23
deployments_1_3_0,
34
deployments_1_1_0,
@@ -39,7 +40,7 @@ export const CHAIN_ID = {
3940

4041
type DeployedContracts = Record<
4142
string,
42-
Record<number, Record<string, `0x${string}`>>
43+
Record<number, Record<string, Address>>
4344
>;
4445

4546
export const DELEGATOR_CONTRACTS: DeployedContracts = {

packages/delegation-toolkit/src/actions/signDelegation.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import type {
33
Address,
44
Chain,
55
Client,
6+
Hex,
67
Transport,
78
WalletClient,
89
} from 'viem';
@@ -29,7 +30,7 @@ export type SignDelegationParameters = {
2930
allowInsecureUnrestrictedDelegation?: boolean;
3031
};
3132

32-
export type SignDelegationReturnType = `0x${string}`;
33+
export type SignDelegationReturnType = Hex;
3334

3435
/**
3536
* Signs a delegation using a wallet client.

packages/delegation-toolkit/src/actions/signUserOperation.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import type {
33
Address,
44
Chain,
55
Client,
6+
Hex,
67
Transport,
78
WalletClient,
89
} from 'viem';
@@ -29,7 +30,7 @@ export type SignUserOperationParameters = {
2930
version?: string;
3031
};
3132

32-
export type SignUserOperationReturnType = `0x${string}`;
33+
export type SignUserOperationReturnType = Hex;
3334

3435
/**
3536
* Signs a user operation using a wallet client.

packages/delegation-toolkit/src/userOp.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ export const signUserOperation = async ({
327327
address,
328328
version = '1',
329329
}: {
330-
privateKey: `0x${string}`;
330+
privateKey: Hex;
331331
userOperation: Omit<UserOperationV07, 'signature'>;
332332
entryPoint: { address: Address };
333333
chainId: number;

packages/delegation-toolkit/test/actions/signUserOperation.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { Account, Address } from 'viem';
1+
import type { Account, Address, Hex } from 'viem';
22
import { createWalletClient, custom, isHex } from 'viem';
33
import { generatePrivateKey, privateKeyToAccount } from 'viem/accounts';
44
import { sepolia } from 'viem/chains';
@@ -51,7 +51,7 @@ describe('signUserOperation Action', () => {
5151
userOperation = {
5252
sender: randomAddress(),
5353
nonce: 0n,
54-
callData: '0x',
54+
callData: '0x' as Hex,
5555
callGasLimit: 1000000n,
5656
verificationGasLimit: 1000000n,
5757
preVerificationGas: 21000n,
@@ -177,7 +177,7 @@ describe('signUserOperation Action', () => {
177177
paymaster: randomAddress(),
178178
paymasterVerificationGasLimit: 50000n,
179179
paymasterPostOpGasLimit: 50000n,
180-
paymasterData: '0x1234' as `0x${string}`,
180+
paymasterData: '0x1234' as Hex,
181181
};
182182

183183
const parameters: SignUserOperationParameters = {
@@ -196,7 +196,7 @@ describe('signUserOperation Action', () => {
196196
const userOpWithFactory = {
197197
...userOperation,
198198
factory: randomAddress(),
199-
factoryData: '0x5678' as `0x${string}`,
199+
factoryData: '0x5678' as Hex,
200200
};
201201

202202
const parameters: SignUserOperationParameters = {

packages/delegation-toolkit/test/caveatBuilder/exactExecutionBatchBuilder.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ describe('exactExecutionBatchBuilder()', () => {
3030
});
3131

3232
it('should fail with an invalid target address', () => {
33-
const invalidAddress = 'invalid-address' as Address;
33+
const invalidAddress = 'invalid-address' as any;
3434
expect(() =>
3535
buildWithParams([
3636
{
@@ -60,7 +60,7 @@ describe('exactExecutionBatchBuilder()', () => {
6060
{
6161
target: randomAddress(),
6262
value: 0n,
63-
callData: 'invalid' as Hex,
63+
callData: 'invalid' as any,
6464
},
6565
]),
6666
).to.throw('Invalid calldata: must be a hex string starting with 0x');

0 commit comments

Comments
 (0)