fix: default delegation.salt and caveat.args should be 0x00 (#138)

* Default value for delegation salt should be '0x00' instead of '0x'

* Default value for caveat args should be '0x00' instead of '0x'

* Update delegation encoding tests
- use static input data
- assert encoded data hex literals

* Mark exported constants as 'as const'

Author: jeffsmale90

packages/delegation-core/src/delegation.ts

@@ -15,29 +15,30 @@ import type { CaveatStruct, DelegationStruct, Hex } from './types';
 /**
  * When designated as the delegate address in a delegation, this allows any beneficiary to redeem the delegation.
  */
-export const ANY_BENEFICIARY = '0x0000000000000000000000000000000000000a11';
+export const ANY_BENEFICIARY =
+  '0x0000000000000000000000000000000000000a11' as const;
 
 /**
  * To be used on a delegation as the root authority.
  */
 export const ROOT_AUTHORITY =
-  '0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff';
+  '0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff' as const;
 
 /**
  * The typehash for a delegation, used when generating a delegation hash.
  *
  * keccak('Delegation(address delegate,address delegator,bytes32 authority,Caveat[] caveats,uint256 salt)Caveat(address enforcer,bytes terms)')
  */
 export const DELEGATION_TYPEHASH =
-  '0x88c1d2ecf185adf710588203a5f263f0ff61be0d33da39792cde19ba9aa4331e';
+  '0x88c1d2ecf185adf710588203a5f263f0ff61be0d33da39792cde19ba9aa4331e' as const;
 
 /**
  * The typehash for a caveat, used when generating a caveat hash.
  *
  * keccak('Caveat(address enforcer,bytes terms)')
  */
 export const CAVEAT_TYPEHASH =
-  '0x80ad7e1b04ee6d994a125f4714ca0720908bd80ed16063ec8aee4b88e9253e2d';
+  '0x80ad7e1b04ee6d994a125f4714ca0720908bd80ed16063ec8aee4b88e9253e2d' as const;
 
 /**
  * The ABI types for an array of delegations.

packages/delegator-e2e/test/actions/signDelegationActions.test.ts

@@ -163,7 +163,7 @@ test('should handle delegation with additional caveats', async () => {
       {
         enforcer: '0x1111111111111111111111111111111111111111',
         terms: '0x1234',
-        args: '0x',
+        args: '0x00',
       },
     ],
   });

packages/smart-accounts-kit/src/caveatBuilder/allowedCalldataBuilder.ts

@@ -44,6 +44,6 @@ export const allowedCalldataBuilder = (
   return {
     enforcer: AllowedCalldataEnforcer,
     terms,
-    args: '0x',
+    args: '0x00',
   };
 };

packages/smart-accounts-kit/src/caveatBuilder/allowedMethodsBuilder.ts

@@ -51,7 +51,7 @@ export const allowedMethodsBuilder = (
   return {
     enforcer: AllowedMethodsEnforcer,
     terms,
-    args: '0x',
+    args: '0x00',
   };
 };
 

packages/smart-accounts-kit/src/caveatBuilder/allowedTargetsBuilder.ts

@@ -54,6 +54,6 @@ export const allowedTargetsBuilder = (
   return {
     enforcer: AllowedTargetsEnforcer,
     terms,
-    args: '0x',
+    args: '0x00',
   };
 };

packages/smart-accounts-kit/src/caveatBuilder/argsEqualityCheckBuilder.ts

@@ -39,6 +39,6 @@ export const argsEqualityCheckBuilder = (
   return {
     enforcer: ArgsEqualityCheckEnforcer,
     terms: args,
-    args: '0x',
+    args: '0x00',
   };
 };

packages/smart-accounts-kit/src/caveatBuilder/blockNumberBuilder.ts

@@ -63,6 +63,6 @@ export const blockNumberBuilder = (
   return {
     enforcer: BlockNumberEnforcer,
     terms,
-    args: '0x',
+    args: '0x00',
   };
 };

packages/smart-accounts-kit/src/caveatBuilder/caveatBuilder.ts

@@ -103,7 +103,7 @@ export class CaveatBuilder<
   ): CaveatBuilder<TCaveatBuilderMap> {
     if (typeof nameOrCaveat === 'object') {
       const caveat = {
-        args: '0x' as const,
+        args: '0x00' as const,
         ...nameOrCaveat,
       };
 

packages/smart-accounts-kit/src/caveatBuilder/deployedBuilder.ts

@@ -61,6 +61,6 @@ export const deployedBuilder = (
   return {
     enforcer: DeployedEnforcer,
     terms,
-    args: '0x',
+    args: '0x00',
   };
 };

packages/smart-accounts-kit/src/caveatBuilder/erc1155BalanceChangeBuilder.ts

@@ -83,6 +83,6 @@ export const erc1155BalanceChangeBuilder = (
   return {
     enforcer: ERC1155BalanceChangeEnforcer,
     terms,
-    args: '0x',
+    args: '0x00',
   };
 };