Remove homepage from kernel snap, only call gator snap to build permission offer registry, derive id for permission offer in kernel snap, improve var naming, drop attenuated term on rpc method

Author: V00D00-child

packages/gator-permissions-snap/snap.config.ts

@@ -55,7 +55,6 @@ const config: SnapConfig = {
   },
   polyfills: {
     buffer: true,
-    crypto: true,
   },
   environment: {
     SNAP_ENV,

packages/gator-permissions-snap/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snap-7715-permissions.git"
   },
   "source": {
-    "shasum": "rBYfwKftRHT6Ubb97mXlM4mpyS5QuNDEiRnoo7jUpAo=",
+    "shasum": "cZ2rf30XnvnLd+00V8QM47B50p8hkPsXZZSd53wCU7Y=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

packages/gator-permissions-snap/src/index.ts

@@ -135,7 +135,7 @@ const rpcHandler = createRpcHandler({
 const boundRpcHandlers: {
   [RpcMethod: string]: (params?: JsonRpcParams) => Promise<Json>;
 } = {
-  [RpcMethod.PermissionProviderGrantAttenuatedPermissions]:
+  [RpcMethod.PermissionProviderGrantPermissions]:
     rpcHandler.grantPermission.bind(rpcHandler),
   [RpcMethod.PermissionProviderGetPermissionOffers]:
     rpcHandler.getPermissionOffers.bind(rpcHandler),

packages/gator-permissions-snap/src/permissions/permission-offers.ts

@@ -0,0 +1,15 @@
+import type { PermissionOffer } from '@metamask/7715-permissions-shared/types';
+
+/**
+ * The default permission offers that the Gator snap will offer to the kernel snap
+ */
+export const DEFAULT_GATOR_PERMISSION_TO_OFFER: PermissionOffer[] = [
+  {
+    type: 'native-token-stream',
+    proposedName: 'Native Token Stream',
+  },
+  {
+    type: 'native-token-periodic',
+    proposedName: 'Native Token Periodic Transfer',
+  },
+];

packages/gator-permissions-snap/src/permissions/permissionOffers.ts

@@ -4,7 +4,7 @@ import { RpcMethod } from './rpcMethod';
 
 const allowedPermissionsByOrigin: { [origin: string]: string[] } = {
   [KERNEL_SNAP_ID]: [
-    RpcMethod.PermissionProviderGrantAttenuatedPermissions,
+    RpcMethod.PermissionProviderGrantPermissions,
     RpcMethod.PermissionProviderGetPermissionOffers,
   ],
 };

packages/gator-permissions-snap/src/rpc/permissions.ts

@@ -1,12 +1,8 @@
-import type { PermissionOffer } from '@metamask/7715-permissions-shared/types';
 import { logger } from '@metamask/7715-permissions-shared/utils';
 import type { Json } from '@metamask/snaps-sdk';
 
 import type { PermissionHandlerFactory } from '../core/permissionHandlerFactory';
-import {
-  DEFAULT_GATOR_PERMISSION_TO_OFFER,
-  getIdFor,
-} from '../permissions/permission-offers';
+import { DEFAULT_GATOR_PERMISSION_TO_OFFER } from '../permissions/permissionOffers';
 import type { ProfileSyncManager } from '../profileSync';
 import { validatePermissionRequestParam } from '../utils/validate';
 
@@ -88,17 +84,7 @@ export function createRpcHandler(config: {
    */
   const getPermissionOffers = async (): Promise<Json> => {
     logger.debug('getPermissionOffers()');
-    const gatorSnapDefaultsOffers = await Promise.all(
-      DEFAULT_GATOR_PERMISSION_TO_OFFER.map(async (per) => {
-        const id = await getIdFor(per);
-        return {
-          type: per.type,
-          id,
-          proposedName: per.proposedName,
-        } as PermissionOffer;
-      }),
-    );
-    return gatorSnapDefaultsOffers;
+    return DEFAULT_GATOR_PERMISSION_TO_OFFER;
   };
 
   return {

packages/gator-permissions-snap/src/rpc/rpcHandler.ts

@@ -10,5 +10,5 @@ export enum RpcMethod {
   /**
    * This method is used by the kernel to request a permissions provider to grant attenuated permissions to a site.
    */
-  PermissionProviderGrantAttenuatedPermissions = 'permissionsProvider_grantAttenuatedPermissions',
+  PermissionProviderGrantPermissions = 'permissionsProvider_grantPermissions',
 }

packages/gator-permissions-snap/src/rpc/rpcMethod.ts

@@ -357,12 +357,10 @@ describe('RpcHandler', () => {
       const result = await handler.getPermissionOffers();
       expect(result).toStrictEqual([
         {
-          id: '8c1697dd46c1e0be7a1627f8efb110612b9ee8510476d78da0f74687afbe0b10',
           proposedName: 'Native Token Stream',
           type: 'native-token-stream',
         },
         {
-          id: '1241bf3c50b7d36d1921a9a5c6af5238a363debc86826f11bab553ceed7744ca',
           proposedName: 'Native Token Periodic Transfer',
           type: 'native-token-periodic',
         },

packages/gator-permissions-snap/test/rpc/rpcHandler.test.ts

@@ -17,6 +17,7 @@ const config: SnapConfig = {
   },
   polyfills: {
     buffer: true,
+    crypto: true,
   },
   environment: {
     // eslint-disable-next-line n/no-process-env