Lint

Author: jeffsmale90

packages/gator-permissions-snap/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snap-7715-permissions.git"
   },
   "source": {
-    "shasum": "PoFMZl7wTNzoiX+wVkMk8Gwmhxd4el+wY1HHBX0XjGs=",
+    "shasum": "rNRclGmH8r9z7JF1tMzA9Hfqu1ZO5ZghIAw2Es9bg1U=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

packages/gator-permissions-snap/src/core/permissionRequestLifecycleOrchestrator.ts

@@ -234,6 +234,7 @@ export class PermissionRequestLifecycleOrchestrator {
       validBefore,
     );
 
+    // eslint-disable-next-line no-restricted-globals
     const saltBytes = crypto.getRandomValues(new Uint8Array(32));
     const salt = bytesToHex(saltBytes);
 

packages/gator-permissions-snap/src/core/types.ts

@@ -6,13 +6,13 @@ import type {
 import type { CoreCaveatBuilder } from '@metamask/delegation-toolkit';
 import type { SnapsProvider } from '@metamask/snaps-sdk';
 import type { GenericSnapElement } from '@metamask/snaps-sdk/jsx';
+import type { Hex } from 'viem';
 
 import type { AccountController } from '../accountController';
 import type { TokenMetadataService } from '../services/tokenMetadataService';
 import type { TokenPricesService } from '../services/tokenPricesService';
 import type { UserEventDispatcher } from '../userEventDispatcher';
 import type { PermissionRequestLifecycleOrchestrator } from './permissionRequestLifecycleOrchestrator';
-import { Hex } from 'viem';
 
 /**
  * Represents the result of a permission request.

packages/gator-permissions-snap/src/permissions/contextValidation.ts

@@ -1,22 +1,23 @@
 import { parseUnits, formatUnits } from 'viem';
+
+import type { TimePeriod } from '../core/types';
 import {
   convertReadableDateToTimestamp,
   getStartOfTodayUTC,
   TIME_PERIOD_TO_SECONDS,
 } from '../utils/time';
-import { TimePeriod } from '../core/types';
 
-export interface ValidationErrors {
+export type ValidationErrors = {
   [key: string]: string;
-}
+};
 
 /**
- * Validates and parses a token amount string to BigInt
- * @param amount - The amount string to validate
- * @param decimals - Token decimals
- * @param fieldName - Name of the field for error messages
- * @param allowZero - Whether zero values are allowed (default: false)
- * @returns Object containing the parsed amount and any validation error
+ * Validates and parses a token amount string to BigInt.
+ * @param amount - The amount string to validate.
+ * @param decimals - Token decimals.
+ * @param fieldName - Name of the field for error messages.
+ * @param allowZero - Whether zero values are allowed (default: false).
+ * @returns Object containing the parsed amount and any validation error.
  */
 export function validateAndParseAmount(
   amount: string | undefined,
@@ -49,9 +50,9 @@ export function validateAndParseAmount(
 }
 
 /**
- * Validates a start time to ensure it's today or later
- * @param startTime - The start time string to validate
- * @returns Validation error message or undefined if valid
+ * Validates a start time to ensure it's today or later.
+ * @param startTime - The start time string to validate.
+ * @returns Validation error message or undefined if valid.
  */
 export function validateStartTime(startTime: string): string | undefined {
   try {
@@ -66,9 +67,9 @@ export function validateStartTime(startTime: string): string | undefined {
 }
 
 /**
- * Validates an expiry time to ensure it's in the future
- * @param expiry - The expiry time string to validate
- * @returns Validation error message or undefined if valid
+ * Validates an expiry time to ensure it's in the future.
+ * @param expiry - The expiry time string to validate.
+ * @returns Validation error message or undefined if valid.
  */
 export function validateExpiry(expiry: string): string | undefined {
   try {
@@ -84,10 +85,10 @@ export function validateExpiry(expiry: string): string | undefined {
 }
 
 /**
- * Validates that max amount is greater than initial amount
- * @param maxAmount - The maximum amount as BigInt
- * @param initialAmount - The initial amount as BigInt
- * @returns Validation error message or undefined if valid
+ * Validates that max amount is greater than initial amount.
+ * @param maxAmount - The maximum amount as BigInt.
+ * @param initialAmount - The initial amount as BigInt.
+ * @returns Validation error message or undefined if valid.
  */
 export function validateMaxAmountVsInitialAmount(
   maxAmount: bigint | undefined,
@@ -104,11 +105,11 @@ export function validateMaxAmountVsInitialAmount(
 }
 
 /**
- * Calculates amount per second from amount per period
- * @param amountPerPeriod - The amount per period as BigInt
- * @param timePeriod - The time period
- * @param decimals - Token decimals
- * @returns Formatted amount per second string
+ * Calculates amount per second from amount per period.
+ * @param amountPerPeriod - The amount per period as BigInt.
+ * @param timePeriod - The time period.
+ * @param decimals - Token decimals.
+ * @returns Formatted amount per second string.
  */
 export function calculateAmountPerSecond(
   amountPerPeriod: bigint,
@@ -122,9 +123,9 @@ export function calculateAmountPerSecond(
 }
 
 /**
- * Validates a period duration (for periodic permissions)
- * @param periodDuration - The period duration string to validate
- * @returns Object containing parsed duration and any validation error
+ * Validates a period duration (for periodic permissions).
+ * @param periodDuration - The period duration string to validate.
+ * @returns Object containing parsed duration and any validation error.
  */
 export function validatePeriodDuration(periodDuration: string): {
   duration: number | undefined;

packages/gator-permissions-snap/src/permissions/erc20TokenStream/validation.ts

@@ -1,7 +1,7 @@
 import type { PermissionRequest } from '@metamask/7715-permissions-shared/types';
 import { extractZodError } from '@metamask/7715-permissions-shared/utils';
-import { validateHexInteger } from '../validation';
 
+import { validateHexInteger } from '../validation';
 import type {
   Erc20TokenStreamPermission,
   Erc20TokenStreamPermissionRequest,

packages/gator-permissions-snap/src/permissions/nativeTokenPeriodic/validation.ts

@@ -1,7 +1,7 @@
 import type { PermissionRequest } from '@metamask/7715-permissions-shared/types';
 import { extractZodError } from '@metamask/7715-permissions-shared/utils';
-import { validateHexInteger } from '../validation';
 
+import { validateHexInteger } from '../validation';
 import type {
   NativeTokenPeriodicPermission,
   NativeTokenPeriodicPermissionRequest,

packages/gator-permissions-snap/src/permissions/nativeTokenStream/validation.ts

@@ -1,7 +1,7 @@
 import type { PermissionRequest } from '@metamask/7715-permissions-shared/types';
 import { extractZodError } from '@metamask/7715-permissions-shared/utils';
-import { validateHexInteger } from '../validation';
 
+import { validateHexInteger } from '../validation';
 import type {
   NativeTokenStreamPermission,
   NativeTokenStreamPermissionRequest,

packages/gator-permissions-snap/src/permissions/validation.ts

@@ -1,4 +1,4 @@
-import { Hex } from 'viem';
+import type { Hex } from 'viem';
 
 /**
  * Validates a hex integer value with configurable constraints.
@@ -8,7 +8,7 @@ import { Hex } from 'viem';
  * @param params.value - The hex value to validate.
  * @param params.allowZero - Whether zero values are allowed.
  * @param params.required - Whether the value is required (must be defined).
- * @throws {Error} If the value fails validation.
+ * @throws {Error} If the value fails validation
  */
 export function validateHexInteger({
   name,
@@ -39,6 +39,4 @@ export function validateHexInteger({
   if (parsedValue === 0n && !allowZero) {
     throw new Error(`Invalid ${name}: must be greater than 0`);
   }
-
-  return parsedValue;
 }