Minor improvements:

- use string concatenation to produce storage key in profile sync
- introduce ZERO_ADDRESS constant that is shared between consumers in gator snap

Author: jeffsmale90

packages/gator-permissions-snap/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snap-7715-permissions.git"
   },
   "source": {
-    "shasum": "KIkyDs5vhOacg5T4j5WoWvVF0m9UTxQIez+pNhEYnWQ=",
+    "shasum": "W8+w9wW8zF3UrtMX6lJNQt02TGxIoqh/4d5X4gX2B4s=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

packages/gator-permissions-snap/src/clients/accountApiClient.ts

@@ -1,5 +1,6 @@
 import { logger } from '@metamask/7715-permissions-shared/utils';
 import { type Hex } from '@metamask/delegation-core';
+import { ZERO_ADDRESS } from '../constants';
 
 import type { TokenBalanceAndMetadata } from './types';
 
@@ -35,8 +36,7 @@ type TokenBalanceResponse = {
 export class AccountApiClient {
   static readonly #supportedTokenTypes = ['native', 'erc20'];
 
-  static readonly #nativeTokenAddress =
-    '0x0000000000000000000000000000000000000000';
+  static readonly #nativeTokenAddress = ZERO_ADDRESS;
 
   readonly #fetch: typeof globalThis.fetch;
 

packages/gator-permissions-snap/src/clients/blockchainMetadataClient.ts

@@ -2,6 +2,7 @@ import { logger } from '@metamask/7715-permissions-shared/utils';
 import { decodeSingle } from '@metamask/abi-utils';
 import type { Hex } from '@metamask/delegation-core';
 import type { SnapsEthereumProvider } from '@metamask/snaps-sdk';
+import { ZERO_ADDRESS } from '../constants';
 
 import type { TokenBalanceAndMetadata, TokenMetadataClient } from './types';
 
@@ -11,8 +12,7 @@ import type { TokenBalanceAndMetadata, TokenMetadataClient } from './types';
 export class BlockchainTokenMetadataClient implements TokenMetadataClient {
   readonly #ethereumProvider: SnapsEthereumProvider;
 
-  static readonly #nativeTokenAddress =
-    '0x0000000000000000000000000000000000000000';
+  static readonly #nativeTokenAddress = ZERO_ADDRESS;
 
   static readonly #nativeTokenDecimals = 18;
 

packages/gator-permissions-snap/src/constants.ts

@@ -0,0 +1,2 @@
+export const ZERO_ADDRESS =
+  '0x0000000000000000000000000000000000000000' as const;

packages/gator-permissions-snap/src/profileSync/profileSync.ts

@@ -12,7 +12,6 @@ import type {
   JwtBearerAuth,
   UserStorage,
 } from '@metamask/profile-sync-controller/sdk';
-import { bytesToHex } from '@metamask/utils';
 
 export type ProfileSyncManager = {
   getAllGrantedPermissions: () => Promise<StoredGrantedPermission[]>;
@@ -80,18 +79,10 @@ export function createProfileSyncManager(
   function generateObjectKey(permissionContext: Hex): Hex {
     const delegations = decodeDelegations(permissionContext);
     const hashes = delegations.map((delegation) =>
-      hashDelegation(delegation, { out: 'bytes' }),
+      hashDelegation(delegation).slice(2),
     );
 
-    const keyBytes = new Uint8Array(hashes.length * 32);
-    for (let i = 0; i < hashes.length; i++) {
-      const hash = hashes[i];
-      if (hash) {
-        keyBytes.set(hash, i * 32);
-      }
-    }
-
-    return bytesToHex(keyBytes);
+    return `0x${hashes.join('')}`;
   }
 
   /**