fix: name confirmation aligned with method request (#423)

Aims to fix MetaMask/metamask-extension#33622
Changes the name of the confirmation accordingly with method requested

Author: aganglada

packages/snap/locales/en.json

@@ -148,9 +148,15 @@
     "confirmation.confirmButton": {
       "message": "Confirm"
     },
-    "confirmation.title": {
+    "confirmation.signAndSendTransaction.title": {
       "message": "Transaction request"
     },
+    "confirmation.signTransaction.title": {
+      "message": "Signing request"
+    },
+    "confirmation.sendAndConfirmTransaction.title": {
+      "message": "Sending and confirming transaction"
+    },
     "confirmation.advanced.unknownInstruction": {
       "message": "Unknown"
     },

packages/snap/messages.json

@@ -48,7 +48,9 @@
   "confirmation.advanced.hide": "Hide advanced",
   "confirmation.cancelButton": "Cancel",
   "confirmation.confirmButton": "Confirm",
-  "confirmation.title": "Transaction request",
+  "confirmation.signAndSendTransaction.title": "Transaction request",
+  "confirmation.signTransaction.title": "Signing request",
+  "confirmation.sendAndConfirmTransaction.title": "Sending and confirming transaction",
   "confirmation.advanced.unknownInstruction": "Unknown",
   "confirmation.advanced.programId": "Program ID",
   "confirmation.advanced.data": "Data",
@@ -84,4 +86,4 @@
   "transactionScan.errors.insufficientSol": "Account does not have enough SOL to perform the operation.",
   "transactionScan.errors.slippageToleranceExceeded": "The transaction was reverted because the slippage tolerance was exceeded.",
   "transactionScan.errors.unknownError": "An unknown error occurred."
-}
+}

packages/snap/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snap-solana-wallet.git"
   },
   "source": {
-    "shasum": "0G8PXZNx7ioU2jbDWfX7Qv94bxORrt2q1mgWZj/ajow=",
+    "shasum": "rx+CMYlfj25LOq11FMftpUP3nc+J+mO7C64XS2cmrGw=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

packages/snap/src/core/validation/structs.ts

@@ -185,14 +185,6 @@ export const ListAccountAssetsResponseStruct = array(CaipAssetTypeStruct);
 
 export const SubmitRequestMethodStruct = enums(Object.values(SolMethod));
 
-export const SendAndConfirmTransactionParamsStruct = object({
-  base64EncodedTransactionMessage: string(),
-});
-
-export type SendAndConfirmTransactionParams = Infer<
-  typeof SendAndConfirmTransactionParamsStruct
->;
-
 export const NetworkStruct = enums(Object.values(Network));
 
 export const Curenc = enums([

packages/snap/src/features/confirmation/views/ConfirmTransactionRequest/ConfirmTransactionRequest.tsx

@@ -42,7 +42,9 @@ export const ConfirmTransactionRequest = ({
         ) : null}
         <Box alignment="center" center>
           <Box>{null}</Box>
-          <Heading size="lg">{translate('confirmation.title')}</Heading>
+          <Heading size="lg">
+            {translate(`confirmation.${context.method}.title`)}
+          </Heading>
           <Box>{null}</Box>
         </Box>
         {context.preferences.simulateOnChainActions ? (