feat: implement onAssetsMarketData handler

ulissesferreira · ulissesferreira · commit ac0f2969cb35 · 2025-07-01T10:25:09.000+01:00
diff --git a/packages/snap/locales/de.json b/packages/snap/locales/de.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/el.json b/packages/snap/locales/el.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/es.json b/packages/snap/locales/es.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/fr.json b/packages/snap/locales/fr.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/hi.json b/packages/snap/locales/hi.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/id.json b/packages/snap/locales/id.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/ja.json b/packages/snap/locales/ja.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/ko.json b/packages/snap/locales/ko.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/pt.json b/packages/snap/locales/pt.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/ru.json b/packages/snap/locales/ru.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/tl.json b/packages/snap/locales/tl.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/tr.json b/packages/snap/locales/tr.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/vi.json b/packages/snap/locales/vi.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/locales/zh.json b/packages/snap/locales/zh.json
@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}
diff --git a/packages/snap/package.json b/packages/snap/package.json
@@ -79,4 +79,4 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   }
-}
+}
diff --git a/packages/snap/snap.manifest.json b/packages/snap/snap.manifest.json
@@ -16,22 +16,32 @@
         "registry": "https://registry.npmjs.org/"
       }
     },
-    "locales": ["locales/en.json"]
+    "locales": [
+      "locales/en.json"
+    ]
   },
   "initialConnections": {
-    "https://portfolio.metamask.io": {}
+    "https://portfolio.metamask.io": {},
+    "http://localhost:3000": {}
   },
   "initialPermissions": {
     "endowment:rpc": {
       "dapps": true,
       "snaps": false
     },
     "endowment:keyring": {
-      "allowedOrigins": ["https://portfolio.metamask.io"]
+      "allowedOrigins": [
+        "https://portfolio.metamask.io",
+        "http://localhost:3000"
+      ]
     },
     "snap_getBip32Entropy": [
       {
-        "path": ["m", "44'", "501'"],
+        "path": [
+          "m",
+          "44'",
+          "501'"
+        ],
         "curve": "ed25519"
       }
     ],
@@ -92,4 +102,4 @@
   },
   "platformVersion": "8.1.0",
   "manifestVersion": "0.1"
-}
+}
diff --git a/packages/snap/src/core/handlers/onAssetsConversion/onAssetsConversion.ts b/packages/snap/src/core/handlers/onAssetsConversion/onAssetsConversion.ts
@@ -10,13 +10,10 @@ export const onAssetsConversion: OnAssetsConversionHandler = async (params) => {
   try {
     logger.log('[💱 onAssetsConversion]', params);
 
-    const { conversions, includeMarketData } = params;
+    const { conversions } = params;
 
     const conversionRates =
-      await tokenPricesService.getMultipleTokenConversions(
-        conversions,
-        includeMarketData,
-      );
+      await tokenPricesService.getMultipleTokenConversions(conversions);
 
     return {
       conversionRates,
diff --git a/packages/snap/src/core/handlers/onAssetsLookup/onAssetsLookup.ts b/packages/snap/src/core/handlers/onAssetsLookup/onAssetsLookup.ts
@@ -1,12 +1,20 @@
-import type { OnAssetsLookupHandler } from '@metamask/snaps-sdk';
+import { InternalError, type OnAssetsLookupHandler } from '@metamask/snaps-sdk';
 
 import { tokenMetadataClient } from '../../../snapContext';
+import logger from '../../utils/logger';
 
 export const onAssetsLookup: OnAssetsLookupHandler = async (params) => {
-  const { assets } = params;
+  try {
+    logger.log('[🔍 onAssetsLookup]', params);
 
-  const metadata =
-    await tokenMetadataClient.getTokenMetadataFromAddresses(assets);
+    const { assets } = params;
 
-  return { assets: metadata };
+    const metadata =
+      await tokenMetadataClient.getTokenMetadataFromAddresses(assets);
+
+    return { assets: metadata };
+  } catch (error: any) {
+    logger.error('[🔍 onAssetsLookup]', error);
+    throw new InternalError(error) as Error;
+  }
 };
diff --git a/packages/snap/src/core/handlers/onAssetsMarketData/onAssetsMarketData.test.ts b/packages/snap/src/core/handlers/onAssetsMarketData/onAssetsMarketData.test.ts
diff --git a/packages/snap/src/core/handlers/onAssetsMarketData/onAssetsMarketData.ts b/packages/snap/src/core/handlers/onAssetsMarketData/onAssetsMarketData.ts
diff --git a/packages/snap/src/core/services/assets/AssetsService.test.ts b/packages/snap/src/core/services/assets/AssetsService.test.ts
diff --git a/packages/snap/src/core/services/assets/AssetsService.ts b/packages/snap/src/core/services/assets/AssetsService.ts
diff --git a/packages/snap/src/core/services/token-prices/TokenPrices.test.ts b/packages/snap/src/core/services/token-prices/TokenPrices.test.ts
diff --git a/packages/snap/src/core/services/token-prices/TokenPrices.ts b/packages/snap/src/core/services/token-prices/TokenPrices.ts
diff --git a/packages/snap/src/core/test/mocks/market-data.ts b/packages/snap/src/core/test/mocks/market-data.ts
diff --git a/packages/snap/src/snapContext.ts b/packages/snap/src/snapContext.ts
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -266,4 +266,4 @@`
`266`	`266`	`"message": "An unknown error occurred."`
`267`	`267`	`}`
`268`	`268`	`}`
`269`		`-}`
	`269`	`+}`