chore: fix review comments

Author: aganglada

packages/snap/src/core/handlers/onNameLookup/onNameLookup.ts

@@ -2,12 +2,12 @@ import { type OnNameLookupHandler } from '@metamask/snaps-sdk';
 import { assert } from '@metamask/superstruct';
 
 import { nameResolutionService } from '../../../snapContext';
-import { SolanaNameLookupRequesstStruct } from './structs';
+import { SolanaNameLookupRequestStruct } from './structs';
 
 const SOLANA_NAME_SERVICE_PROTOCOL = 'Solana Name Service';
 
 export const onNameLookupHandler: OnNameLookupHandler = async (request) => {
-  assert(request, SolanaNameLookupRequesstStruct);
+  assert(request, SolanaNameLookupRequestStruct);
 
   const { chainId, domain, address } = request;
 

packages/snap/src/core/handlers/onNameLookup/structs.ts

@@ -2,7 +2,7 @@ import { object, optional, string } from '@metamask/superstruct';
 
 import { NetworkStruct } from '../../validation/structs';
 
-export const SolanaNameLookupRequesstStruct = object({
+export const SolanaNameLookupRequestStruct = object({
   chainId: NetworkStruct,
   domain: optional(string()),
   address: optional(string()),

packages/snap/src/features/send/utils/isSolanaDomain.test.ts

@@ -50,8 +50,8 @@ describe('isSolanaDomain', () => {
       expect(isSolanaDomain('')).toBe(false);
     });
 
-    it('returns true for string with only .sol', () => {
-      expect(isSolanaDomain('.sol')).toBe(true);
+    it('returns false for string with only .sol', () => {
+      expect(isSolanaDomain('.sol')).toBe(false);
     });
 
     it('returns false for string ending with .SOL (uppercase)', () => {

packages/snap/src/features/send/utils/isSolanaDomain.ts

@@ -2,8 +2,19 @@
  * Checks if a domain is a Solana domain (.sol).
  *
  * @param domain - The domain to check.
- * @returns `true` if the domain ends with `.sol`, `false` otherwise. Returns `false` if the domain is `null`.
+ * @returns `true` if the domain is a valid domain ending with `.sol`, `false` otherwise. Returns `false` if the domain is `null`.
  */
 export function isSolanaDomain(domain: string | null): boolean {
-  return domain?.endsWith('.sol') ?? false;
+  if (!domain) {
+    return false;
+  }
+
+  // Regex to match valid domain ending with .sol
+  // Allows letters, numbers, hyphens, but not starting/ending with hyphen
+  // Must have at least one character before .sol
+  // Supports subdomains (e.g., sub.example.sol)
+  const solanaDomainRegex =
+    /^[a-zA-Z0-9]([a-zA-Z0-9-]*[a-zA-Z0-9])?(\.[a-zA-Z0-9]([a-zA-Z0-9-]*[a-zA-Z0-9])?)*\.sol$/u;
+
+  return solanaDomainRegex.test(domain);
 }