Skip to content

Commit 529fdab

Browse files
Jeremy TsangJeremy Tsang
authored andcommitted
docs: correct design doc — snaps-utils resolution bump was required
1 parent c5921e0 commit 529fdab

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

docs/plans/2026-06-30-stellar-keyring-v2-design.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,19 @@ Already in place (no change needed):
2424
`withCatchAndThrowSnapError` (`handlers/keyring/keyring.ts:115`), so every
2525
method already surfaces a `SnapError`.
2626

27-
**No dependency bumps and no `platformVersion` change are required.**
27+
**No `platformVersion` change is required.** One dependency-resolution bump was
28+
required during implementation, discovered only when the manifest change was
29+
attempted: `endowment:keyring.capabilities` (the manifest field itself) is
30+
validated by `@metamask/snaps-utils`, and that field's validation was only
31+
added in `snaps-utils@12.2.0` — the version resolved by the existing
32+
`snaps-cli@^8.4.0` range was `12.1.0`, which rejects the field as an unknown
33+
key. Fixed with an exact (non-caret) `resolutions` pin,
34+
`"@metamask/snaps-utils": "12.2.0"`, plus a `yarn dedupe` pass. A caret range
35+
(`^12.2.0`) was tried first and rejected: it resolves to `12.2.1`, which bumps
36+
`@metamask/permission-controller` to a `13.x` major and drags in an unrelated
37+
`@ethersproject/*`/`controller-utils@12.x` subtree. The exact pin avoids that
38+
`snaps-utils@12.2.0` itself only needs `permission-controller@^12.3.0`, the
39+
same major line already in the lockfile.
2840

2941
## Remaining delta (this ticket)
3042

0 commit comments

Comments
 (0)