Changed updatePluginState to use proper key pluginStates (#48)

* Changed updatePluginState to use proper key `pluginStates`

* Added test for PluginController updatePluginState and getPluginState

* Update packages/controllers/src/plugins/PluginController.test.ts

* Changed plugin code and assert plugin public state

* Update packages/controllers/src/plugins/PluginController.test.ts

Fix state

Author: shanejonas

packages/controllers/src/plugins/PluginController.test.ts

@@ -40,8 +40,65 @@ describe('PluginController Controller', () => {
         name: 'PluginController',
       }),
     });
+
     expect(pluginController).toBeDefined();
   });
+  it('can create a worker and plugin controller and add a plugin and update its state', async () => {
+    const workerExecutionEnvironment = new WebWorkerExecutionEnvironmentService(
+      {
+        setupPluginProvider: jest.fn(),
+        workerUrl: new URL(URL.createObjectURL(new Blob([workerCode]))),
+      },
+    );
+    const pluginController = new PluginController({
+      terminateAllPlugins: workerExecutionEnvironment.terminateAllPlugins.bind(
+        workerExecutionEnvironment,
+      ),
+      terminatePlugin: workerExecutionEnvironment.terminatePlugin.bind(
+        workerExecutionEnvironment,
+      ),
+      executePlugin: workerExecutionEnvironment.executePlugin.bind(
+        workerExecutionEnvironment,
+      ),
+      getRpcMessageHandler:
+        workerExecutionEnvironment.getRpcMessageHandler.bind(
+          workerExecutionEnvironment,
+        ),
+      removeAllPermissionsFor: jest.fn(),
+      getPermissions: jest.fn(),
+      hasPermission: jest.fn(),
+      requestPermissions: jest.fn(),
+      closeAllConnections: jest.fn(),
+      messenger: new ControllerMessenger<any, any>().getRestricted({
+        name: 'PluginController',
+      }),
+    });
+    const plugin = await pluginController.add({
+      name: 'TestPlugin',
+      sourceCode: `
+        wallet.registerRpcMessageHandler(async (origin, request) => {
+          const {method, params, id} = request;
+          return method + id;
+        });
+      `,
+      manifest: {
+        web3Wallet: {
+          initialPermissions: {},
+        },
+        version: '0.0.0-development',
+      },
+    });
+
+    await pluginController.startPlugin(plugin.name);
+    await pluginController.updatePluginState(plugin.name, { hello: 'world' });
+    const pluginState = await pluginController.getPluginState(plugin.name);
+    expect(pluginState).toEqual({ hello: 'world' });
+    expect(pluginController.state.pluginStates).toEqual({
+      TestPlugin: {
+        hello: 'world',
+      },
+    });
+  });
 
   it('can add a plugin and use its JSON-RPC api with a WebWorkerExecutionEnvironmentService', async () => {
     const webWorkerExecutionEnvironment =

packages/controllers/src/plugins/PluginController.ts

@@ -342,7 +342,7 @@ export class PluginController extends BaseController<
     newPluginState: Json,
   ): Promise<void> {
     this.update((state: any) => {
-      state[pluginName] = newPluginState;
+      state.pluginStates[pluginName] = newPluginState;
     });
   }