Replace controller with hook approach

Author: david0xd

packages/snaps-controllers/src/snaps/SnapController.ts

@@ -167,7 +167,6 @@ import type {
   ExportableKeyEncryptor,
   KeyDerivationOptions,
 } from '../types';
-import type { MetaMetricsController } from '../utils';
 import {
   debouncePersistState,
   fetchSnap,
@@ -777,9 +776,9 @@ type SnapControllerArgs = {
   clientCryptography?: CryptographicFunctions;
 
   /**
-   * MetaMetrics controller instance. Used for event tracking.
+   * MetaMetrics event tracking hook.
    */
-  metaMetricsController: MetaMetricsController;
+  trackEvent: TrackEventHook;
 };
 
 type AddSnapArgs = {
@@ -800,6 +799,14 @@ type SetSnapArgs = Omit<AddSnapArgs, 'location' | 'versionRange'> & {
   hideSnapBranding?: boolean;
 };
 
+type TrackingEventPayload = {
+  event: string;
+  category: string;
+  properties: Record<string, Json>;
+};
+
+type TrackEventHook = (event: TrackingEventPayload) => void;
+
 const defaultState: SnapControllerState = {
   snaps: {},
   snapStates: {},
@@ -885,31 +892,9 @@ export class SnapController extends BaseController<
 
   readonly #preinstalledSnaps: PreinstalledSnap[] | null;
 
-  readonly #metaMetricsController: MetaMetricsController;
+  readonly #trackEvent: TrackEventHook;
 
-  readonly #trackSnapExport = throttleTracking(
-    async (
-      snapId: SnapId,
-      handler: string,
-      success: boolean,
-      origin: string,
-    ) => {
-      const snapMetadata = await this.getRegistryMetadata(snapId);
-      this.#metaMetricsController.trackEvent({
-        event: 'SnapExportUsed',
-        category: 'Snaps',
-        properties: {
-          // eslint-disable-next-line @typescript-eslint/naming-convention
-          snap_id: snapId,
-          export: handler,
-          // eslint-disable-next-line @typescript-eslint/naming-convention
-          snap_category: snapMetadata?.category,
-          success,
-          origin,
-        },
-      });
-    },
-  );
+  readonly #trackSnapExport: ReturnType<typeof throttleTracking>;
 
   constructor({
     closeAllConnections,
@@ -929,7 +914,7 @@ export class SnapController extends BaseController<
     getMnemonicSeed,
     getFeatureFlags = () => ({}),
     clientCryptography,
-    metaMetricsController,
+    trackEvent,
   }: SnapControllerArgs) {
     super({
       messenger,
@@ -992,7 +977,7 @@ export class SnapController extends BaseController<
     this._onOutboundResponse = this._onOutboundResponse.bind(this);
     this.#rollbackSnapshots = new Map();
     this.#snapsRuntimeData = new Map();
-    this.#metaMetricsController = metaMetricsController;
+    this.#trackEvent = trackEvent;
 
     this.#pollForLastRequestStatus();
 
@@ -1058,6 +1043,30 @@ export class SnapController extends BaseController<
     Object.values(this.state?.snaps ?? {}).forEach((snap) =>
       this.#setupRuntime(snap.id),
     );
+
+    this.#trackSnapExport = throttleTracking(
+      async (
+        snapId: SnapId,
+        handler: string,
+        success: boolean,
+        origin: string,
+      ) => {
+        const snapMetadata = await this.getRegistryMetadata(snapId);
+        this.#trackEvent({
+          event: 'SnapExportUsed',
+          category: 'Snaps',
+          properties: {
+            // eslint-disable-next-line @typescript-eslint/naming-convention
+            snap_id: snapId,
+            export: handler,
+            // eslint-disable-next-line @typescript-eslint/naming-convention
+            snap_category: snapMetadata?.category ?? null,
+            success,
+            origin,
+          },
+        });
+      },
+    );
   }
 
   /**

packages/snaps-controllers/src/utils.ts

@@ -377,17 +377,6 @@ export function debouncePersistState(
   };
 }
 
-/**
- * Scaled MetaMetrics controller type.
- */
-export type MetaMetricsController = {
-  trackEvent: (payload: {
-    event: string;
-    category: string;
-    properties?: Record<string, unknown>;
-  }) => void;
-};
-
 /**
  * Handlers allowed for tracking.
  */