refactor!: Use hash private functions for updating internals#3601
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3601 +/- ##
==========================================
- Coverage 98.28% 98.28% -0.01%
==========================================
Files 417 417
Lines 11771 11763 -8
Branches 1832 1828 -4
==========================================
- Hits 11569 11561 -8
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
reviewed
Sep 2, 2025
Mrtenz
reviewed
Sep 2, 2025
Mrtenz
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
updateSnap,processRequestedSnapandauthorizedo not need to be part of the public API and it makes maintaining them much simpler if they aren't. This PR makes them all hash private and modifies tests to use theinstallSnapspublic API instead. This is also what is used in production for all updating of Snaps.Since these functions are guaranteed to be called only internally, this PR also removes some dead code that was no longer needed.
This effort was moved out of the OTA branch to simplify review but does contain breaking changes, namely the above functions no longer being callable.