Fix issue of pipe closing prematurely (after 10 seconds).

Now wait for pipe to be ready to be read indefinitely

Author: jgray-19

src/pymadng/madp_object.py

@@ -467,10 +467,6 @@ def __enter__(self):
         return self
 
     def __exit__(self, exc_type, exc_value, tb):
-        # Close the process, as the with statement is finished
-        # assert self.__process.send("py:send('closing')").recv("close") == "closing", (
-        #     "Error in waiting for the process to close"
-        # ) # If you can test this does anything, please implement it. I have a feeling it does (jgray 2025)
         self.__process.close()
 
     # ---------------------------------------------------------------------------------------------------#

src/pymadng/madp_pymad.py

@@ -237,7 +237,7 @@ def close(self) -> None:
         """Close the pipes and wait for the process to finish"""
         if self.process.poll() is None:  # If process is still running
             self.send(f"{self.py_name}:__fin()")  # Tell the mad side to finish
-            open_pipe = select.select([self.mad_read_stream], [], [], 10)
+            open_pipe = select.select([self.mad_read_stream], [], [])
             if open_pipe[0]:
                 # Wait for the mad side to finish (variable name in case of errors that need to be caught elsewhere)
                 close_msg = self.recv("closing")

tests/comm_test.py

@@ -390,17 +390,6 @@ def test_print(self):
             mad.send("py:send('hello world')")
             self.assertEqual(mad.recv(), "hello world") # Check printing does not affect pipe
 
-    # def test_closing(self):
-    # This test doesn't work. I find every now and then my mad process is closed before 
-    # MAD-NG has finished executing. I don't know why this happens, and this test does
-    # not reproduce the error. (jgray 2025)
-        # with MAD() as mad:
-        #     mad.send('for i = 1, 1e10 do a = 1 + 4 end') # This will catch times when the mad process is closed early 
-        #     mad.send('io.open("test.txt", "w"):close()')
-        # created_file = Path("test.txt")
-        # self.assertTrue(created_file.exists())
-        # created_file.unlink()
-
 class TestDebug(unittest.TestCase):
     test_log1 = inputs_folder/"test.log"
     def test_logfile(self):

tests/inputs/example.log

@@ -1,9 +1,10 @@
 ***pymad.recv: binary data 4 bytes
 ***pymad.recv: [io.stdout:setvbuf('line')] 25 bytes
 ***pymad.recv: binary data 4 bytes
-***pymad.recv: [py:send(1)] 10 bytes
-***pymad.send: [int_] 4 bytes
+***pymad.recv: [py:send('started')] 18 bytes
+***pymad.send: [str_] 4 bytes
 ***pymad.send: binary data 4 bytes
+***pymad.send: [started] 7 bytes
 ***pymad.recv: binary data 4 bytes
 ***pymad.recv: [element = MAD.element
 sequence = MAD.sequence
@@ -37,11 +38,6 @@ end
 _last = {}
   ] 138 bytes
 ***pymad.recv: binary data 4 bytes
-***pymad.recv: [py:send('closing')] 18 bytes
-***pymad.send: [str_] 4 bytes
-***pymad.send: binary data 4 bytes
-***pymad.send: [closing] 7 bytes
-***pymad.recv: binary data 4 bytes
 ***pymad.recv: [py:__fin()] 10 bytes
 ***pymad.send: [str_] 4 bytes
 ***pymad.send: binary data 4 bytes