Fix path conversion closure condition (#1807)

Author: MewPurPur

src/data_classes/ElementPath.gd

@@ -166,7 +166,8 @@ func _solve_quadratic(a: float, b: float, c: float) -> Array[float]:
 	if is_nan(D):
 		return []
 	else:
-		return [(-b + D) / (2 * a), (-b - D) / (2 * a)]
+		var double_a := 2 * a
+		return [(-b + D) / double_a, (-b - D) / double_a]
 
 
 func can_replace(new_element: String) -> bool:
@@ -210,9 +211,10 @@ func get_replacement(new_element: String) -> Element:
 		"polygon":
 			dropped_attributes = PackedStringArray(["points", "d"])
 			var points := PackedFloat64Array()
-			# Skip the closure if there are multiple points.
-			for i in (command_count if command_count < 2 else command_count - 1):
+			for i in command_count:
 				var command := pathdata.get_command(i)
+				if command is PathCommand.CloseCommand:
+					break
 				var x: float = command.x if not command is PathCommand.VerticalLineCommand else command.start_x
 				var y: float = command.y if not command is PathCommand.HorizontalLineCommand else command.start_y
 				points.append_array(PackedFloat64Array([x, y]))

src/ui_parts/good_file_dialog.gd

@@ -461,8 +461,7 @@ func _on_file_list_item_multi_selected(index: int, selected: bool) -> void:
 	if selected:
 		call_selection_callback(file_list.get_item_metadata(index))
 
-func _on_file_list_item_clicked(index: int, _at_position: Vector2,
-mouse_button_index: int) -> void:
+func _on_file_list_item_clicked(index: int, _at_position: Vector2, mouse_button_index: int) -> void:
 	if mouse_button_index == MOUSE_BUTTON_RIGHT:
 		call_right_click_callback(file_list.get_item_metadata(index))
 

src/ui_widgets/choose_name_dialog.gd

@@ -27,8 +27,7 @@ func _on_name_edit_text_submitted(_text: String) -> void:
 		cancel_button.grab_focus()
 
 # The error/warning callables should take the stripped text and return a string.
-func setup(title: String, action: Callable, error_callable := Callable(),
-warning_callable := Callable()) -> void:
+func setup(title: String, action: Callable, error_callable := Callable(), warning_callable := Callable()) -> void:
 	title_label.text = title
 	action_button.pressed.connect(
 		func() -> void:

src/utils/FileUtils.gd

@@ -514,8 +514,7 @@ class WebSafeFileAccess:
 			return _file_access.get_length()
 
 
-static func _web_load_files(allowed_extensions: PackedStringArray,
-completion_callback: Callable, multi_select: bool) -> void:
+static func _web_load_files(allowed_extensions: PackedStringArray, completion_callback: Callable, multi_select: bool) -> void:
 	var allowed_extensions_with_dots := PackedStringArray()
 	for allowed_extension in allowed_extensions:
 		allowed_extensions_with_dots.append("." + allowed_extension)