Remove extreme dimensions warning (#1779)

Author: MewPurPur

src/autoload/HandlerGUI.gd

@@ -737,25 +737,14 @@ func open_export() -> void:
 	var width := State.root_element.width
 	var height := State.root_element.height
 
-	var dimensions_valid := (is_finite(width) and is_finite(height) and width > 0.0 and height > 0.0)
-	var dimensions_too_different := false
-	
-	if dimensions_valid:
-		dimensions_too_different = (1 / minf(width, height) > 16384 / maxf(width, height))
-		if not dimensions_too_different:
-			add_menu(ExportMenuScene.instantiate())
-			return
-	
-	var message: String
-	if dimensions_too_different:
-		message = Translator.translate("The graphic can be exported only as SVG because its proportions are too extreme.")
-	else:
-		message = Translator.translate("The graphic can be exported only as SVG because its size is not defined.")
-	message += "\n\n" + Translator.translate("Do you want to proceed?")
+	if is_finite(width) and is_finite(height) and width > 0.0 and height > 0.0:
+		add_menu(ExportMenuScene.instantiate())
+		return
 
 	var confirm_dialog := ConfirmDialogScene.instantiate()
 	add_menu(confirm_dialog)
-	confirm_dialog.setup(Translator.translate("Export SVG"), message,
+	confirm_dialog.setup(Translator.translate("Export SVG"), "%s\n\n%s" %\
+			[Translator.translate("The graphic can only be exported as SVG because its size is undefined."), Translator.translate("Do you want to proceed?")],
 			Translator.translate("Export"), FileUtils.open_export_dialog.bind(ImageExportDataSVG.new()))
 
 

src/ui_widgets/export_scale_config.gd

@@ -27,10 +27,12 @@ func setup(new_original_width: float, new_original_height: float, initial_scale:
 		await ready
 	original_width = new_original_width
 	original_height = new_original_height
-	scale_edit.min_value = 1 / minf(original_width, new_original_height)
-	scale_edit.max_value = max_dimension / maxf(new_original_width, new_original_height)
-	width_edit.max_value = max_dimension
-	height_edit.max_value = max_dimension
+	var bigger_dimension := maxf(original_width, original_height)
+	var max_scale := max_dimension / bigger_dimension
+	scale_edit.min_value = 1 / bigger_dimension
+	scale_edit.max_value = max_dimension / bigger_dimension
+	width_edit.max_value = floori(original_width * max_scale)
+	height_edit.max_value = floori(original_height * max_scale)
 	scale_edit.value_changed.connect(_on_scale_edit_value_changed)
 	width_edit.value_changed.connect(_on_width_edit_value_changed)
 	height_edit.value_changed.connect(_on_height_edit_value_changed)

translations/GodSVG.pot

@@ -40,10 +40,6 @@ msgstr ""
 msgid "OK"
 msgstr ""
 
-#: src/autoload/HandlerGUI.gd
-msgid "The graphic can be exported only as SVG because its proportions are too extreme."
-msgstr ""
-
 #: src/autoload/HandlerGUI.gd
 msgid "The graphic can be exported only as SVG because its size is not defined."
 msgstr ""
@@ -493,10 +489,6 @@ msgstr ""
 msgid "Add preview"
 msgstr ""
 
-#: src/ui_parts/previews.gd
-msgid "Add new preview"
-msgstr ""
-
 #: src/ui_parts/previews.gd src/ui_widgets/palette_config.gd
 #: src/ui_widgets/setting_shortcut.gd src/ui_widgets/transform_popup.gd
 #: src/utils/TranslationUtils.gd

translations/bg.po

@@ -41,10 +41,6 @@ msgstr "Това ще се свърже с github.com за да сравни ч
 msgid "OK"
 msgstr "Добре"
 
-#: src/autoload/HandlerGUI.gd
-msgid "The graphic can be exported only as SVG because its proportions are too extreme."
-msgstr "Графиката може да бъде експортирана само като SVG защото височината и широчината са твърде различни."
-
 #: src/autoload/HandlerGUI.gd
 msgid "The graphic can be exported only as SVG because its size is not defined."
 msgstr "Графиката може да бъде експортирана само като SVG защото размерът не е определен."
@@ -494,10 +490,6 @@ msgstr "Помощ"
 msgid "Add preview"
 msgstr "Добави гледка"
 
-#: src/ui_parts/previews.gd
-msgid "Add new preview"
-msgstr "Добави нова гледка"
-
 #: src/ui_parts/previews.gd src/ui_widgets/palette_config.gd
 #: src/ui_widgets/setting_shortcut.gd src/ui_widgets/transform_popup.gd
 #: src/utils/TranslationUtils.gd

translations/de.po

@@ -41,10 +41,6 @@ msgstr "Dadurch wird eine Verbindung zu github.com hergestellt, um Versionsnumme
 msgid "OK"
 msgstr "OK"
 
-#: src/autoload/HandlerGUI.gd
-msgid "The graphic can be exported only as SVG because its proportions are too extreme."
-msgstr "Die Grafik kann nur als SVG exportiert werden, da ihre Proportionen zu extrem sind."
-
 #: src/autoload/HandlerGUI.gd
 msgid "The graphic can be exported only as SVG because its size is not defined."
 msgstr "Die Grafik kann nur als SVG exportiert werden, da ihre Größe nicht definiert ist."
@@ -503,11 +499,6 @@ msgstr "Hilfe"
 msgid "Add preview"
 msgstr "Farbe hinzufügen"
 
-#: src/ui_parts/previews.gd
-#, fuzzy
-msgid "Add new preview"
-msgstr "Farbe hinzufügen"
-
 #: src/ui_parts/previews.gd src/ui_widgets/palette_config.gd
 #: src/ui_widgets/setting_shortcut.gd src/ui_widgets/transform_popup.gd
 #: src/utils/TranslationUtils.gd
@@ -1747,6 +1738,13 @@ msgstr ""
 msgid "svg;vector;graphics;draw;design;illustration;image;art;diagram;icon;logo;editor;path;shape;2D;code;blue;fox"
 msgstr ""
 
+#~ msgid "The graphic can be exported only as SVG because its proportions are too extreme."
+#~ msgstr "Die Grafik kann nur als SVG exportiert werden, da ihre Proportionen zu extrem sind."
+
+#, fuzzy
+#~ msgid "Add new preview"
+#~ msgstr "Farbe hinzufügen"
+
 #, fuzzy
 #~ msgid "Add new color"
 #~ msgstr "Farbe hinzufügen"

translations/en.po

@@ -41,10 +41,6 @@ msgstr ""
 msgid "OK"
 msgstr ""
 
-#: src/autoload/HandlerGUI.gd
-msgid "The graphic can be exported only as SVG because its proportions are too extreme."
-msgstr ""
-
 #: src/autoload/HandlerGUI.gd
 msgid "The graphic can be exported only as SVG because its size is not defined."
 msgstr ""
@@ -494,10 +490,6 @@ msgstr ""
 msgid "Add preview"
 msgstr ""
 
-#: src/ui_parts/previews.gd
-msgid "Add new preview"
-msgstr ""
-
 #: src/ui_parts/previews.gd src/ui_widgets/palette_config.gd
 #: src/ui_widgets/setting_shortcut.gd src/ui_widgets/transform_popup.gd
 #: src/utils/TranslationUtils.gd

translations/es.po

@@ -41,10 +41,6 @@ msgstr "Esto se conectará a github.com para comparar los números de versión.
 msgid "OK"
 msgstr "Aceptar"
 
-#: src/autoload/HandlerGUI.gd
-msgid "The graphic can be exported only as SVG because its proportions are too extreme."
-msgstr "El gráfico solo se puede exportar como SVG porque sus proporciones son demasiado extremas."
-
 #: src/autoload/HandlerGUI.gd
 msgid "The graphic can be exported only as SVG because its size is not defined."
 msgstr "El gráfico solo se puede exportar como SVG porque su tamaño no está definido."
@@ -496,10 +492,6 @@ msgstr "Ayuda"
 msgid "Add preview"
 msgstr "Añadir nueva vista previa"
 
-#: src/ui_parts/previews.gd
-msgid "Add new preview"
-msgstr "Añadir nueva vista previa"
-
 #: src/ui_parts/previews.gd src/ui_widgets/palette_config.gd
 #: src/ui_widgets/setting_shortcut.gd src/ui_widgets/transform_popup.gd
 #: src/utils/TranslationUtils.gd
@@ -1700,6 +1692,12 @@ msgstr "Una aplicación de gráficos vectoriales para edición SVG estructurada"
 msgid "svg;vector;graphics;draw;design;illustration;image;art;diagram;icon;logo;editor;path;shape;2D;code;blue;fox"
 msgstr "svg;vector;gráficos;dibujo;diseño;ilustración;imagen;arte;diagrama;icono;logo;editor;ruta;forma;2D;código;azul;zorro"
 
+#~ msgid "The graphic can be exported only as SVG because its proportions are too extreme."
+#~ msgstr "El gráfico solo se puede exportar como SVG porque sus proporciones son demasiado extremas."
+
+#~ msgid "Add new preview"
+#~ msgstr "Añadir nueva vista previa"
+
 #~ msgid "Add new color"
 #~ msgstr "Añadir nuevo color"
 

translations/et.po

@@ -41,10 +41,6 @@ msgstr "See ühendab github.com-i, et saada versioonide teabe. Muid andmeid ei k
 msgid "OK"
 msgstr "Okei"
 
-#: src/autoload/HandlerGUI.gd
-msgid "The graphic can be exported only as SVG because its proportions are too extreme."
-msgstr "Graafika saab eksportida ainult SVG-na, sest selle proportsioonid on liiga ekstreemsed."
-
 #: src/autoload/HandlerGUI.gd
 msgid "The graphic can be exported only as SVG because its size is not defined."
 msgstr "Graafika saab eksportida ainult SVG-na, sest selle suurus pole defineeritud."
@@ -496,10 +492,6 @@ msgstr "Abi"
 msgid "Add preview"
 msgstr "Lisa uus eelvaade"
 
-#: src/ui_parts/previews.gd
-msgid "Add new preview"
-msgstr "Lisa uus eelvaade"
-
 #: src/ui_parts/previews.gd src/ui_widgets/palette_config.gd
 #: src/ui_widgets/setting_shortcut.gd src/ui_widgets/transform_popup.gd
 #: src/utils/TranslationUtils.gd
@@ -1701,6 +1693,12 @@ msgstr "Vektorkraafika rakendus SVG struktureeritud redigeerimiseks"
 msgid "svg;vector;graphics;draw;design;illustration;image;art;diagram;icon;logo;editor;path;shape;2D;code;blue;fox"
 msgstr "svg;vektor;graafika;joonista;disain;illustratsioon;pilt;kunst;skeem;diagramm;logo;ikoon;redigeerija;kuju;2D;kood;sinine;rebane"
 
+#~ msgid "The graphic can be exported only as SVG because its proportions are too extreme."
+#~ msgstr "Graafika saab eksportida ainult SVG-na, sest selle proportsioonid on liiga ekstreemsed."
+
+#~ msgid "Add new preview"
+#~ msgstr "Lisa uus eelvaade"
+
 #~ msgid "Add new color"
 #~ msgstr "Lisa värv"
 

translations/fr.po

@@ -41,10 +41,6 @@ msgstr "Une connexion à github.com sera effectuée pour comparer les numéros d
 msgid "OK"
 msgstr "OK"
 
-#: src/autoload/HandlerGUI.gd
-msgid "The graphic can be exported only as SVG because its proportions are too extreme."
-msgstr "Le graphique ne peut être exporté qu'en SVG car ses proportions sont trop extrêmes."
-
 #: src/autoload/HandlerGUI.gd
 msgid "The graphic can be exported only as SVG because its size is not defined."
 msgstr "Le graphique ne peut être exporté qu'en SVG car sa taille n'a pas été pas définie."
@@ -503,11 +499,6 @@ msgstr "Aide"
 msgid "Add preview"
 msgstr "Couleur de texte"
 
-#: src/ui_parts/previews.gd
-#, fuzzy
-msgid "Add new preview"
-msgstr "Couleur de texte"
-
 #: src/ui_parts/previews.gd src/ui_widgets/palette_config.gd
 #: src/ui_widgets/setting_shortcut.gd src/ui_widgets/transform_popup.gd
 #: src/utils/TranslationUtils.gd
@@ -1748,6 +1739,13 @@ msgstr ""
 msgid "svg;vector;graphics;draw;design;illustration;image;art;diagram;icon;logo;editor;path;shape;2D;code;blue;fox"
 msgstr ""
 
+#~ msgid "The graphic can be exported only as SVG because its proportions are too extreme."
+#~ msgstr "Le graphique ne peut être exporté qu'en SVG car ses proportions sont trop extrêmes."
+
+#, fuzzy
+#~ msgid "Add new preview"
+#~ msgstr "Couleur de texte"
+
 #, fuzzy
 #~ msgid "Add new color"
 #~ msgstr "Couleur de texte"

translations/nl.po

@@ -41,10 +41,6 @@ msgstr "Dit zal een verbinding maken naar github.com om de versienummers te verg
 msgid "OK"
 msgstr "OK"
 
-#: src/autoload/HandlerGUI.gd
-msgid "The graphic can be exported only as SVG because its proportions are too extreme."
-msgstr "De afbeelding kan alleen maar als SVG geëxporteerd worden door zijn extreme verhoudingen."
-
 #: src/autoload/HandlerGUI.gd
 msgid "The graphic can be exported only as SVG because its size is not defined."
 msgstr "De afbeelding kan alleen maar als SVG geëxporteerd worden want zijn maat is niet gedefiniëerd."
@@ -502,11 +498,6 @@ msgstr "Help"
 msgid "Add preview"
 msgstr "Voeg nieuwe kleur toe"
 
-#: src/ui_parts/previews.gd
-#, fuzzy
-msgid "Add new preview"
-msgstr "Voeg nieuwe kleur toe"
-
 #: src/ui_parts/previews.gd src/ui_widgets/palette_config.gd
 #: src/ui_widgets/setting_shortcut.gd src/ui_widgets/transform_popup.gd
 #: src/utils/TranslationUtils.gd
@@ -1733,6 +1724,13 @@ msgstr ""
 msgid "svg;vector;graphics;draw;design;illustration;image;art;diagram;icon;logo;editor;path;shape;2D;code;blue;fox"
 msgstr ""
 
+#~ msgid "The graphic can be exported only as SVG because its proportions are too extreme."
+#~ msgstr "De afbeelding kan alleen maar als SVG geëxporteerd worden door zijn extreme verhoudingen."
+
+#, fuzzy
+#~ msgid "Add new preview"
+#~ msgstr "Voeg nieuwe kleur toe"
+
 #~ msgid "Add new color"
 #~ msgstr "Voeg nieuwe kleur toe"