Skip to content

Commit a49f965

Browse files
fix: update test-release-binaries workflow for compatibility
- Use macos-latest instead of deprecated macos-13 - Fix ARM64 container test with proper platform flag and permissions - Standardize GH_TOKEN usage across all jobs
1 parent fa2aac7 commit a49f965

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

.github/workflows/test-release-binaries.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,11 @@ jobs:
1717
gh release download ${{ github.event.inputs.release_tag }} \
1818
--repo ${{ github.repository }} \
1919
--pattern 'shimmy-linux-x86_64' \
20-
--output shimmy
20+
--output shimmy \
21+
--skip-existing
2122
chmod +x shimmy
2223
env:
23-
GH_TOKEN: ${{ github.token }}
24+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2425

2526
- name: Test binary version
2627
run: |
@@ -51,11 +52,11 @@ jobs:
5152
--output shimmy
5253
chmod +x shimmy
5354
env:
54-
GH_TOKEN: ${{ github.token }}
55+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5556

5657
- name: Test binary in ARM64 container
5758
run: |
58-
docker run --rm -v $(pwd)/shimmy:/shimmy arm64v8/ubuntu:22.04 /shimmy --version
59+
docker run --rm --platform linux/arm64 -v $(pwd)/shimmy:/shimmy:ro arm64v8/ubuntu:22.04 /bin/bash -c "chmod +x /shimmy && /shimmy --version"
5960
echo "✅ ARM64 binary works"
6061
6162
test-windows-x86_64:
@@ -68,7 +69,7 @@ jobs:
6869
--repo ${{ github.repository }} \
6970
--pattern 'shimmy-windows-x86_64.exe'
7071
env:
71-
GH_TOKEN: ${{ github.token }}
72+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7273

7374
- name: Test binary version
7475
shell: cmd
@@ -83,7 +84,7 @@ jobs:
8384
echo ✅ Help command works
8485
8586
test-macos-intel:
86-
runs-on: macos-13
87+
runs-on: macos-latest
8788
steps:
8889
- name: Download binary from release
8990
run: |
@@ -93,7 +94,7 @@ jobs:
9394
--output shimmy
9495
chmod +x shimmy
9596
env:
96-
GH_TOKEN: ${{ github.token }}
97+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
9798

9899
- name: Test binary version
99100
run: |
@@ -116,7 +117,7 @@ jobs:
116117
--output shimmy
117118
chmod +x shimmy
118119
env:
119-
GH_TOKEN: ${{ github.token }}
120+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
120121

121122
- name: Test binary version
122123
run: |

0 commit comments

Comments
 (0)