fixup - bugfix and more margo resource release

Author: MichaelBrim

server/src/unifyfs_client_rpc.c

@@ -512,7 +512,6 @@ void process_client_fsync_rpc(client_rpc_req_t* creq)
 
         /* send rpc response and cleanup request state */
         sync_respond_client(creq, rpc_name);
-        
     }
     // else, some other thread will update the extent metadata
     //       and respond when the sync has completed
@@ -952,7 +951,7 @@ static void unifyfs_fsync_rpc(hg_handle_t handle)
                                   sizeof(unifyfs_fsync_in_t),
                                   sizeof(unifyfs_fsync_out_t));
     if (NULL == creq) {
-        unifyfs_filesize_out_t out;
+        unifyfs_fsync_out_t out;
         out.ret = (int32_t) ENOMEM;
         hg_return_t hret = margo_respond(handle, &out);
         if (hret != HG_SUCCESS) {

server/src/unifyfs_inode.c

@@ -401,7 +401,6 @@ int unifyfs_inode_add_pending_extents(int gfid,
     LOGINFO("added %d pending extents to inode (gfid=%d)",
             num_extents, gfid);
 
-
     return ret;
 }
 

server/src/unifyfs_service_manager.c

@@ -1315,17 +1315,12 @@ static int process_pending_sync(server_rpc_req_t* req)
                 pending_extents_item* pei = (pending_extents_item*) item;
                 client_rpc_req_t* creq = pei->client_req;
 
-                /* send rpc response to requesting client */
-                unifyfs_fsync_out_t out;
-                out.ret = (int32_t) ret;
-                hg_return_t hret = margo_respond(creq->req_state->handle, &out);
-                if (hret != HG_SUCCESS) {
-                    LOGERR("margo_respond() failed");
-                }
+                unifyfs_fsync_out_t* out = creq->req_state->outputs;
+                out->ret = (int32_t) ret;
 
-                /* cleanup req */
-                margo_destroy(creq->req_state->handle);
-                free(creq);
+                /* send rpc response to requesting client and cleanup */
+                const char* rpc_name = "unifyfs_fsync";
+                sync_respond_client(creq, rpc_name);
             }
         }