Merge pull request #14 from MichaelChirico/fix-sort-order

fix issue with getNamespaceExports tested order

Author: MichaelChirico

R/utils.R

@@ -147,6 +147,7 @@ stale_package_check = function(con) {
   code = tryCatch(parse(con), error = identity)
   if (inherits(code, 'error')) {
     cat('Failed to parse R script, please fix syntax errors first\n')
+    cat('  failed with: ', conditionMessage(code), '\n', sep = '')
     return(invisible())
   }
 
@@ -166,13 +167,13 @@ stale_package_check = function(con) {
   )
 
   for (pkg in all_packages) {
-    fns = getNamespaceExports(pkg)
+    fns = sort(getNamespaceExports(pkg)) # for #13
 
     used = fns %in% all_plain_calls
     if (any(used))
-      cat('Functions matched from package ', pkg, ':\n\t',
-          paste(fns[used], collapse = ', '), '\n', sep = '')
-    else cat('**No exported functions matched from ', pkg, '**\n', sep = '')
+      cat('Functions matched from package ', pkg, ':\n\t', toString(fns[used]), '\n', sep = '')
+    else
+      cat('**No exported functions matched from ', pkg, '**\n', sep = '')
   }
   return(invisible())
 }

tests/testthat/test-utils.R

@@ -1,32 +1,35 @@
 context('Utility functions')
 
 test_that('stale_package_check works', {
-  script_dir = 'stale_package_test_scripts'
+  stale_package_path <- function(path) test_path('stale_package_test_scripts', path)
+
   expect_output(
-    stale_package_check(file.path(script_dir, 'simple.R')),
+    stale_package_check(stale_package_path('simple.R')),
     paste(
-      c("Functions matched from package stats:", "\tdensity, rnorm",
-        "Functions matched from package tools:", "\tfile_ext",
+      c("Functions matched from package stats:",
+        paste0("\t", toString(sort(c("density", "rnorm")))),
+        "Functions matched from package tools:",
+        "\tfile_ext",
         "**No exported functions matched from tcltk**"),
       collapse = '\n'
     ),
     fixed = TRUE
   )
 
   expect_output(
-    stale_package_check(file.path(script_dir, 'use_namespace_call.R')),
+    stale_package_check(stale_package_path('use_namespace_call.R')),
     '**No exported functions matched from stats**',
     fixed = TRUE
   )
 
   expect_output(
-    stale_package_check(file.path(script_dir, 'wont-parse.R')),
+    stale_package_check(stale_package_path('wont_parse.R')),
     'Failed to parse R script, please fix syntax errors first',
     fixed = TRUE
   )
 
   expect_output(
-    stale_package_check(file.path(script_dir, 'no_library.R')),
+    stale_package_check(stale_package_path('no_library.R')),
     'No library() or require() calls found',
     fixed = TRUE
   )