R source locations can contain duplicates

[MichaelChirico]

Just observed in data.table Rdatatable/data.table@f9c2824

potools::po_extract(custom_translation_functions = list(R = c('catf:fmt|1', 'stopf:fmt|1', 'messagef:fmt|1', 'warningf:fmt|1')))

-#: AllS4.R:2
+#: AllS4.R:2 AllS4.R:2
 #, c-format
 msgid "data.table package loaded. When developing don't load package"
 msgstr ""
 
-#: IDateTime.R:107
+#: IDateTime.R:107 IDateTime.R:107
 #, c-format
 msgid "binary + is not defined for \"IDate\" objects"
 msgstr ""
 
-#: IDateTime.R:114
+#: IDateTime.R:114 IDateTime.R:114
 #, c-format
 msgid "can only subtract from \"IDate\" objects"
 msgstr ""
 
-#: IDateTime.R:119
+#: IDateTime.R:119 IDateTime.R:119

[MichaelChirico]

It looks like this is partially due to the duplicate inclusion of stopf:fmt|1 since stopf is already translated like that, but it implies the need for a fix at both ends:

stopf("a"); stopf("b")

Would also presumably generate duplicates.

So we should fix this by dropping duplicates from custom_translation_functions up front (with warning()? message()? just in verbose=TRUE?), while also dropping organic dupes.

[MichaelChirico]

Another thing to look out for: if custom_translation_functions lists the same function twice, instead of as intended with one entry & comma-separated arguments, we get a combinatorial explosion of entries, e.g.

c('ngettext_no_ordinal:msg1|2', 'ngettext_no_ordinal:msg2|3')
# vs what is the "canonical" format:
'ngettext_no_ordinal:msg1|2,msg2|3'

[MichaelChirico]

It also happens when the sources contain duplicates across singular+plural messages:

  ./po/R-data.table.pot:3334: duplicate message definition...
./po/R-data.table.pot:2434: ...this is the location of the first definition
./po/R-data.table.pot:3340: duplicate message definition...
./po/R-data.table.pot:2448: ...this is the location of the first definition
msgmerge: found 2 fatal errors

3334 is the plural, 2434 a singular version:

#: merge.R:131
#, c-format
msgid ""
"merge.data.table() received %d unnamed argument in '...' which will be "
"ignored."
msgstr ""

#: merge.R:131
msgid "merge.data.table() received %d unnamed argument in '...' which will be ignored."
msgid_plural "merge.data.table() received %d unnamed arguments in '...' which will be ignored."
msgstr[0] ""
msgstr[1] ""

This is picked up twice because an outer warningf() call lacked domain=NA to turn off translation:

    warningf(ngettext(n_dots, "merge.data.table() received %d unnamed argument in '...' which will be ignored.",
                              "merge.data.table() received %d unnamed arguments in '...' which will be ignored."),
              n_dots,
              domain = NA)