Skip to content

Commit 4da744d

Browse files
committed
New data collected at 2025-09-08_00-03-34
1 parent a3df34c commit 4da744d

18 files changed

Lines changed: 238 additions & 41 deletions
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
# Workflow derived from https://github.com/posit-dev/setup-air/tree/main/examples
2+
3+
on:
4+
# Using `pull_request_target` over `pull_request` for elevated `GITHUB_TOKEN`
5+
# privileges, otherwise we can't set `pull-requests: write` when the pull
6+
# request comes from a fork, which is our main use case (external contributors).
7+
#
8+
# `pull_request_target` runs in the context of the target branch (`main`, usually),
9+
# rather than in the context of the pull request like `pull_request` does. Due
10+
# to this, we must explicitly checkout `ref: ${{ github.event.pull_request.head.sha }}`.
11+
# This is typically frowned upon by GitHub, as it exposes you to potentially running
12+
# untrusted code in a context where you have elevated privileges, but they explicitly
13+
# call out the use case of reformatting and committing back / commenting on the PR
14+
# as a situation that should be safe (because we aren't actually running the untrusted
15+
# code, we are just treating it as passive data).
16+
# https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
17+
pull_request_target:
18+
19+
name: format-suggest.yaml
20+
21+
jobs:
22+
format-suggest:
23+
name: format-suggest
24+
runs-on: ubuntu-latest
25+
26+
permissions:
27+
# Required to push suggestion comments to the PR
28+
pull-requests: write
29+
30+
steps:
31+
- uses: actions/checkout@v4
32+
with:
33+
ref: ${{ github.event.pull_request.head.sha }}
34+
35+
- name: Install
36+
uses: posit-dev/setup-air@v1
37+
38+
- name: Format
39+
run: air format .
40+
41+
- name: Suggest
42+
uses: reviewdog/action-suggester@v1
43+
with:
44+
level: error
45+
fail_level: error
46+
tool_name: air

github-actions/greta/R-CMD-check.yaml

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -87,16 +87,21 @@ jobs:
8787
- name: Install package + deps
8888
run: remotes::install_local(dependencies = TRUE, force = TRUE)
8989

90-
- name: Install greta deps
91-
run: |
92-
library(greta)
93-
greta::install_greta_deps(timeout = 50)
90+
## greta deps are automatically resolved via py_require()
91+
# - name: Install greta deps
92+
# run: |
93+
# library(greta)
94+
# greta::install_greta_deps(timeout = 50)
95+
#
96+
# - name: Situation Report on greta install
97+
# run: greta::greta_sitrep()
9498

95-
- name: Situation Report on greta install
96-
run: greta::greta_sitrep()
99+
# - name: Install rcmdcheck
100+
# run: remotes::install_cran("rcmdcheck")
97101

98-
- name: Install rcmdcheck
99-
run: remotes::install_cran("rcmdcheck")
102+
# Some snapshot tests specifically check for miniconda
103+
- name: Install miniconda
104+
run: reticulate::install_miniconda()
100105

101106
- uses: r-lib/actions/check-r-package@v2
102107
with:

github-actions/leaflet/R-CMD-check.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ jobs:
2323
uses: rstudio/shiny-workflows/.github/workflows/R-CMD-check.yaml@v1
2424
with:
2525
minimum-r-version: "3.5.0"
26-
ubuntu: "ubuntu-20.04"
26+
ubuntu: "ubuntu-latest"

github-actions/magick/R-CMD-check.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ jobs:
1818
config:
1919
- {os: macOS-13, r: 'release'}
2020
- {os: macOS-14, r: 'release'}
21-
- {os: macOS-15, r: 'next'}
2221
- {os: windows-latest, r: '4.1'}
2322
- {os: windows-latest, r: '4.2'}
23+
- {os: windows-latest, r: '4.3'}
24+
- {os: windows-latest, r: '4.4'}
2425
- {os: windows-latest, r: 'release'}
2526
- {os: windows-latest, r: 'devel'}
2627
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
2728
- {os: ubuntu-latest, r: 'release'}
28-
- {os: ubuntu-latest, r: 'oldrel-1'}
29-
- {os: ubuntu-22.04, r: '4.1'}
29+
- {os: ubuntu-latest, r: 'oldrel-3'}
3030

3131
env:
3232
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

github-actions/mlflow/autoformat.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,10 @@ jobs:
9999
# ************************************************************************
100100
# pre-commit
101101
# ************************************************************************
102-
- run: |
103-
dev/install-taplo.sh
104-
dev/install-typos.sh
105-
dev/install-conftest.sh
106102
- run: |
107103
pip install -r requirements/lint-requirements.txt
108104
pre-commit install --install-hooks
105+
pre-commit run install-bin -a -v
109106
pre-commit run --all-files --color=always || true
110107
# ************************************************************************
111108
# protos

github-actions/mlflow/copilot-setup-steps.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,5 @@ jobs:
1818
- name: pre-commit setup
1919
run: |
2020
uv pip install --system . -r requirements/lint-requirements.txt
21-
dev/install-taplo.sh
22-
dev/install-typos.sh
23-
dev/install-conftest.sh
2421
pre-commit install --install-hooks
22+
pre-commit run install-bin -a -v

github-actions/mlflow/lint.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,16 @@ env:
2929

3030
jobs:
3131
lint:
32-
runs-on: ubuntu-latest
32+
strategy:
33+
fail-fast: false
34+
matrix:
35+
os: [ubuntu-latest, macos-latest]
36+
runs-on: ${{ matrix.os }}
3337
timeout-minutes: 30
3438
permissions:
3539
contents: read
3640
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
41+
name: ${{ matrix.os == 'ubuntu-latest' && 'lint' || 'lint-macos' }}
3742
steps:
3843
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
3944
with:
@@ -44,6 +49,7 @@ jobs:
4449
- uses: ./.github/actions/setup-python
4550
id: setup-python
4651
- name: Add problem matchers
52+
if: matrix.os == 'ubuntu-latest'
4753
run: |
4854
echo "::add-matcher::.github/workflows/matchers/clint.json"
4955
echo "::add-matcher::.github/workflows/matchers/format.json"
@@ -52,14 +58,12 @@ jobs:
5258
- name: Install dependencies
5359
run: |
5460
uv pip install --system -r requirements/lint-requirements.txt
55-
dev/install-taplo.sh
56-
dev/install-typos.sh
57-
dev/install-conftest.sh
5861
- uses: ./.github/actions/show-versions
5962
- uses: ./.github/actions/pipdeptree
6063
- name: Install pre-commit hooks
6164
run: |
6265
pre-commit install --install-hooks
66+
pre-commit run install-bin -a -v
6367
- name: Run pre-commit
6468
id: pre-commit
6569
env:

github-actions/mlflow/push-images.yml

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,35 @@ jobs:
3030
username: ${{ github.actor }}
3131
password: ${{ secrets.GITHUB_TOKEN }}
3232

33+
- name: Check if should update latest tag
34+
id: check_latest
35+
run: |
36+
CURRENT_VERSION=${GITHUB_REF_NAME#v}
37+
38+
HIGHEST_VERSION=$(gh release list --exclude-pre-releases --exclude-drafts --limit 100 | \
39+
grep -E '^v[0-9]+\.[0-9]+\.[0-9]+\s' | \
40+
awk '{print $1}' | \
41+
sed 's/^v//' | \
42+
sort -V | \
43+
tail -n1)
44+
45+
if [ -z "$HIGHEST_VERSION" ] || [ "$(echo -e "$CURRENT_VERSION\n$HIGHEST_VERSION" | sort -V | tail -n1)" = "$CURRENT_VERSION" ]; then
46+
echo "should_update_latest=true" >> $GITHUB_OUTPUT
47+
else
48+
echo "should_update_latest=false" >> $GITHUB_OUTPUT
49+
fi
50+
env:
51+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
52+
3353
- name: Gather Docker Metadata for Tracking
3454
id: meta
3555
uses: docker/metadata-action@818d4b7b91585d195f67373fd9cb0332e31a7175 # v4.6.0
3656
with:
37-
# list of Docker images to use as base name for tags
3857
images: |
3958
ghcr.io/mlflow/mlflow
40-
# generate Docker tags based on the following events/attributes
4159
tags: |
4260
type=ref,event=tag
61+
type=raw,value=latest,enable=${{ steps.check_latest.outputs.should_update_latest == 'true' }}
4362
4463
- name: Build and Push Base Image
4564
uses: docker/build-push-action@1104d471370f9806843c095c1db02b5a90c5f8b6 # v3.3.1
@@ -55,12 +74,11 @@ jobs:
5574
id: modelmeta
5675
uses: docker/metadata-action@818d4b7b91585d195f67373fd9cb0332e31a7175 # v4.6.0
5776
with:
58-
# list of Docker images to use as base name for tags
5977
images: |
6078
ghcr.io/mlflow/model-server
61-
# generate Docker tags based on the following events/attributes
6279
tags: |
6380
type=ref,event=tag
81+
type=raw,value=latest,enable=${{ steps.check_latest.outputs.should_update_latest == 'true' }}
6482
6583
- name: Build Model Server Image
6684
run: |

github-actions/mlflow/review.yml

Lines changed: 28 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010

1111
concurrency:
1212
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.ref }}
13-
cancel-in-progress: true
13+
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
1414

1515
jobs:
1616
review:
@@ -20,15 +20,14 @@ jobs:
2020
models: read
2121
pull-requests: write
2222
timeout-minutes: 10
23-
# Run on pull_request events from mlflow/mlflow (not forks) or when harupy comments '/review' on a pull request
23+
# Run on pull_request events from mlflow/mlflow (not forks) or when anyone comments '/review' on a pull request
2424
if: >
2525
(github.event_name == 'pull_request' &&
2626
github.event.pull_request.head.repo.full_name == 'mlflow/mlflow')
2727
||
2828
(github.event_name == 'issue_comment' &&
2929
github.event.issue.pull_request &&
30-
startsWith(github.event.comment.body, '/review') &&
31-
github.event.comment.user.login == 'harupy')
30+
startsWith(github.event.comment.body, '/review'))
3231
steps:
3332
- name: React to comment
3433
if: ${{ github.event_name == 'issue_comment' }}
@@ -42,6 +41,21 @@ jobs:
4241
comment_id: comment.id,
4342
content: 'rocket'
4443
});
44+
- name: Check authorization for issue comment
45+
if: ${{ github.event_name == 'issue_comment' && github.event.comment.user.login != 'harupy' }}
46+
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
47+
with:
48+
script: |
49+
// Leave a comment indicating only 'harupy' is allowed to trigger the workflow
50+
await github.rest.issues.createComment({
51+
owner: context.repo.owner,
52+
repo: context.repo.repo,
53+
issue_number: context.issue.number,
54+
body: "⚠️ Only **harupy** is authorized to trigger this workflow via comments. Your request has been ignored."
55+
});
56+
57+
// Fail the workflow to abort further execution
58+
throw new Error("Unauthorized user attempted to trigger workflow: " + context.payload.comment.user.login);
4559
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
4660
with:
4761
sparse-checkout: |
@@ -98,20 +112,21 @@ jobs:
98112
99113
# Instructions
100114
101-
## 1. Fetch and Analyze PR
115+
## 1. Fetch PR and Review Against Style Guide
102116
- Use `fetch_diff` tool to fetch the PR diff
103-
- Carefully examine all changes in the diff
104-
105-
## 2. Review Against Style Guide
106117
- Read `dev/guides/python.md` thoroughly
107-
- Check for violations of the style guide
118+
- Carefully examine ONLY the changed lines (added or modified) in the diff
119+
- Check for style guide violations ONLY in these changed lines
120+
- Ignore unchanged/context lines and pre-existing code
108121
109-
## 3. Decision Point
122+
## 2. Decision Point
110123
- If NO issues found -> Skip remaining steps
111-
- If issues found -> Continue to step 4
124+
- If issues found -> Continue to step 3
112125
113-
## 4. Add Review Comments
126+
## 3. Add Review Comments
114127
- Use `add_pr_review_comment` tool for each issue found
128+
- ONLY comment on lines that are marked as added (+) or modified in the diff
129+
- Never comment on unchanged context lines or pre-existing code
115130
- Comment parameters:
116131
- Single-line: Set `subject_type` to `LINE`, specify `line`
117132
- Multi-line: Set `subject_type` to `LINE`, specify both `start_line` and `line`
@@ -128,4 +143,4 @@ jobs:
128143
PR_URL: ${{ github.event.issue.pull_request.html_url || github.event.pull_request.html_url}}
129144
run: |
130145
# Use timeout in case codex hangs
131-
timeout 3m ./codex exec --skip-git-repo-check "Can you review $PR_URL?" || true
146+
timeout 5m ./codex exec --skip-git-repo-check "Can you review $PR_URL?" || true

github-actions/mlflow/tracing.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ jobs:
5656
--ignore tests/tracing/utils/test_otlp.py \
5757
--ignore tests/tracing/test_assessment.py \
5858
--ignore tests/tracing/test_otel_logging.py \
59+
--ignore tests/tracing/processor/test_otel_metrics.py \
5960
--import-mode=importlib
6061
6162
# TODO: Add a job to run autologging tests against integrated libraries (latest versions)

0 commit comments

Comments
 (0)