You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: github-actions/mlflow/review.yml
+7-10Lines changed: 7 additions & 10 deletions
Original file line number
Diff line number
Diff line change
@@ -19,7 +19,7 @@ jobs:
19
19
contents: read
20
20
models: read
21
21
pull-requests: write
22
-
timeout-minutes: 20
22
+
timeout-minutes: 30
23
23
# Run on pull_request events from mlflow/mlflow (not forks) or when anyone comments '/review' on a pull request
24
24
if: >
25
25
(github.event_name == 'pull_request' &&
@@ -137,15 +137,12 @@ jobs:
137
137
138
138
## 1. Prepare for Review
139
139
- Use `fetch_diff` tool to fetch the PR diff
140
-
- Read `dev/guides/python.md` thoroughly
140
+
- If the diff includes changes to .py files, read `dev/guides/python.md` thoroughly
141
141
142
142
## 2. Review Changed Lines Only
143
143
- Carefully examine ONLY the changed lines (added or modified) in the diff
144
-
- Check for style guide violations ONLY in these changed lines
145
-
- Check for obvious mistakes including:
146
-
- Typos in variable names, function names, class names, comments, and docstrings
147
-
- Grammatical errors in comments and documentation
148
-
- Common coding mistakes (e.g., wrong variable references, logic errors)
144
+
- Check ONLY for style guide violations in these changed lines
145
+
- Do NOT check for other issues like bugs, logic errors, or functionality problems
149
146
- Ignore unchanged/context lines and pre-existing code
150
147
151
148
## 3. Decision Point
@@ -160,8 +157,8 @@ jobs:
160
157
- Prefer GitHub suggestion code blocks for simple fixes (typos, imports, formatting) using ```suggestion format so maintainers can apply with one click.
161
158
- Keep indentation: In ```suggestion blocks, copy the original leading spaces/tabs exactly (only change them if that's the actual fix). Avoid extra blank lines and include only the lines you intend to modify.
162
159
- Comment parameters:
163
-
- Single-line: Set `subject_type` to `LINE`, specify `line`
164
-
- Multi-line: Set `subject_type` to `LINE`, specify both `start_line` and `line`
160
+
- Single-line: Set `subject_type` to `line`, specify `line`
161
+
- Multi-line: Set `subject_type` to `line`, specify both `start_line` and `line`
165
162
- Comment format:
166
163
- Use ```suggestion blocks for direct fixes (preferred when possible) or triple backticks (```) for code examples
167
164
- Be specific about the violation and why the change is needed
0 commit comments