Skip to content

Commit 8aeef26

Browse files
committed
New data collected at 2025-10-06_00-05-16
1 parent eaf1fd0 commit 8aeef26

21 files changed

Lines changed: 99 additions & 65 deletions

github-actions/devtools/R-CMD-check.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ on:
88
push:
99
branches: [main, master]
1010
pull_request:
11-
branches: [main, master]
1211

13-
name: R-CMD-check
12+
name: R-CMD-check.yaml
1413

1514
permissions: read-all
1615

@@ -27,8 +26,14 @@ jobs:
2726
- {os: macos-latest, r: 'release'}
2827

2928
- {os: windows-latest, r: 'release'}
30-
# use 4.1 to check with rtools40's older compiler
31-
- {os: windows-latest, r: '4.1'}
29+
# specifying oldrel-3 instead of oldrel-4, because ragg is a problem
30+
# and that's what ragg itself is doing (???)
31+
# seems like we lose coverage of rtools40's compiler, but that also
32+
# doesn't seem like a devtools problem
33+
# https://github.com/r-lib/ragg/pull/195/commits/0ce19424eab2dad15b38b41992804e3226d86e22
34+
- {os: windows-latest, r: 'oldrel-3'}
35+
# use 4.0 or 4.1 to check with rtools40's older compiler
36+
#- {os: windows-latest, r: 'oldrel-4'}
3237

3338
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
3439
- {os: ubuntu-latest, r: 'release'}

github-actions/devtools/pkgdown.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,11 @@ on:
44
push:
55
branches: [main, master]
66
pull_request:
7-
branches: [main, master]
87
release:
98
types: [published]
109
workflow_dispatch:
1110

12-
name: pkgdown
11+
name: pkgdown.yaml
1312

1413
permissions: read-all
1514

github-actions/devtools/test-coverage.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@ on:
44
push:
55
branches: [main, master]
66
pull_request:
7-
branches: [main, master]
87

9-
name: test-coverage
8+
name: test-coverage.yaml
109

1110
permissions: read-all
1211

@@ -35,14 +34,16 @@ jobs:
3534
clean = FALSE,
3635
install_path = file.path(normalizePath(Sys.getenv("RUNNER_TEMP"), winslash = "/"), "package")
3736
)
37+
print(cov)
3838
covr::to_cobertura(cov)
3939
shell: Rscript {0}
4040

41-
- uses: codecov/codecov-action@v4
41+
- uses: codecov/codecov-action@v5
4242
with:
43-
fail_ci_if_error: ${{ github.event_name != 'pull_request' && true || false }}
44-
file: ./cobertura.xml
45-
plugin: noop
43+
# Fail if error if not on PR, or if on PR and token is given
44+
fail_ci_if_error: ${{ github.event_name != 'pull_request' || secrets.CODECOV_TOKEN }}
45+
files: ./cobertura.xml
46+
plugins: noop
4647
disable_search: true
4748
token: ${{ secrets.CODECOV_TOKEN }}
4849

github-actions/dplyr/R-CMD-check.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ on:
88
push:
99
branches: [main, master]
1010
pull_request:
11-
branches: [main, master]
1211

1312
name: R-CMD-check.yaml
1413

github-actions/dplyr/pkgdown.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
push:
55
branches: [main, master]
66
pull_request:
7-
branches: [main, master]
87
release:
98
types: [published]
109
workflow_dispatch:

github-actions/dplyr/test-coverage.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
push:
55
branches: [main, master]
66
pull_request:
7-
branches: [main, master]
87

98
name: test-coverage.yaml
109

@@ -35,14 +34,16 @@ jobs:
3534
clean = FALSE,
3635
install_path = file.path(normalizePath(Sys.getenv("RUNNER_TEMP"), winslash = "/"), "package")
3736
)
37+
print(cov)
3838
covr::to_cobertura(cov)
3939
shell: Rscript {0}
4040

41-
- uses: codecov/codecov-action@v4
41+
- uses: codecov/codecov-action@v5
4242
with:
43-
fail_ci_if_error: ${{ github.event_name != 'pull_request' && true || false }}
44-
file: ./cobertura.xml
45-
plugin: noop
43+
# Fail if error if not on PR, or if on PR and token is given
44+
fail_ci_if_error: ${{ github.event_name != 'pull_request' || secrets.CODECOV_TOKEN }}
45+
files: ./cobertura.xml
46+
plugins: noop
4647
disable_search: true
4748
token: ${{ secrets.CODECOV_TOKEN }}
4849

github-actions/mlflow/master.yml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ env:
3232
PIP_CONSTRAINT: ${{ github.workspace }}/requirements/constraints.txt
3333
PYTHONUTF8: "1"
3434
_MLFLOW_TESTING_TELEMETRY: "true"
35+
MLFLOW_SERVER_ENABLE_JOB_EXECUTION: "false"
3536

3637
jobs:
3738
# python-skinny tests cover a subset of mlflow functionality
@@ -101,11 +102,12 @@ jobs:
101102
--ignore-flavors --ignore=tests/examples --ignore=tests/evaluate \
102103
--ignore tests/genai tests
103104
104-
- name: Run gateway tests with pydantic v1
105-
run: |
106-
source .venv/bin/activate
107-
pip install 'pydantic<2.0'
108-
pytest --splits=${{ matrix.splits }} --group=${{ matrix.group }} tests/gateway
105+
# TODO: Remove this step once support for pydantic v1 is dropped
106+
# - name: Run gateway tests with pydantic v1
107+
# run: |
108+
# source .venv/bin/activate
109+
# pip install 'pydantic<2.0'
110+
# pytest --splits=${{ matrix.splits }} --group=${{ matrix.group }} tests/gateway
109111

110112
- name: Run databricks-connect related tests
111113
run: |
@@ -351,11 +353,12 @@ jobs:
351353
352354
# test_spark_connect.py fails if it's run with other tests, so run it separately.
353355
pytest tests/pyfunc/test_spark_connect.py
354-
- name: Run tests on pydantic v1
355-
run: |
356-
pip install 'pydantic<2'
357-
pytest --splits=${{ matrix.splits }} --group=${{ matrix.group }} --durations=30 \
358-
tests/types tests/pyfunc/test_pyfunc_model_with_type_hints.py tests/utils/test_pydantic_utils.py
356+
# TODO: Remove this step once support for pydantic v1 is dropped
357+
# - name: Run tests on pydantic v1
358+
# run: |
359+
# pip install 'pydantic<2'
360+
# pytest --splits=${{ matrix.splits }} --group=${{ matrix.group }} --durations=30 \
361+
# tests/types tests/pyfunc/test_pyfunc_model_with_type_hints.py tests/utils/test_pydantic_utils.py
359362

360363
windows:
361364
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false

github-actions/mlflow/protect.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ jobs:
2626
timeout-minutes: 120
2727
permissions:
2828
checks: read # to read check statuses
29+
actions: read # to read workflow runs and jobs
2930
steps:
3031
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
3132
with:

github-actions/mlflow/review.yml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
contents: read
2020
models: read
2121
pull-requests: write
22-
timeout-minutes: 20
22+
timeout-minutes: 30
2323
# Run on pull_request events from mlflow/mlflow (not forks) or when anyone comments '/review' on a pull request
2424
if: >
2525
(github.event_name == 'pull_request' &&
@@ -137,15 +137,12 @@ jobs:
137137
138138
## 1. Prepare for Review
139139
- Use `fetch_diff` tool to fetch the PR diff
140-
- Read `dev/guides/python.md` thoroughly
140+
- If the diff includes changes to .py files, read `dev/guides/python.md` thoroughly
141141
142142
## 2. Review Changed Lines Only
143143
- Carefully examine ONLY the changed lines (added or modified) in the diff
144-
- Check for style guide violations ONLY in these changed lines
145-
- Check for obvious mistakes including:
146-
- Typos in variable names, function names, class names, comments, and docstrings
147-
- Grammatical errors in comments and documentation
148-
- Common coding mistakes (e.g., wrong variable references, logic errors)
144+
- Check ONLY for style guide violations in these changed lines
145+
- Do NOT check for other issues like bugs, logic errors, or functionality problems
149146
- Ignore unchanged/context lines and pre-existing code
150147
151148
## 3. Decision Point
@@ -160,8 +157,8 @@ jobs:
160157
- Prefer GitHub suggestion code blocks for simple fixes (typos, imports, formatting) using ```suggestion format so maintainers can apply with one click.
161158
- Keep indentation: In ```suggestion blocks, copy the original leading spaces/tabs exactly (only change them if that's the actual fix). Avoid extra blank lines and include only the lines you intend to modify.
162159
- Comment parameters:
163-
- Single-line: Set `subject_type` to `LINE`, specify `line`
164-
- Multi-line: Set `subject_type` to `LINE`, specify both `start_line` and `line`
160+
- Single-line: Set `subject_type` to `line`, specify `line`
161+
- Multi-line: Set `subject_type` to `line`, specify both `start_line` and `line`
165162
- Comment format:
166163
- Use ```suggestion blocks for direct fixes (preferred when possible) or triple backticks (```) for code examples
167164
- Be specific about the violation and why the change is needed
@@ -177,4 +174,4 @@ jobs:
177174
run: |
178175
./codex login --api-key "${{ secrets.OPENAI_API_KEY }}"
179176
# Use timeout in case codex hangs
180-
timeout 10m ./codex exec --skip-git-repo-check "Can you review $PR_URL?" || true
177+
timeout 20m ./codex exec --skip-git-repo-check "Can you review $PR_URL?" || true

github-actions/mlflow/tracing.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ env:
2626
MLFLOW_HOME: /home/runner/work/mlflow/mlflow
2727
MLFLOW_CONDA_HOME: /usr/share/miniconda
2828
PYTHONUTF8: "1"
29+
MLFLOW_SERVER_ENABLE_JOB_EXECUTION: "false"
2930

3031
jobs:
3132
core:

0 commit comments

Comments
 (0)