Fix SAMR authentication

MichaelGrafnetter · web-flow · commit e6045f197f93 · 2026-03-27T06:10:53.000+01:00
diff --git a/Src/DSInternals.SAM/Wrappers/SamServer.cs b/Src/DSInternals.SAM/Wrappers/SamServer.cs
@@ -52,13 +52,13 @@ public SamServer(string serverName, SamServerAccessMask accessMask = SamServerAc
 
         this.Name = serverName;
 
-        if (useNamedPipes && credential != null)
+        if (useNamedPipes && credential is not null)
         {
             // Establish an authenticated SMB session to force RPC over named pipes
             _namedPipeConnection = new NamedPipeConnection(serverName, credential);
         }
 
-        NtStatus result = (credential != null) ?
+        NtStatus result = (!useNamedPipes && credential is not null) ?
             NativeMethods.SamConnectWithCreds(serverName, out SafeSamHandle serverHandle, accessMask, credential) :
             NativeMethods.SamConnect(serverName, out serverHandle, accessMask);
 

Original file line number	Diff line number	Diff line change
`@@ -52,13 +52,13 @@ public SamServer(string serverName, SamServerAccessMask accessMask = SamServerAc`
`52`	`52`
`53`	`53`	`this.Name = serverName;`
`54`	`54`
`55`		`- if (useNamedPipes && credential != null)`
	`55`	`+ if (useNamedPipes && credential is not null)`
`56`	`56`	`{`
`57`	`57`	`// Establish an authenticated SMB session to force RPC over named pipes`
`58`	`58`	`_namedPipeConnection = new NamedPipeConnection(serverName, credential);`
`59`	`59`	`}`
`60`	`60`
`61`		`- NtStatus result = (credential != null) ?`
	`61`	`+ NtStatus result = (!useNamedPipes && credential is not null) ?`
`62`	`62`	`NativeMethods.SamConnectWithCreds(serverName, out SafeSamHandle serverHandle, accessMask, credential) :`
`63`	`63`	`NativeMethods.SamConnect(serverName, out serverHandle, accessMask);`
`64`	`64`