fix: NotifierRefs are no longer NamespacedNames

Author: Michaelpalacce

api/v1alpha1/general_types.go

@@ -4,7 +4,4 @@ package v1alpha1
 type ResourceRef struct {
 	// +kubebuilder:validation:Required
 	Name string `json:"name"`
-
-	// +kubebuilder:validation:Required
-	Namespace string `json:"namespace"`
 }

config/crd/bases/ddns.stefangenov.site_providers.yaml

@@ -56,11 +56,8 @@ spec:
                   properties:
                     name:
                       type: string
-                    namespace:
-                      type: string
                   required:
                   - name
-                  - namespace
                   type: object
                 type: array
               secretName:

config/samples/ddns_v1alpha1_provider.yaml

@@ -11,4 +11,3 @@ spec:
   configMap: cloudflare-config
   notifierRefs:
     - name: webhook-notifier
-      namespace: go-ddns-controller-system

dist/install.yaml

@@ -224,11 +224,8 @@ spec:
                   properties:
                     name:
                       type: string
-                    namespace:
-                      type: string
                   required:
                   - name
-                  - namespace
                   type: object
                 type: array
               secretName:

internal/controller/notifier_controller.go

@@ -85,7 +85,7 @@ func (r *NotifierReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
 	filteredProviders := []ddnsv1alpha1.Provider{}
 	for _, provider := range providers.Items {
 		for _, ref := range provider.Spec.NotifierRefs {
-			if ref.Name == req.Name && ref.Namespace == req.Namespace {
+			if ref.Name == req.Name {
 				filteredProviders = append(filteredProviders, provider)
 				break
 			}
@@ -384,7 +384,7 @@ func (r *NotifierReconciler) findObjectsForProvider(ctx context.Context, provide
 		requests[i] = reconcile.Request{
 			NamespacedName: types.NamespacedName{
 				Name:      notifierRef.Name,
-				Namespace: notifierRef.Namespace,
+				Namespace: provider.GetNamespace(),
 			},
 		}
 	}