Skip to content

Commit 00d0b22

Browse files
committed
chore: change name of some methods
1 parent aeee006 commit 00d0b22

File tree

18 files changed

+103
-196
lines changed

18 files changed

+103
-196
lines changed

.eslintrc.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,4 @@ module.exports = {
44
browser: true,
55
node: true
66
},
7-
extends: [
8-
"eslint-config-2o3t"
9-
],
107
}

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ npx micro-app show methods
8484
```js
8585
╰─➤ npx micro-app show methods
8686
Plugin Methods:
87-
* modifyChainWebpackConfig ( 合并之后提供 webpack-chain 进行再次修改事件 )
88-
* onChainWebpcakConfig ( 修改之后提供 webpack-chain 进行查看事件 )
87+
* modifyWebpackChain ( 合并之后提供 webpack-chain 进行再次修改事件 )
88+
* onWebpcakChain ( 修改之后提供 webpack-chain 进行查看事件 )
8989
* modifyWebpackConfig ( 合并之后提供 webpack config 进行再次修改事件 )
9090
* onBuildSuccess ( 构建成功时事件 )
9191
* onBuildFail ( 构建失败时事件 )

TODO.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,5 @@
1111
- [ ] 梳理各个模块逻辑,输出文档等。
1212

1313
*暂时放弃 plugin 打包。*
14+
15+
- [ ] 增加一个虚拟文件,利用 alias 提供给 webpack 打包时前端引用。例如 import {} from '@microapp'

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@
4848
}
4949
},
5050
"peerDependencies": {
51-
"@micro-app/core": "^0.3.27",
51+
"@micro-app/core": "^0.3.30",
5252
"@micro-app/cli": "^0.3.16"
5353
},
5454
"devDependencies": {
55-
"@micro-app/cli": "^0.3.15",
56-
"@micro-app/plugin-compatible": "0.0.4",
55+
"@micro-app/cli": "^0.3.16",
56+
"@micro-app/plugin-compatible": "0.0.6",
5757
"@micro-app/plugin-deploy": "^0.0.7",
5858
"@types/jest": "^24.9.1",
5959
"eslint-config-2o3t": "^2.0.1",
@@ -68,7 +68,7 @@
6868
"@babel/preset-env": "^7.9.5",
6969
"@intervolga/optimize-cssnano-plugin": "^1.0.6",
7070
"@marshallofsound/webpack-asset-relocator-loader": "^0.5.0",
71-
"@micro-app/shared-utils": "^0.1.18",
71+
"@micro-app/shared-utils": "^0.1.19",
7272
"@soda/friendly-errors-webpack-plugin": "^1.7.1",
7373
"address": "^1.1.2",
7474
"autoprefixer": "^9.7.6",

src/commands/serve/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ module.exports = function serveCommand(api, opts) {
7272
};
7373

7474
// configs that only matters for dev server
75-
api.modifyChainWebpackConfig(webpackChain => {
75+
api.modifyWebpackChain(webpackChain => {
7676

7777
// webpack 4
7878
const isWebpack4 = semver.satisfies(webpackVersion, '>=4');

src/extends/enhance/index.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@
22

33
module.exports = function WebpackAdapter(api, opts) {
44

5-
api.assertVersion('>=0.3.0');
6-
7-
const registerMethods = require('./methods');
8-
registerMethods(api);
5+
api.assertVersion('>=0.3.29');
96

107
const { _ } = require('@micro-app/shared-utils');
118
const Config = require('webpack-chain');
@@ -14,15 +11,15 @@ module.exports = function WebpackAdapter(api, opts) {
1411

1512
const logger = api.logger;
1613

17-
api.extendMethod('resolveChainableWebpackConfig', {
14+
api.extendMethod('resolveWebpackChain', {
1815
description: 'resolve webpack-chain config.',
1916
}, (webpackChainConfig = new Config()) => {
2017
if (!initialized) {
2118
logger.throw('please call after "onInitWillDone" !');
2219
}
2320

2421
// 可通过外部初始化一个已存在的 webpackChain 实例
25-
webpackChainConfig = api.applyPluginHooks('createChainWebpackConfigInstance', webpackChainConfig);
22+
webpackChainConfig = api.applyPluginHooks('createWebpackChainInstance', webpackChainConfig);
2623

2724
const selfConfig = api.selfConfig || {};
2825
const originalConfig = selfConfig.originalConfig || {};
@@ -36,8 +33,8 @@ module.exports = function WebpackAdapter(api, opts) {
3633
webpackChainConfig.target('web');
3734
}
3835

39-
const finalWebpackChainConfig = api.applyPluginHooks('modifyChainWebpackConfig', webpackChainConfig);
40-
api.applyPluginHooks('onChainWebpcakConfig', finalWebpackChainConfig);
36+
const finalWebpackChainConfig = api.applyPluginHooks('modifyWebpackChain', webpackChainConfig);
37+
api.applyPluginHooks('onWebpcakChain', finalWebpackChainConfig);
4138

4239
api.setState('webpackChainConfig', finalWebpackChainConfig);
4340
return finalWebpackChainConfig;
@@ -46,9 +43,10 @@ module.exports = function WebpackAdapter(api, opts) {
4643
api.extendMethod('resolveWebpackConfig', {
4744
description: 'resolve webpack config.',
4845
}, webpackChainConfig => {
49-
const finalWebpackChainConfig = api.resolveChainableWebpackConfig(webpackChainConfig);
46+
const finalWebpackChainConfig = api.resolveWebpackChain(webpackChainConfig);
5047
const webpackConfig = finalWebpackChainConfig.toConfig();
5148
const finalWebpackConfig = api.applyPluginHooks('modifyWebpackConfig', webpackConfig);
49+
api.applyPluginHooks('onWebpcakConfig', finalWebpackConfig);
5250

5351
api.setState('webpackConfig', finalWebpackConfig);
5452
return finalWebpackConfig;
@@ -59,6 +57,8 @@ module.exports = function WebpackAdapter(api, opts) {
5957
});
6058
};
6159

60+
module.exports.registerMethod = require('./methods');
61+
6262
module.exports.configuration = {
6363
description: 'webpack 适配器, 对外提供多个触发事件',
6464
};

src/extends/enhance/methods.js

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,28 @@
11
'use strict';
22

3-
module.exports = (api, opts) => {
4-
5-
api.registerMethod('createChainWebpackConfigInstance', {
6-
type: api.API_TYPE.MODIFY,
3+
module.exports = {
4+
createWebpackChainInstance: {
5+
type: 'MODIFY',
76
description: '在 webpack 配置开始前提供一个 webpack-chain 实例.(用于内部特殊场景)',
8-
});
7+
},
98

10-
api.registerMethod('modifyChainWebpackConfig', {
11-
type: api.API_TYPE.MODIFY,
9+
modifyWebpackChain: {
10+
type: 'MODIFY',
1211
description: '合并之后提供 webpack-chain 进行再次修改事件',
13-
});
12+
},
1413

15-
api.registerMethod('onChainWebpcakConfig', {
16-
type: api.API_TYPE.EVENT,
14+
onWebpcakChain: {
15+
type: 'EVENT',
1716
description: '修改之后提供 webpack-chain 进行查看事件',
18-
});
17+
},
1918

20-
api.registerMethod('modifyWebpackConfig', {
21-
type: api.API_TYPE.MODIFY,
19+
modifyWebpackConfig: {
20+
type: 'MODIFY',
2221
description: '合并之后提供 webpack config 进行再次修改事件',
23-
});
22+
},
23+
24+
onWebpcakConfig: {
25+
type: 'EVENT',
26+
description: '修改之后提供 webpack config 进行查看事件',
27+
},
2428
};

src/extends/submodule/index.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ module.exports = function subModuleWebpack(api, opts) {
44

55
api.assertVersion('>=0.3.26');
66

7-
const registerMethods = require('./methods');
8-
registerMethods(api);
9-
107
// TODO 只有开启 --sub-module 时才处理
118
if (!api.context.subModule) {
129
return;
@@ -53,7 +50,7 @@ module.exports = function subModuleWebpack(api, opts) {
5350

5451

5552
// 生成 manifest
56-
api.modifyChainWebpackConfig(webpackChain => {
53+
api.modifyWebpackChain(webpackChain => {
5754
const otherOptions = Object.keys(config.subModule).reduce((obj, key) => {
5855
if (![ 'prefix', 'namespace', 'entry' ].includes(key)) {
5956
obj[key] = config.subModule[key];
@@ -83,7 +80,7 @@ module.exports = function subModuleWebpack(api, opts) {
8380
}])
8481
.end();
8582

86-
return webpackChain;
83+
return api.applyPluginHooks('modifySubModuleWebpackChain', webpackChain);
8784
});
8885

8986
api.modifyWebpackConfig(webpackConfig => {
@@ -98,11 +95,12 @@ module.exports = function subModuleWebpack(api, opts) {
9895
webpackConfig.output.chunkFilename = `js/${prefix}_${namespace}-[name].[contenthash:8].js`;
9996
}
10097

101-
// TODO 提供方法对外补充一些修改
102-
return webpackConfig;
98+
return api.applyPluginHooks('modifySubModuleWebpackConfig', webpackConfig);
10399
});
104100
};
105101

102+
module.exports.registerMethod = require('./methods');
103+
106104
module.exports.configuration = {
107105
description: 'webpack 适配增强 config 配置信息',
108106
};

src/extends/submodule/methods.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
'use strict';
22

3-
module.exports = api => {
3+
module.exports = {
44

5-
// api.registerMethod('modifyDefaultServerConfig', {
6-
// type: api.API_TYPE.MODIFY,
7-
// description: '修改服务端配置合并事件',
8-
// });
5+
modifySubModuleWebpackChain: {
6+
type: 'MODIFY',
7+
description: '修改 SubModule webpack-chain 配置事件',
8+
},
9+
10+
modifySubModuleWebpackConfig: {
11+
type: 'MODIFY',
12+
description: '修改 SubModule webpack config 配置事件',
13+
},
914

1015
};

src/extends/unified/app.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ module.exports = function unifiedExtend(api, opts) {
3636
});
3737
}
3838

39-
api.modifyChainWebpackConfig(webpackChain => {
39+
api.modifyWebpackChain(webpackChain => {
4040

4141
const options = api.config || {};
4242

src/extends/unified/babel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module.exports = function unifiedExtend(api, opts) {
66

77
const path = require('path');
88

9-
api.modifyChainWebpackConfig(webpackChain => {
9+
api.modifyWebpackChain(webpackChain => {
1010
// const isProd = api.mode === 'production';
1111
// const rootOptions = api.config || {};
1212

src/extends/unified/base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ module.exports = function unifiedExtend(api, opts) {
3636
return webpackChain;
3737
}
3838

39-
api.modifyChainWebpackConfig(webpackChain => {
39+
api.modifyWebpackChain(webpackChain => {
4040

4141
webpackChain = baseConfig(webpackChain);
4242

src/extends/unified/css.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ module.exports = function unifiedExtend(api, opts) {
1414
}
1515
};
1616

17-
api.modifyChainWebpackConfig(webpackChain => {
17+
api.modifyWebpackChain(webpackChain => {
1818
const { getAssetPath } = require('./utils');
1919
const isProd = api.mode === 'production';
2020
const rootOptions = api.config || {};

src/extends/unified/plugins.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module.exports = function unifiedExtend(api, opts) {
44

55
api.assertVersion('>=0.3.0');
66

7-
api.modifyChainWebpackConfig(webpackChain => {
7+
api.modifyWebpackChain(webpackChain => {
88
const { resolveLoaderError } = require('./utils');
99

1010
// const options = api.config || {};

src/extends/unified/prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module.exports = function unifiedExtend(api, opts) {
66

77
const { tryRequire, fs, hash } = require('@micro-app/shared-utils');
88

9-
api.modifyChainWebpackConfig(webpackChain => {
9+
api.modifyWebpackChain(webpackChain => {
1010
const { isWebpack4 } = require('./utils');
1111

1212
const options = api.config || {};

src/extends/unified/rules.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module.exports = function unifiedExtend(api, opts) {
66

77
const { tryRequire } = require('@micro-app/shared-utils');
88

9-
api.modifyChainWebpackConfig(webpackChain => {
9+
api.modifyWebpackChain(webpackChain => {
1010
const { getAssetPath, isWebpack4 } = require('./utils');
1111

1212
const options = api.config || {};

src/extends/unified/vue.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module.exports = function unifiedExtend(api, opts) {
44

55
api.assertVersion('>=0.3.0');
66

7-
api.modifyChainWebpackConfig(webpackChain => {
7+
api.modifyWebpackChain(webpackChain => {
88
// const isProd = api.mode === 'production';
99
// const rootOptions = api.config || {};
1010

0 commit comments

Comments
 (0)