Skip to content

Commit 7fcf887

Browse files
Merge branch 'MightyMoud:main' into main
2 parents b3fcba5 + 88f7fe8 commit 7fcf887

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

cmd/compose.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ to quickly create a Cobra application.`,
107107
if utils.FileExists(fmt.Sprintf("./%s", envFileName)) {
108108
hasEnvFile = true
109109
pterm.Info.Printfln("Env file detected - Loading env vars from %s", envFileName)
110-
res := utils.HandleEnvFile(envFileName, envVariables, dockerEnvProperty, &envFileChecksum)
110+
res := utils.HandleEnvFile(envFileName, envVariables, &dockerEnvProperty, &envFileChecksum)
111111
fmt.Println(res)
112112
fmt.Println(dockerEnvProperty)
113113
defer os.Remove("encrypted.env")

cmd/launch.go

+7-3
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,12 @@ var launchCmd = &cobra.Command{
4040
os.Exit(1)
4141
}
4242

43+
if utils.FileExists("./sidekick.yml") {
44+
pterm.Error.Println("Sidekick config exits in this project.")
45+
pterm.Info.Println("You can deploy a new version of your application with Sidekick deploy.")
46+
os.Exit(1)
47+
}
48+
4349
if utils.FileExists("./Dockerfile") {
4450
pterm.Info.Println("Dockerfile detected - scanning file for details")
4551
} else {
@@ -93,13 +99,11 @@ var launchCmd = &cobra.Command{
9399
if utils.FileExists(fmt.Sprintf("./%s", envFileName)) {
94100
hasEnvFile = true
95101
pterm.Info.Printfln("Env file detected - Loading env vars from %s", envFileName)
96-
utils.HandleEnvFile(envFileName, envVariables, dockerEnvProperty, &envFileChecksum)
102+
utils.HandleEnvFile(envFileName, envVariables, &dockerEnvProperty, &envFileChecksum)
97103
defer os.Remove("encrypted.env")
98104
} else {
99105
pterm.Info.Println("No env file detected - Skipping env parsing")
100106
}
101-
fmt.Println("Env is:")
102-
fmt.Println(dockerEnvProperty)
103107

104108
// make a docker service
105109
imageName := appName

cmd/preview.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ to quickly create a Cobra application.`,
9393
dockerEnvProperty := []string{}
9494
envFileChecksum := ""
9595
if appConfig.Env.File != "" {
96-
envErr := utils.HandleEnvFile(appConfig.Env.File, envVariables, dockerEnvProperty, &envFileChecksum)
96+
envErr := utils.HandleEnvFile(appConfig.Env.File, envVariables, &dockerEnvProperty, &envFileChecksum)
9797
if envErr != nil {
9898
panic(envErr)
9999
}

utils/utils.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ func LoadAppConfig() (SidekickAppConfig, error) {
277277
return appConfigFile, nil
278278
}
279279

280-
func HandleEnvFile(envFileName string, envVariables []string, dockerEnvProperty []string, envFileChecksum *string) error {
280+
func HandleEnvFile(envFileName string, envVariables []string, dockerEnvProperty *[]string, envFileChecksum *string) error {
281281
envFileContent, envFileErr := os.ReadFile(fmt.Sprintf("./%s", envFileName))
282282
if envFileErr != nil {
283283
pterm.Error.Println("Unable to process your env file")
@@ -290,7 +290,7 @@ func HandleEnvFile(envFileName string, envVariables []string, dockerEnvProperty
290290
}
291291

292292
for _, envVar := range envVariables {
293-
dockerEnvProperty = append(dockerEnvProperty, fmt.Sprintf("%s=${%s}", envVar, envVar))
293+
*dockerEnvProperty = append(*dockerEnvProperty, fmt.Sprintf("%s=${%s}", envVar, envVar))
294294
}
295295
// calculate and store the hash of env file to re-encrypt later on when changed
296296
*envFileChecksum = fmt.Sprintf("%x", md5.Sum(envFileContent))

0 commit comments

Comments
 (0)