Merge pull request #889 from Migorithm/feat/client-response

feat: extended use of bincode for serde

Author: Migorithm

duva-client/src/broker/mod.rs

@@ -14,7 +14,7 @@ use duva::prelude::tokio::sync::mpsc::Receiver;
 use duva::prelude::tokio::sync::mpsc::Sender;
 use duva::prelude::uuid::Uuid;
 use duva::prelude::{
-    ConnectionRequest, ConnectionRequests, ConnectionResponse, ConnectionResponses,
+    BinBytes, ConnectionRequest, ConnectionRequests, ConnectionResponse, ConnectionResponses,
 };
 use duva::prelude::{PeerIdentifier, tokio};
 use duva::prelude::{Topology, anyhow};
@@ -97,9 +97,9 @@ impl Broker {
                         context.expected_result_cnt = result_count;
                         queue.push(context);
                     } else {
-                        context.callback(QueryIO::Err(
-                            "Failed to route command. Try again after ttl time".into(),
-                        ));
+                        context.callback(QueryIO::Err(BinBytes::new(
+                            "Failed to route command. Try again after ttl time",
+                        )));
                     };
                 },
             }

duva-client/src/command.rs

@@ -1,5 +1,6 @@
 use duva::domains::caches::cache_manager::IndexedValueCodec;
 use duva::domains::replications::LogEntry;
+use duva::prelude::BinBytes;
 use duva::prelude::anyhow::{self, Context};
 use duva::presentation::clients::request::NonMutatingAction;
 use duva::{
@@ -30,7 +31,7 @@ impl CommandQueue {
         }
 
         let result =
-            context.get_result().unwrap_or_else(|err| QueryIO::Err(err.to_string().into()));
+            context.get_result().unwrap_or_else(|err| QueryIO::Err(BinBytes::new(err.to_string())));
         context.callback(result);
     }
 }
@@ -93,7 +94,7 @@ impl InputContext {
 
                     count += num;
                 }
-                Ok(QueryIO::SimpleString(count.to_string().into()))
+                Ok(QueryIO::SimpleString(BinBytes::new(count.to_string())))
             },
             ClientAction::Mutating(LogEntry::Delete { keys: _ }) => {
                 let mut count = 0;
@@ -106,7 +107,7 @@ impl InputContext {
 
                     count += decoded_value;
                 }
-                Ok(QueryIO::SimpleString(count.to_string().into()))
+                Ok(QueryIO::SimpleString(BinBytes::new(count.to_string())))
             },
             _ => {
                 if res.len() != 1 {

duva-client/src/controller.rs

@@ -46,14 +46,14 @@ fn render_return(kind: ClientAction, query_io: QueryIO) -> Response {
             | ClusterInfo,
         ) => match query_io {
             QueryIO::Null => Response::Null,
-            QueryIO::SimpleString(value) => Response::String(value),
-            QueryIO::BulkString(value) => Response::String(value),
-            QueryIO::Err(value) => Response::Error(value),
+            QueryIO::SimpleString(value) => Response::String(value.into()),
+            QueryIO::BulkString(value) => Response::String(value.into()),
+            QueryIO::Err(value) => Response::Error(value.into()),
             _err => Response::FormatError,
         },
         Mutating(LogEntry::Delete { .. }) | NonMutating(Exists { .. } | LLen { .. }) => {
             if let QueryIO::Err(value) = query_io {
-                return Response::Error(value);
+                return Response::Error(value.into());
             }
 
             let QueryIO::SimpleString(value) = query_io else {
@@ -79,7 +79,7 @@ fn render_return(kind: ClientAction, query_io: QueryIO) -> Response {
                 let s: Option<i64> = IndexedValueCodec::decode_value(s);
                 Response::Integer(s.unwrap().to_string().into())
             },
-            QueryIO::Err(value) => Response::Error(value),
+            QueryIO::Err(value) => Response::Error(value.into()),
 
             _ => Response::FormatError,
         },
@@ -92,13 +92,13 @@ fn render_return(kind: ClientAction, query_io: QueryIO) -> Response {
         Mutating(LogEntry::Set { .. } | LogEntry::LTrim { .. } | LogEntry::LSet { .. }) => {
             match query_io {
                 QueryIO::SimpleString(_) => Response::String("OK".into()),
-                QueryIO::Err(value) => Response::Error(value),
+                QueryIO::Err(value) => Response::Error(value.into()),
                 _ => Response::FormatError,
             }
         },
         NonMutating(ClusterMeet { .. } | ClusterReshard) => match query_io {
             QueryIO::Null => Response::String("OK".into()),
-            QueryIO::Err(value) => Response::Error(value),
+            QueryIO::Err(value) => Response::Error(value.into()),
             _ => Response::FormatError,
         },
         Mutating(LogEntry::Append { .. }) => match query_io {
@@ -107,7 +107,7 @@ fn render_return(kind: ClientAction, query_io: QueryIO) -> Response {
                 let s: Option<i64> = IndexedValueCodec::decode_value(s);
                 Response::String(s.unwrap().to_string().into())
             },
-            QueryIO::Err(value) => Response::Error(value),
+            QueryIO::Err(value) => Response::Error(value.into()),
             _ => Response::FormatError,
         },
         Mutating(LogEntry::LPop { .. } | LogEntry::RPop { .. })
@@ -137,11 +137,11 @@ fn render_return(kind: ClientAction, query_io: QueryIO) -> Response {
                     let QueryIO::BulkString(value) = item else {
                         return Response::FormatError;
                     };
-                    nodes.push(Response::String(value));
+                    nodes.push(Response::String(value.into()));
                 }
                 Response::Array(nodes)
             },
-            QueryIO::Err(value) => Response::Error(value),
+            QueryIO::Err(value) => Response::Error(value.into()),
             _ => Response::FormatError,
         },
 

duva/Cargo.toml

@@ -38,7 +38,3 @@ lzf = { version = "1.0.0" }
 [dev-dependencies]
 tempfile = "3.19.1"
 criterion = "0.7.0"
-
-[[bench]]
-name = "benchmark"
-harness = false