Suppressing abstract class with non-virtual destructor warning from pybind11

[ilthraim]

I am attempting to expose several classes to pyslang for typing (SyntaxFactory, SyntaxList, SeparatedSyntaxList, and TokenList) as seen in this commit. I am getting a build warning from my inclusion of SyntaxListBase in SyntaxBindings.cpp for "delete called on 'slang::syntax::SyntaxListBase' that is abstract but has non-virtual destructor" because of the pybind11 generated code. My understanding is that delete will never be called on this class, but I am still relatively new to the C++ side of slang. I see in SyntaxNode.h you suppress "-Wnon-virtual-dtor" warnings, and I was wondering if you thought a similar approach would work in this case.

Thanks!

[MikePopoloski]

It isn't deleted in the C++ but wrapping a SyntaxListBase in the classh thing from pybind11 basically means there will be a shared_ptr to it internally, and that will definitely call delete on it. It might be ok to ignore since these are all POD types anyway but trying to mesh this with the python bindings is definitely tricky stuff, I'm not entirely sure without spending a lot of time looking at it.

[ilthraim]

Appreciate the feedback. Sounds like I'll need to take a deeper look at a more robust solution