test: cover gold reward owner identity pickup

Author: MikelCalvo

internal/minimal/shared_world_test.go

@@ -681,6 +681,39 @@ func TestSharedWorldRegistryGroundRewardPickupWithholdsOwnerDeliveryAfterOwnerId
 	}
 }
 
+func TestSharedWorldRegistryGroundGoldRewardPickupWithholdsOwnerDeliveryAfterOwnerIdentityChanges(t *testing.T) {
+	registry := newSharedWorldRegistry()
+	owner := peerVisibilityCharacter("IdentityGoldPickupOwner", 0x010301ad, 0x020401ad, 1200, 2200, 0, 101, 201)
+	collector := peerVisibilityCharacter("OwnerIdentityGoldCollector", 0x010301ae, 0x020401ae, 1220, 2220, 0, 102, 202)
+	ownerID, _ := registry.Join(owner, newPendingServerFrames(), nil)
+	collectorID, _ := registry.Join(collector, newPendingServerFrames(), nil)
+	if ownerID == 0 || collectorID == 0 {
+		t.Fatal("expected owner and collector joins to allocate shared-world entity ids")
+	}
+	const groundVID uint32 = 0x07000029
+	if !registry.RegisterGroundGold(ownerID, "identity-gold-pickup-owner", owner, groundVID, 250) {
+		t.Fatal("expected owner ground-gold registration to succeed")
+	}
+	updatedOwner := owner
+	updatedOwner.Name = "FreshIdentityGoldPickupOwner"
+	updatedOwner.VID = 0x020401af
+	registry.UpdateCharacter(ownerID, updatedOwner)
+
+	pickup, ok := registry.GroundItemPickupFor(collectorID, collector, groundVID)
+	if !ok {
+		t.Fatal("expected collector gold pickup resolution to remain available")
+	}
+	if pickup.GoldAmount != 250 {
+		t.Fatalf("expected original gold amount to remain available, got %+v", pickup)
+	}
+	if pickup.Owner.ID != 0 || pickup.Owner.Name != "" {
+		t.Fatalf("expected gold owner delivery to be withheld after owner identity changes, got %+v", pickup.Owner)
+	}
+	if pickup.OwnerName != owner.Name {
+		t.Fatalf("expected display ownership name to remain %q, got %q", owner.Name, pickup.OwnerName)
+	}
+}
+
 func TestSharedWorldRegistryGroundRewardPickupRejectsStaleCollectorIdentitySnapshot(t *testing.T) {
 	registry := newSharedWorldRegistry()
 	owner := peerVisibilityCharacter("IdentityPickupOwner", 0x0103019d, 0x0204019d, 1200, 2200, 0, 101, 201)

spec/protocol/non-player-reward-bootstrap.md

@@ -125,9 +125,9 @@ Ground pickup also skips party-style delivery back into an owner that has since
 Ground pickup also withholds party-style owner delivery if the registered owner entity no longer matches the identity and exact runtime location captured when the ground reward was created; this preserves the display ownership label while preventing stale handles from mutating a rebound or relocated owner snapshot.
 Ground reward registration re-checks the registered owner snapshot before trusting the caller-supplied character copy, so a stale owner snapshot cannot create item-shaped or gold-shaped reward ground entries after the registered owner has already changed selected-character identity (`id`, `vid`, or name) or moved to a different runtime location.
 Lookup, pickup-resolution, and removal also re-check the registered collector snapshot before trusting the caller-supplied character copy, so a stale collector snapshot cannot see, resolve, or remove item-shaped or gold-shaped reward ground entries after that collector has already reached the bootstrap `0`-HP floor, changed selected-character identity (`id`, `vid`, or name), or moved out of the exact runtime location represented by the supplied pickup attempt.
-Dedicated coverage now freezes the gold-shaped reward half of both stale collector-identity and stale collector-location cases, not just ordinary item-shaped drops, because both reward families share the same ground-entry visibility/pickup seam.
+Dedicated coverage now freezes the gold-shaped reward half of stale collector-identity, stale collector-location, and stale owner-identity owner-delivery cases, not just ordinary item-shaped drops, because both reward families share the same ground-entry visibility/pickup seam.
 This guard applies in both directions for item-shaped and gold-shaped rewards: a stale near snapshot cannot pick up after the registered collector has moved away or rebound to a different selected-character identity, and a stale far snapshot cannot become valid merely because the registered collector later moved near the ground reward.
-When that living, identity-current, and currently reachable collector succeeds, the collector receives the ordinary self pickup shape (`ITEM_GROUND_DEL`, inventory `ITEM_SET`, and normal `ITEM_GET` feedback) and the dead owner receives no queued party-style pickup feedback.
+When that living, identity-current, and currently reachable collector succeeds, the collector receives the ordinary self pickup shape (`ITEM_GROUND_DEL`, inventory `ITEM_SET`, and normal `ITEM_GET` feedback) and the dead, rebound, or relocated owner receives no queued party-style pickup feedback.
 
 This keeps death/restart cleanup and concurrent movement from leaking new pickup surfaces, stale delete noise, debug/runtime-visible pickup affordances, stale collector pickup affordances, stale owner-location ground registration, transfer-entry ground visibility, or late owner-delivery mutations for players that are already dead or no longer at the supplied reward location.