style: 💄 enable more oxlint rules (#1767)

Author: Saul-Mirone

Diff for: .oxlintrc.json

@@ -2,7 +2,65 @@
   "plugins": ["import", "typescript", "unicorn", "promise"],
   "rules": {
     "no-console": "error",
+    "for-direction": "error",
+    "require-yield": "error",
+    "use-isnan": "error",
+    "valid-typeof": "error",
+    "no-empty-character-class": "error",
+    "no-self-compare": "error",
+    "no-empty": [
+      "error",
+      {
+        "allowEmptyCatch": true
+      }
+    ],
+    "no-constant-binary-expression": "error",
+    "no-constructor-return": "error",
+    "no-func-assign": "error",
+    "no-global-assign": "error",
+    "no-ex-assign": "error",
+    "no-loss-of-precision": "error",
+    "no-fallthrough": "error",
+    "no-nonoctal-decimal-escape": "error",
+    "no-irregular-whitespace": "error",
+    "no-control-regex": "error",
+    "no-with": "error",
+    "no-debugger": "error",
+    "no-const-assign": "error",
+    "no-setter-return": "error",
+    "no-obj-calls": "error",
+    "no-unsafe-negation": "error",
+    "no-dupe-class-members": "error",
+    "no-dupe-keys": "error",
+    "no-this-before-super": "error",
+    "no-useless-catch": "error",
+    "no-async-promise-executor": "error",
+    "no-unreachable": "error",
+    "no-duplicate-case": "error",
+    "no-empty-pattern": "error",
+    "no-unused-labels": "error",
+    "no-sparse-arrays": "error",
+    "no-delete-var": "error",
+    "no-compare-neg-zero": "error",
+    "no-case-declarations": "error",
+    "no-class-assign": "error",
+    "no-var": "error",
+    "no-self-assign": "error",
+    "no-inner-declarations": "error",
+    "no-dupe-else-if": "error",
+    "no-invalid-regexp": "error",
+    "no-unsafe-finally": "error",
+    "no-prototype-builtins": "error",
+    "no-array-constructor": "error",
+    "no-shadow-restricted-names": "error",
+    "no-constant-condition": "error",
+    "no-useless-escape": "error",
+    "no-unsafe-optional-chaining": "error",
+    "no-extra-boolean-cast": "error",
+    "no-regex-spaces": "error",
+
     "eslint/no-unused-vars": "off",
+
     "unicorn/prefer-array-some": "error",
     "unicorn/no-useless-promise-resolve-reject": "error",
     "unicorn/no-unnecessary-await": "error",
@@ -17,17 +75,42 @@
     "unicorn/prefer-blob-reading-methods": "error",
     "unicorn/no-typeof-undefined": "error",
     "unicorn/no-new-array": "error",
+
     "import/no-cycle": [
       "error",
       {
         "ignoreTypes": true
       }
     ],
+    "import/named": "error",
     "import/sort-imports": "error",
     "import/no-duplicates": "error",
     "import/no-import-assign": "error",
     "import/no-self-import": "error",
+
     "typescript/consistent-type-imports": "error",
-    "typescript/no-import-type-side-effects": "error"
+    "typescript/triple-slash-reference": "error",
+    "typescript/no-non-null-asserted-optional-chain": "error",
+    "typescript/no-import-type-side-effects": "error",
+    "typescript/no-duplicate-enum-values": "error",
+    "typescript/no-extra-non-null-assertion": "error",
+    "typescript/no-misused-new": "error",
+    "typescript/prefer-for-of": "error",
+    "typescript/no-unsafe-declaration-merging": "error",
+    "typescript/no-this-alias": [
+      "error",
+      {
+        "allowDestructuring": true
+      }
+    ],
+    "typescript/prefer-as-const": "error",
+    "typescript/no-var-requires": "error",
+    "typescript/no-namespace": [
+      "error",
+      {
+        "allowDeclarations": true
+      }
+    ],
+    "typescript/no-unnecessary-type-constraint": "error"
   }
 }

Diff for: package.json

@@ -61,7 +61,7 @@
     "jsdom": "^26.0.0",
     "lint-staged": "^15.0.0",
     "nx": "20.6.4",
-    "oxlint": "^0.16.0",
+    "oxlint": "^0.16.3",
     "pathe": "^2.0.0",
     "postcss": "^8.4.38",
     "postcss-cli": "^11.0.0",

Diff for: packages/plugins/preset-commonmark/src/node/paragraph.ts

@@ -51,7 +51,7 @@ function shouldPreserveEmptyLine(ctx: Ctx) {
   try {
     ctx.get(remarkPreserveEmptyLinePlugin.id)
     shouldPreserveEmptyLine = true
-  } catch (e) {
+  } catch {
     shouldPreserveEmptyLine = false
   }
   return shouldPreserveEmptyLine

Diff for: packages/prose/src/toolkit/input-rules/custom-input-rules.ts

@@ -22,26 +22,24 @@ function run(
       undefined,
       '\uFFFC'
     ) + text
-  for (let i = 0; i < rules.length; i++) {
-    const match = (rules[i] as unknown as { match: RegExp }).match.exec(
-      textBefore
-    )
+  for (let _matcher of rules) {
+    const matcher = _matcher as unknown as {
+      match: RegExp
+      handler: (
+        state: EditorState,
+        match: string[],
+        from: number,
+        to: number
+      ) => Transaction
+      undoable?: boolean
+    }
+    const match = matcher.match.exec(textBefore)
     const tr =
       match &&
       match[0] &&
-      (
-        rules[i] as unknown as {
-          handler: (
-            state: EditorState,
-            match: string[],
-            from: number,
-            to: number
-          ) => Transaction
-        }
-      ).handler(state, match, from - (match[0].length - text.length), to)
+      matcher.handler(state, match, from - (match[0].length - text.length), to)
     if (!tr) continue
-    // @ts-expect-error Internal property that should be in the class; only relevant if explicitly false.
-    if (rules[i]?.undoable !== false)
+    if (matcher.undoable !== false)
       tr.setMeta(plugin, { transform: tr, from, to, text })
     view.dispatch(tr)
     return true