ci: add eslint to lint errors not supported by oxlint

Author: Saul-Mirone

Diff for: .github/workflows/ci.yml

@@ -39,6 +39,9 @@ jobs:
       - name: Run lint
         run: pnpm test:lint --format github
 
+      - name: Run eslint
+        run: pnpm test:eslint
+
   unit:
     runs-on: ubuntu-latest
     needs: install-deps

Diff for: .gitignore

@@ -18,6 +18,8 @@ e2e/cypress/downloads
 
 sitemap.xml
 
+.eslintcache
+
 .env
 *.local
 *.cache

Diff for: .prettierignore

@@ -1 +1,3 @@
-pnpm-lock.yaml
+pnpm-lock.yaml
+**/storybook-static
+**/lib

Diff for: dev/src/generate.ts

@@ -1,14 +1,16 @@
 import { applyEdits, modify } from 'jsonc-parser'
-import { Workspace } from './workspace'
-import type { Path } from './path'
-import { type BuiltInParserName, format } from 'prettier'
 import { readFileSync, writeFileSync } from 'node:fs'
-import { Logger } from './logger'
+import { type BuiltInParserName, format } from 'prettier'
+
 import type { Package } from './package'
+import type { Path } from './path'
+
+import { Logger } from './logger'
+import { Workspace } from './workspace'
 
 export function generateTsConfig() {
   const generator = new Generator()
-  generator.run()
+  generator.run().catch(console.error)
 }
 
 export class Generator {

Diff for: dev/src/package.ts

@@ -1,10 +1,11 @@
 import { readFileSync } from 'node:fs'
 import { parse } from 'node:path'
 
-import { Path } from './path'
+import type { PackageItem } from './pnpm'
 import type { CommonPackageJsonContent } from './types'
 import type { Workspace } from './workspace'
-import type { PackageItem } from './pnpm'
+
+import { Path } from './path'
 import { pnpmList } from './pnpm'
 
 export function readPackageJson(path: Path): CommonPackageJsonContent {

Diff for: dev/src/vite.ts

@@ -1,7 +1,8 @@
+import type { BuildOptions, UserConfig } from 'vite'
+
 import { readFileSync } from 'node:fs'
 import { basename, dirname, resolve } from 'node:path'
 import { fileURLToPath } from 'node:url'
-import type { BuildOptions, UserConfig } from 'vite'
 import { defineConfig } from 'vite'
 
 import globalPackageJson from '../../package.json' with { type: 'json' }

Diff for: dev/src/workspace.ts

@@ -1,7 +1,8 @@
+import type { CommonPackageJsonContent } from './types'
+
 import { Logger } from './logger'
 import { Package, readPackageJson } from './package'
 import { ProjectRoot } from './path'
-import type { CommonPackageJsonContent } from './types'
 import { pnpmList } from './pnpm'
 
 class CircularDependenciesError extends Error {

Diff for: e2e/entry.ts

@@ -1,4 +1,5 @@
 import { resolve } from 'node:path'
+
 import { cases } from './src/data'
 
 const data = cases.reduce(

Diff for: e2e/playwright.config.ts

@@ -1,5 +1,5 @@
-import process from 'node:process'
 import { defineConfig, devices } from '@playwright/test'
+import process from 'node:process'
 
 /**
  * Read environment variables from file.

Diff for: e2e/shim.d.ts

@@ -1,9 +1,9 @@
 /// <reference types="vite/client" />
 
 import type { Editor } from '@milkdown/core'
-import type { EditorView } from '@milkdown/prose/view'
-import type { Telemetry } from '@milkdown/ctx'
 import type { Crepe } from '@milkdown/crepe'
+import type { Telemetry } from '@milkdown/ctx'
+import type { EditorView } from '@milkdown/prose/view'
 
 declare global {
   var __milkdown__: Editor

Diff for: e2e/src/crepe/main.ts

@@ -16,4 +16,4 @@ setup(async () => {
     globalThis.__afterCrepeCreated__(crepe)
   }
   return crepe.editor
-})
+}).catch(console.error)

Diff for: e2e/src/main.ts

@@ -1,5 +1,7 @@
 import './style.css'
+
 import { c, html } from 'atomico'
+
 import { cases } from './data'
 
 function App() {

Diff for: e2e/src/multi-editor/main.ts

@@ -1,8 +1,8 @@
 import { Editor, rootCtx } from '@milkdown/core'
-import { nord } from '@milkdown/theme-nord'
-import { commonmark } from '@milkdown/preset-commonmark'
 import { history } from '@milkdown/plugin-history'
+import { commonmark } from '@milkdown/preset-commonmark'
 import { gfm, insertTableCommand } from '@milkdown/preset-gfm'
+import { nord } from '@milkdown/theme-nord'
 import { callCommand } from '@milkdown/utils'
 
 import { setup } from '../utils'
@@ -22,11 +22,13 @@ setup(() => {
     .use(gfm)
     .use(history)
     .create()
-}).then((editor1) => {
-  globalThis.commands.addTable = () => {
-    editor1.action(callCommand(insertTableCommand.key))
-  }
 })
+  .then((editor1) => {
+    globalThis.commands.addTable = () => {
+      editor1.action(callCommand(insertTableCommand.key))
+    }
+  })
+  .catch(console.error)
 
 setup(() => {
   return Editor.make()
@@ -39,8 +41,10 @@ setup(() => {
     .use(gfm)
     .use(history)
     .create()
-}).then((editor2) => {
-  globalThis.commands.addTable2 = () => {
-    editor2.action(callCommand(insertTableCommand.key))
-  }
 })
+  .then((editor2) => {
+    globalThis.commands.addTable2 = () => {
+      editor2.action(callCommand(insertTableCommand.key))
+    }
+  })
+  .catch(console.error)

Diff for: e2e/src/plugin-automd/main.ts

@@ -1,9 +1,9 @@
 import { Editor, rootCtx } from '@milkdown/core'
-import { nord } from '@milkdown/theme-nord'
-import { listener, listenerCtx } from '@milkdown/plugin-listener'
 import { automd } from '@milkdown/plugin-automd'
+import { listener, listenerCtx } from '@milkdown/plugin-listener'
 import { commonmark, markInputRules } from '@milkdown/preset-commonmark'
 import { markInputRules as GFMMarkInputRules, gfm } from '@milkdown/preset-gfm'
+import { nord } from '@milkdown/theme-nord'
 
 import { setup } from '../utils'
 
@@ -16,7 +16,7 @@ setup(() => {
     .config((ctx) => {
       ctx.set(rootCtx, document.getElementById('app'))
       ctx.get(listenerCtx).markdownUpdated((_, markdown) => {
-        // eslint-disable-next-line no-console
+        // oxlint-disable-next-line no-console
         console.log(markdown)
       })
     })
@@ -26,4 +26,4 @@ setup(() => {
     .use(listener)
     .use(automd)
     .create()
-})
+}).catch(console.error)

Diff for: e2e/src/plugin-listener/main.ts

@@ -1,7 +1,7 @@
 import { Editor, defaultValueCtx, rootCtx } from '@milkdown/core'
-import { nord } from '@milkdown/theme-nord'
-import { commonmark } from '@milkdown/preset-commonmark'
 import { listener, listenerCtx } from '@milkdown/plugin-listener'
+import { commonmark } from '@milkdown/preset-commonmark'
+import { nord } from '@milkdown/theme-nord'
 
 import { setup } from '../utils'
 
@@ -15,12 +15,12 @@ setup(() => {
       ctx.set(rootCtx, document.getElementById('app'))
       ctx.set(defaultValueCtx, 'test')
       ctx.get(listenerCtx).markdownUpdated((_, markdown, prevMarkdown) => {
-        // eslint-disable-next-line no-console
+        // oxlint-disable-next-line no-console
         console.log(markdown, prevMarkdown)
       })
     })
     .config(nord)
     .use(commonmark)
     .use(listener)
     .create()
-})
+}).catch(console.error)

Diff for: e2e/src/preset-commonmark/main.ts

@@ -1,12 +1,12 @@
 import { Editor, rootCtx } from '@milkdown/core'
-import { nord } from '@milkdown/theme-nord'
+import { clipboard } from '@milkdown/plugin-clipboard'
+import { history } from '@milkdown/plugin-history'
 import {
   commonmark,
   toggleEmphasisCommand,
   toggleStrongCommand,
 } from '@milkdown/preset-commonmark'
-import { clipboard } from '@milkdown/plugin-clipboard'
-import { history } from '@milkdown/plugin-history'
+import { nord } from '@milkdown/theme-nord'
 import { callCommand } from '@milkdown/utils'
 
 import { setup } from '../utils'
@@ -27,13 +27,16 @@ setup(() => {
     .use(clipboard)
     .create()
 
-  editor.then((instance) => {
-    globalThis.commands.toggleStrong = () => {
-      instance.action(callCommand(toggleStrongCommand.key))
-    }
-    globalThis.commands.toggleEmphasis = () => {
-      instance.action(callCommand(toggleEmphasisCommand.key))
-    }
-  })
+  editor
+    .then((instance) => {
+      globalThis.commands.toggleStrong = () => {
+        instance.action(callCommand(toggleStrongCommand.key))
+      }
+      globalThis.commands.toggleEmphasis = () => {
+        instance.action(callCommand(toggleEmphasisCommand.key))
+      }
+    })
+    .catch(console.error)
+
   return editor
-})
+}).catch(console.error)

Diff for: e2e/src/preset-gfm/main.ts

@@ -1,8 +1,8 @@
 import { Editor, rootCtx } from '@milkdown/core'
-import { nord } from '@milkdown/theme-nord'
-import { commonmark } from '@milkdown/preset-commonmark'
 import { history } from '@milkdown/plugin-history'
+import { commonmark } from '@milkdown/preset-commonmark'
 import { gfm } from '@milkdown/preset-gfm'
+import { nord } from '@milkdown/theme-nord'
 
 import { setup } from '../utils'
 
@@ -21,4 +21,4 @@ setup(() => {
     .use(gfm)
     .use(history)
     .create()
-})
+}).catch(console.error)

Diff for: e2e/src/utils.ts

@@ -1,4 +1,5 @@
 import type { Editor } from '@milkdown/core'
+
 import { editorViewCtx, parserCtx, serializerCtx } from '@milkdown/core'
 import { Slice } from '@milkdown/prose/model'
 
@@ -33,13 +34,13 @@ export async function setup(createEditor: () => Promise<Editor>) {
 
   const logButton = document.querySelector<HTMLDivElement>('#log')
   if (logButton) {
-    // eslint-disable-next-line no-console
+    // oxlint-disable-next-line no-console
     logButton.onclick = () => console.log(globalThis.__getMarkdown__())
   }
 
   const inspectButton = document.querySelector<HTMLDivElement>('#inspect')
   if (inspectButton) {
-    // eslint-disable-next-line no-console
+    // oxlint-disable-next-line no-console
     inspectButton.onclick = () => console.log(globalThis.__inspect__())
   }
   return editor

Diff for: e2e/tests/command/bold.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, loadFixture, selectAll, setMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/crepe/latex.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/crepe/listener.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor } from '../misc'
 
 test('listen change before editor is created', async ({ page }) => {

Diff for: e2e/tests/input/blockquote.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/bold.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/bullet-list.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/code-block.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/code-inline.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/heading.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown, waitNextFrame } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/hr.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/italic.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/ordered-list.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/paragraph.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, getMarkdown } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/strike-through.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/table.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor, pressMetaKey } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/input/task-list.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from '@playwright/test'
+
 import { focusEditor } from '../misc'
 
 test.beforeEach(async ({ page }) => {

Diff for: e2e/tests/misc/index.ts

@@ -1,4 +1,5 @@
 import type { Page } from '@playwright/test'
+
 import fs from 'node:fs/promises'
 import path from 'node:path'