chore: remove nx (#1794)

* chore: remove nx

* chore: fix

* chore: fix deps

* chore: fix deps

* fix: dont run build on every setup action

* fix: prettier

* chore: fix

* chore: add build in summary

Author: Saul-Mirone

.github/actions/setup/action.yml

@@ -24,9 +24,3 @@ runs:
     - name: Install
       run: pnpm install
       shell: bash
-
-    - uses: nrwl/nx-set-shas@v4
-
-    - name: Build packages
-      run: pnpm build:nx
-      shell: bash

.github/workflows/ci.yml

@@ -13,7 +13,6 @@ concurrency:
 
 env:
   CI: true
-  NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
 
 jobs:
   install-deps:
@@ -54,6 +53,20 @@ jobs:
       - name: Run unit tests
         run: pnpm test:unit
 
+  build:
+    runs-on: ubuntu-latest
+    needs: install-deps
+    steps:
+      - name: Checkout code repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - uses: ./.github/actions/setup
+
+      - name: Build packages
+        run: pnpm build
+
   e2e:
     runs-on: ubuntu-latest
     needs: install-deps
@@ -69,6 +82,9 @@ jobs:
 
       - uses: ./.github/actions/setup
 
+      - name: Build e2e
+        run: pnpm --filter=@milkdown/e2e run build
+
       - name: Install browsers
         run: pnpm --filter=@milkdown/e2e test:install
 
@@ -85,9 +101,9 @@ jobs:
 
   summary:
     if: ${{ always() }}
-    needs: [lint, unit, e2e]
+    needs: [lint, unit, e2e, build]
     runs-on: ubuntu-latest
     steps:
       - name: On error
-        if: ${{ needs.e2e.result != 'success' || needs.unit.result != 'success' || needs.lint.result != 'success' }}
+        if: ${{ always() && (contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')) }}
         run: exit 1

.github/workflows/fix.yml

@@ -10,7 +10,6 @@ permissions:
 
 env:
   CI: true
-  NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
 
 jobs:
   fix:

.github/workflows/release.yml

@@ -8,7 +8,6 @@ concurrency: ${{ github.workflow }}-${{ github.ref }}
 
 env:
   CI: true
-  NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
 
 jobs:
   prepare:
@@ -39,6 +38,9 @@ jobs:
 
       - uses: ./.github/actions/setup
 
+      - name: Build packages
+        run: pnpm build
+
       - name: Publish to NPM
         run: pnpm ci:publish
         env:

.gitignore

@@ -19,12 +19,9 @@ e2e/cypress/downloads
 sitemap.xml
 
 .env
-nx-cloud.env
 *.local
 *.cache
 *error.log
 *debug.log
 
-.nx
-
 storybook-static

.prettierignore

@@ -1,4 +1 @@
-pnpm-lock.yaml
-
-/.nx/cache
-/.nx/workspace-data
+pnpm-lock.yaml

CONTRIBUTING.md

@@ -5,7 +5,7 @@
 
 After cloning Milkdown, run `pnpm install` to install dependencies.
 
-1. Run `pnpm build:nx`.
+1. Run `pnpm build`.
 2. Run `pnpm start` in one terminal to see storybook.
 
 # Commands
@@ -18,7 +18,7 @@ You can run several commands:
 - `pnpm test:e2e:debug` runs e2e test with UI.
 - `pnpm test:lint` checks the code style.
 - `pnpm test:tsc` runs typescript type checks.
-- `pnpm build:nx` runs build for all packages with cache powered by nx.
+- `pnpm build` runs build for all packages.
 - `pnpm commit` runs commit with git hooks.
 
 # Pre Check

dev/package.json

@@ -14,23 +14,5 @@
   },
   "scripts": {
     "build": "rimraf './lib' && tsc"
-  },
-  "nx": {
-    "targets": {
-      "build": {
-        "outputs": [
-          "{projectRoot}/lib"
-        ],
-        "dependsOn": [
-          "build"
-        ]
-      },
-      "tsc": {
-        "outputs": [],
-        "dependsOn": [
-          "build"
-        ]
-      }
-    }
   }
 }

e2e/package.json

@@ -37,27 +37,5 @@
     "katex": "^0.16.0",
     "serve": "^14.2.3",
     "tslib": "^2.8.1"
-  },
-  "nx": {
-    "targets": {
-      "build": {
-        "outputs": [
-          "{projectRoot}/lib"
-        ],
-        "dependsOn": [
-          "build"
-        ]
-      },
-      "preview": {
-        "dependsOn": [
-          "build"
-        ]
-      },
-      "serve": {
-        "dependsOn": [
-          "build"
-        ]
-      }
-    }
   }
 }

e2e/playwright.config.ts

@@ -58,7 +58,7 @@ export default defineConfig({
 
   /* Run your local dev server before starting the tests */
   webServer: {
-    command: process.env.CI ? 'pnpm run serve' : 'pnpm run start -- --host',
+    command: process.env.CI ? 'pnpm run serve' : 'pnpm run start --host',
     url: process.env.CI ? 'http://127.0.0.1:4173' : 'http://localhost:5173',
     reuseExistingServer: !process.env.CI,
   },