Skip to content

Commit bfa0eb3

Browse files
⬆️(deps) Bump the allbun group in /frontend with 7 updates (#238)
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: abimourad <abi.mourad@rijksoverheid.nl> Co-authored-by: Abi Mourad <76909935+abimourad@users.noreply.github.com>
1 parent 6a1f218 commit bfa0eb3

File tree

3 files changed

+254
-243
lines changed

3 files changed

+254
-243
lines changed

backend/app/clients/ocs.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import defusedxml.ElementTree as ET
99
from app.clients.base import BaseAPIClient
10-
from app.exceptions import ExternalServiceError
1110
from app.models.activity import Activity, FileActivity, FileActivityResponse, FileInfo
1211
from app.models.search import FileSearchResult
1312

@@ -87,9 +86,11 @@ async def _get_favorite_files(self) -> FileActivityResponse:
8786
url = self._build_url("ocs/v2.php/cloud/user")
8887
user_response = await self.client.get(url, params={"format": "json"}, headers=self._auth_headers())
8988
if user_response.status_code != 200:
90-
raise ExternalServiceError(
91-
self.service_name, f"Failed to resolve current user (status {user_response.status_code})"
89+
logger.warning(
90+
"Failed to resolve current user for favorites (status %s), returning empty results",
91+
user_response.status_code,
9292
)
93+
return FileActivityResponse(results=[], last_given=None)
9394
user_id = user_response.json().get("ocs", {}).get("data", {}).get("id", "")
9495

9596
# WebDAV REPORT to filter favorite files
@@ -109,7 +110,11 @@ async def _get_favorite_files(self) -> FileActivityResponse:
109110

110111
response = await self.client.request("REPORT", report_url, content=xml_body.encode(), headers=headers)
111112
if response.status_code not in (200, 207):
112-
raise ExternalServiceError(self.service_name, f"Failed to fetch favorites (status {response.status_code})")
113+
logger.warning(
114+
"Failed to fetch favorites via WebDAV REPORT (status %s), returning empty results",
115+
response.status_code,
116+
)
117+
return FileActivityResponse(results=[], last_given=None)
113118

114119
# Parse WebDAV multistatus XML response
115120
DAV = "DAV:"

0 commit comments

Comments
 (0)