implement tests

Author: miquelbeltran

.github/workflows/main.yml

@@ -7,7 +7,7 @@ on:
   workflow_dispatch:
 
 jobs:
-  ckeck:
+  check:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4

lib/config_props.dart

@@ -1,6 +1,7 @@
 import 'dart:io';
 
 import 'package:args/args.dart';
+import 'package:raygun_cli/environment.dart';
 
 /// Configuration properties for the Raygun CLI
 class ConfigProps {
@@ -25,7 +26,7 @@ class ConfigProps {
     if (arguments.wasParsed('app-id')) {
       appId = arguments['app-id'];
     } else {
-      appId = Platform.environment['RAYGUN_APP_ID'];
+      appId = Environment.instance.raygunAppId;
     }
 
     if (appId == null) {
@@ -38,7 +39,7 @@ class ConfigProps {
     if (arguments.wasParsed('token')) {
       token = arguments['token'];
     } else {
-      token = Platform.environment['RAYGUN_TOKEN'];
+      token = Environment.instance.raygunToken;
     }
 
     if (token == null) {

lib/environment.dart

@@ -0,0 +1,40 @@
+import 'dart:io';
+
+/// Wraps access to Environment variables
+/// Allows faking for testing
+class Environment {
+  static String raygunAppIdKey = 'RAYGUN_APP_ID';
+  static String raygunTokenKey = 'RAYGUN_TOKEN';
+
+  final String? raygunAppId;
+  final String? raygunToken;
+
+  static Environment? _instance;
+
+  /// Singleton instance access
+  /// Will init if not already
+  static Environment get instance {
+    _instance ??= Environment._init();
+    return _instance!;
+  }
+
+  /// For testing purposes
+  static void setInstance(Environment instance) {
+    _instance = instance;
+  }
+
+  /// Create custom instance
+  Environment({
+    required this.raygunAppId,
+    required this.raygunToken,
+  });
+
+  factory Environment._init() {
+    final raygunAppId = Platform.environment[raygunAppIdKey];
+    final raygunToken = Platform.environment[raygunTokenKey];
+    return Environment(
+      raygunAppId: raygunAppId,
+      raygunToken: raygunToken,
+    );
+  }
+}

test/config_props_test.dart

@@ -1,29 +1,96 @@
+import 'dart:io';
+
 import 'package:args/args.dart';
 import 'package:raygun_cli/config_props.dart';
+import 'package:raygun_cli/environment.dart';
 import 'package:test/test.dart';
 
 void main() {
   group('ConfigProps', () {
     test('should parse arguments', () {
       ArgParser parser = ArgParser()
-        ..addFlag('app-id')
-        ..addFlag('token');
+        ..addFlag('verbose')
+        ..addOption('app-id')
+        ..addOption('token');
       final results =
-          parser.parse(['app-id', 'app-id-parsed', 'token', 'token-parsed']);
+          parser.parse(['--app-id=app-id-parsed', '--token=token-parsed']);
       final props = ConfigProps.load(results);
       expect(props.appId, 'app-id-parsed');
       expect(props.token, 'token-parsed');
     });
 
     test('should parse from env vars', () {
+      // fake environment variables
+      Environment.setInstance(
+        Environment(
+          raygunAppId: 'app-id-env',
+          raygunToken: 'token-env',
+        ),
+      );
+
+      // define parser
       ArgParser parser = ArgParser()
-        ..addFlag('app-id')
-        ..addFlag('token');
-      // intentionally empty
+        ..addFlag('verbose')
+        ..addOption('app-id')
+        ..addOption('token');
+
+      // parse nothing
       final results = parser.parse([]);
+
+      // load from env vars
       final props = ConfigProps.load(results);
       expect(props.appId, 'app-id-env');
       expect(props.token, 'token-env');
     });
+
+    test('should parse with priority', () {
+      // fake environment variables
+      Environment.setInstance(
+        Environment(
+          raygunAppId: 'app-id-env',
+          raygunToken: 'token-env',
+        ),
+      );
+
+      // define parser
+      ArgParser parser = ArgParser()
+        ..addFlag('verbose')
+        ..addOption('app-id')
+        ..addOption('token');
+
+      // parse arguments
+      final results =
+          parser.parse(['--app-id=app-id-parsed', '--token=token-parsed']);
+
+      // load from parsed even if env vars are set
+      final props = ConfigProps.load(results);
+      expect(props.appId, 'app-id-parsed');
+      expect(props.token, 'token-parsed');
+    });
+
+    test('should parse from both', () {
+      // fake environment variables
+      // token is not provided
+      Environment.setInstance(
+        Environment(
+          raygunAppId: 'app-id-env',
+          raygunToken: null,
+        ),
+      );
+
+      // define parser
+      ArgParser parser = ArgParser()
+        ..addFlag('verbose')
+        ..addOption('app-id')
+        ..addOption('token');
+
+      // parse arguments, only token is passed
+      final results = parser.parse(['--token=token-parsed']);
+
+      // app-id from env, token from argument
+      final props = ConfigProps.load(results);
+      expect(props.appId, 'app-id-env');
+      expect(props.token, 'token-parsed');
+    });
   });
 }