test: Refactor and Test Deployment command (#28)

* refactor sourcemap api class

* refactor sourcemap command

* update bin

* completed command test

* add tests and format

* refactored proguard

* add tests for proguard command

* format

* refactor deployments command

* add deployments tests

* fix error not appearing when using wrong name command

Author: miquelbeltran

bin/raygun_cli.dart

@@ -31,8 +31,8 @@ ArgParser buildParser() {
       symbolsCommand.buildParser(),
     )
     ..addCommand(
-      kDeploymentsCommand,
-      buildParserDeployments(),
+      deploymentsCommand.name,
+      deploymentsCommand.buildParser(),
     )
     ..addCommand(
       proguardCommand.name,
@@ -58,6 +58,13 @@ void main(List<String> arguments) {
   try {
     final ArgResults results = argParser.parse(arguments);
     bool verbose = false;
+    if (results.wasParsed('verbose')) {
+      verbose = true;
+    }
+
+    if (verbose) {
+      print('[VERBOSE] All arguments: ${results.arguments}');
+    }
 
     if (results.wasParsed('help') || arguments.isEmpty) {
       printUsage(argParser);
@@ -67,9 +74,6 @@ void main(List<String> arguments) {
       print('raygun-cli version: $version');
       return;
     }
-    if (results.wasParsed('verbose')) {
-      verbose = true;
-    }
 
     if (results.command?.name == sourcemapCommand.name) {
       sourcemapCommand.execute(results.command!, verbose);
@@ -81,8 +85,8 @@ void main(List<String> arguments) {
       return;
     }
 
-    if (results.command?.name == kDeploymentsCommand) {
-      parseDeploymentsCommand(results.command!, verbose);
+    if (results.command?.name == deploymentsCommand.name) {
+      deploymentsCommand.execute(results.command!, verbose);
       return;
     }
 
@@ -91,12 +95,10 @@ void main(List<String> arguments) {
       return;
     }
 
-    if (verbose) {
-      print('[VERBOSE] All arguments: ${results.arguments}');
-    }
+    throw FormatException('Unknown or missing command.');
   } on FormatException catch (e) {
     // Print usage information if an invalid argument was provided.
-    print(e.message);
+    print('Error: ${e.message}');
     print('');
     printUsage(argParser);
   }

lib/src/core/raygun_api.dart

@@ -1,3 +1,4 @@
+import 'dart:convert';
 import 'dart:io';
 
 import 'package:http/http.dart';
@@ -40,3 +41,26 @@ class RaygunMultipartRequestBuilder {
     return _request;
   }
 }
+
+class RaygunPostRequestBuilder {
+  late final Request _request;
+
+  RaygunPostRequestBuilder(String url) {
+    _request = Request('POST', Uri.parse(url));
+  }
+
+  RaygunPostRequestBuilder addBearerToken(String token) {
+    _request.headers['Authorization'] = 'Bearer $token';
+    return this;
+  }
+
+  RaygunPostRequestBuilder addJsonBody(Map<String, dynamic> body) {
+    _request.body = jsonEncode(body);
+    _request.headers['Content-Type'] = 'application/json';
+    return this;
+  }
+
+  Request build() {
+    return _request;
+  }
+}

lib/src/deployments/deployments.dart

@@ -1,25 +1,25 @@
-import 'dart:io';
-
-import 'package:raygun_cli/src/deployments/deployments_api.dart';
 import 'package:args/args.dart';
+import 'package:raygun_cli/src/deployments/deployments_api.dart';
 import '../config_props.dart';
 
 /// Deployments command
 class Deployments {
   final ArgResults command;
   final bool verbose;
+  final DeploymentsApi deploymentsApi;
 
   Deployments({
     required this.command,
     required this.verbose,
+    required this.deploymentsApi,
   });
 
   /// Notifies Raygun that a new deployment has been made.
-  Future<void> notify() async {
+  Future<bool> notify() async {
     if (!command.wasParsed('version')) {
       print('Error: Missing "--version"');
       print('  Please provide "--version" via argument');
-      exit(2);
+      return false;
     }
 
     final version = command.option('version') as String;
@@ -42,7 +42,7 @@ class Deployments {
       print('scm-type: $scmType');
     }
 
-    final success = await createDeployment(
+    final success = await deploymentsApi.createDeployment(
       token: token,
       apiKey: apiKey,
       version: version,
@@ -55,10 +55,10 @@ class Deployments {
 
     if (success) {
       print('Deployment created successfully');
-      exit(0);
+      return true;
     } else {
       print('Failed to create deployment');
-      exit(2);
+      return false;
     }
   }
 }

lib/src/deployments/deployments_api.dart

@@ -1,52 +1,62 @@
 import 'dart:convert';
+
 import 'package:http/http.dart' as http;
+import 'package:raygun_cli/src/core/raygun_api.dart';
 
-/// Creates a deployment in Raygun.
-Future<bool> createDeployment({
-  required String token,
-  required String apiKey,
-  required String version,
-  String? ownerName,
-  String? emailAddress,
-  String? comment,
-  String? scmIdentifier,
-  String? scmType,
-}) async {
-  final url =
-      'https://api.raygun.com/v3/applications/api-key/$apiKey/deployments';
-
-  final payload = {
-    'version': version,
-    if (ownerName != null) 'ownerName': ownerName,
-    if (emailAddress != null) 'emailAddress': emailAddress,
-    if (comment != null) 'comment': comment,
-    if (scmIdentifier != null) 'scmIdentifier': scmIdentifier,
-    if (scmType != null) 'scmType': scmType,
-    'deployedAt': DateTime.now().toUtc().toIso8601String(),
-  };
-
-  try {
-    final response = await http.post(
-      Uri.parse(url),
-      headers: {
-        'Authorization': 'Bearer $token',
-        'Content-Type': 'application/json',
-      },
-      body: jsonEncode(payload),
-    );
-
-    if (response.statusCode == 200 || response.statusCode == 201) {
-      print('Success creating deployment: ${response.statusCode}');
-      print(
-          'Deployment identifier: ${jsonDecode(response.body)['identifier']}');
-      return true;
-    }
+class DeploymentsApi {
+  const DeploymentsApi(this.httpClient);
+
+  final http.Client httpClient;
+
+  DeploymentsApi.create() : httpClient = http.Client();
+
+  /// Creates a deployment in Raygun.
+  /// Returns true if the deployment was created successfully.
+  Future<bool> createDeployment({
+    required String token,
+    required String apiKey,
+    required String version,
+    String? ownerName,
+    String? emailAddress,
+    String? comment,
+    String? scmIdentifier,
+    String? scmType,
+  }) async {
+    final url =
+        'https://api.raygun.com/v3/applications/api-key/$apiKey/deployments';
 
-    print('Error creating deployment: ${response.statusCode}');
-    print('Response: ${response.body}');
-    return false;
-  } catch (e) {
-    print('Exception while creating deployment: $e');
-    return false;
+    final payload = {
+      'version': version,
+      if (ownerName != null) 'ownerName': ownerName,
+      if (emailAddress != null) 'emailAddress': emailAddress,
+      if (comment != null) 'comment': comment,
+      if (scmIdentifier != null) 'scmIdentifier': scmIdentifier,
+      if (scmType != null) 'scmType': scmType,
+      'deployedAt': DateTime.now().toUtc().toIso8601String(),
+    };
+
+    final request = RaygunPostRequestBuilder(url)
+        .addBearerToken(token)
+        .addJsonBody(payload)
+        .build();
+
+    try {
+      final response = await httpClient.send(request);
+      final responseBody = await response.stream.bytesToString();
+
+      if (response.statusCode == 200 || response.statusCode == 201) {
+        print('Success creating deployment: ${response.statusCode}');
+        print(
+            'Deployment identifier: ${jsonDecode(responseBody)['identifier']}');
+        return true;
+      }
+
+      print('Error creating deployment: ${response.statusCode}');
+      print('Response: $responseBody');
+      return false;
+    } catch (e) {
+      print('Exception while creating deployment: $e');
+      return false;
+    }
   }
 }