fix: #64 call to parent OnErrorAsync in RaygunErrorBoundary (#65)

miquelbeltran · web-flow · commit b78d260fbdb5 · 2025-01-22T13:16:00.000+01:00
diff --git a/src/Raygun.Blazor.Maui/Control/RaygunErrorBoundary.cs b/src/Raygun.Blazor.Maui/Control/RaygunErrorBoundary.cs
@@ -49,7 +49,9 @@ public class RaygunErrorBoundary : ErrorBoundary
         /// <returns></returns>
         protected override async Task OnErrorAsync(Exception exception)
         {
-            Console.WriteLine("OnErrorAsync");
+            // Always call to parent OnErrorAsync to log the error with default logger.
+            await base.OnErrorAsync(exception);
+
             if (!RaygunSettings.Value.CatchUnhandledExceptions) return;
 
             await RaygunClient.RecordExceptionAsync(exception, null, ["UnhandledException", "Blazor", ".NET"]);
diff --git a/src/Raygun.Blazor.Server/Controls/RaygunErrorBoundary.cs b/src/Raygun.Blazor.Server/Controls/RaygunErrorBoundary.cs
@@ -49,6 +49,9 @@ public class RaygunErrorBoundary : ErrorBoundary
         /// <returns></returns>
         protected override async Task OnErrorAsync(Exception exception)
         {
+            // Always call to parent OnErrorAsync to log the error with default logger.
+            await base.OnErrorAsync(exception);
+
             if (!RaygunSettings.Value.CatchUnhandledExceptions) return;
 
             await RaygunClient.RecordExceptionAsync(exception, null, ["UnhandledException", "Blazor", ".NET"]);
diff --git a/src/Raygun.Blazor.WebAssembly/Controls/RaygunErrorBoundary.cs b/src/Raygun.Blazor.WebAssembly/Controls/RaygunErrorBoundary.cs
@@ -56,6 +56,9 @@ public class RaygunErrorBoundary : ErrorBoundary
         /// <returns></returns>
         protected override async Task OnErrorAsync(Exception exception)
         {
+            // Always call to parent OnErrorAsync to log the error with default logger.
+            await base.OnErrorAsync(exception);
+
             if (!RaygunSettings.Value.CatchUnhandledExceptions) return;
 
             await RaygunClient.RecordExceptionAsync(exception, null, ["UnhandledException", "Blazor", ".NET"]);

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,9 @@ public class RaygunErrorBoundary : ErrorBoundary`
`49`	`49`	`/// <returns></returns>`
`50`	`50`	`protected override async Task OnErrorAsync(Exception exception)`
`51`	`51`	`{`
	`52`	`+ // Always call to parent OnErrorAsync to log the error with default logger.`
	`53`	`+ await base.OnErrorAsync(exception);`
	`54`	`+`
`52`	`55`	`if (!RaygunSettings.Value.CatchUnhandledExceptions) return;`
`53`	`56`
`54`	`57`	`await RaygunClient.RecordExceptionAsync(exception, null, ["UnhandledException", "Blazor", ".NET"]);`
Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,9 @@ public class RaygunErrorBoundary : ErrorBoundary`
`56`	`56`	`/// <returns></returns>`
`57`	`57`	`protected override async Task OnErrorAsync(Exception exception)`
`58`	`58`	`{`
	`59`	`+ // Always call to parent OnErrorAsync to log the error with default logger.`
	`60`	`+ await base.OnErrorAsync(exception);`
	`61`	`+`
`59`	`62`	`if (!RaygunSettings.Value.CatchUnhandledExceptions) return;`
`60`	`63`
`61`	`64`	`await RaygunClient.RecordExceptionAsync(exception, null, ["UnhandledException", "Blazor", ".NET"]);`