refactor: use pattern matching for instanceof checks

Simplify instanceof checks and casting using Java's pattern matching feature.
Remove unused HTTP endpoints for connection management and banning.
Improve error message for unknown framework messages.

Author: sharrlotte

src/playerconnect/HttpServer.java

@@ -12,8 +12,6 @@
 import com.fasterxml.jackson.databind.SerializationFeature;
 
 import arc.Events;
-import arc.net.DcReason;
-import arc.struct.Seq;
 import arc.util.Log;
 import io.javalin.Javalin;
 import io.javalin.json.JavalinJackson;
@@ -90,55 +88,6 @@ public HttpServer() {
 
         app.get("ping", ctx -> ctx.result("pong"));
 
-        app.get("connections", ctx -> {
-            if (!auth(ctx)) {
-                return;
-            }
-
-            var result = Seq.with(PlayerConnect.relay.getConnections())
-                    .map(connection -> {
-
-                        ConnectionDto dto = new ConnectionDto();
-                        dto.id = Utils.toString(connection);
-                        dto.ip = Utils.getIP(connection);
-
-                        return dto;
-                    }).list();
-
-            ctx.json(result);
-        });
-
-        app.post("ban", ctx -> {
-            if (!auth(ctx)) {
-                return;
-            }
-
-            var ip = ctx.body();
-
-            for (var connection : PlayerConnect.relay.getConnections()) {
-                if (Utils.getIP(connection).equals(ip)) {
-                    connection.close(DcReason.closed);
-                    Log.info("Kicked client <" + Utils.toString(connection) + "> for IP ban");
-                    Events.fire(new PlayerConnectEvents.ClientKickedEvent(connection));
-                }
-            }
-
-            Configs.IP_BLACK_LIST.add(ip);
-
-            ctx.json(Configs.IP_BLACK_LIST.list());
-        });
-
-        app.post("unban", ctx -> {
-            if (!auth(ctx)) {
-                return;
-            }
-
-            var ip = ctx.body();
-            Configs.IP_BLACK_LIST.remove(ip);
-
-            ctx.json(Configs.IP_BLACK_LIST.list());
-        });
-
         app.start(Integer.parseInt(System.getenv("PLAYER_CONNECT_HTTP_PORT")));
 
         Events.on(PlayerConnectEvents.RoomCreatedEvent.class, event -> {

src/playerconnect/NetworkRelay.java

@@ -25,7 +25,7 @@
 
 public class NetworkRelay extends Server implements NetListener {
     protected boolean isClosed;
-    
+
     /**
      * Keeps a cache of packets received from connections that are not yet in a
      * room. (queue of 3 packets)<br>
@@ -385,8 +385,8 @@ public Object read(ByteBuffer buffer) {
             if (id == Packets.id) {
                 Packets.Packet packet = Packets.newPacket(buffer.get());
                 packet.read(new ByteBufferInput(buffer));
-                if (packet instanceof Packets.ConnectionPacketWrapPacket) // This one is special
-                    ((Packets.ConnectionPacketWrapPacket) packet).buffer = (ByteBuffer) ((ByteBuffer) last.get()
+                if (packet instanceof Packets.ConnectionPacketWrapPacket wrap) // This one is special
+                    wrap.buffer = (ByteBuffer) ((ByteBuffer) last.get()
                             .clear()).put(buffer).flip();
                 return packet;
             }
@@ -408,8 +408,8 @@ public void write(ByteBuffer buffer, Object object) {
                 Packets.Packet packet = (Packets.Packet) object;
                 buffer.put(Packets.id).put(Packets.getId(packet));
                 packet.write(new ByteBufferOutput(buffer));
-                if (packet instanceof Packets.ConnectionPacketWrapPacket) // This one is special
-                    buffer.put(((Packets.ConnectionPacketWrapPacket) packet).buffer);
+                if (packet instanceof Packets.ConnectionPacketWrapPacket wrapPacket) // This one is special
+                    buffer.put(wrapPacket.buffer);
             }
         }
 
@@ -448,7 +448,7 @@ public FrameworkMessage readFramework(ByteBuffer buffer) {
                 p.connectionID = buffer.getInt();
                 return p;
             } else {
-                throw new RuntimeException("Unknown framework message!");
+                throw new RuntimeException("Unknown framework message: " + id);
             }
         }
     }

src/playerconnect/ServerRoom.java

@@ -97,15 +97,15 @@ public void received(Connection connection, Object object) {
         if (connection == host) {
             // Only claj packets are allowed in the host's connection
             // and can only be ConnectionPacketWrapPacket at this point.
-            if (!(object instanceof Packets.ConnectionPacketWrapPacket))
+            if (!(object instanceof Packets.ConnectionPacketWrapPacket wrap))
                 return;
 
-            int connectionId = ((Packets.ConnectionPacketWrapPacket) object).connectionId;
+            int connectionId = wrap.connectionId;
             Connection con = clients.get(connectionId);
 
             if (con != null && con.isConnected()) {
-                boolean tcp = ((Packets.ConnectionPacketWrapPacket) object).isTCP;
-                Object o = ((Packets.ConnectionPacketWrapPacket) object).buffer;
+                boolean tcp = wrap.isTCP;
+                Object o = wrap.buffer;
 
                 if (tcp)
                     con.sendTCP(o);
@@ -125,14 +125,13 @@ public void received(Connection connection, Object object) {
             // We never send claj packets to anyone other than the room host, framework
             // packets are ignored
             // and mindustry packets are saved as raw buffer.
-            if (!(object instanceof ByteBuffer))
+            if (!(object instanceof ByteBuffer buffer))
                 return;
 
             Packets.ConnectionPacketWrapPacket p = new Packets.ConnectionPacketWrapPacket();
             p.connectionId = connection.getID();
-            p.buffer = (ByteBuffer) object;
+            p.buffer = buffer;
             host.sendTCP(p);
-
         }
     }