refactor: make fields final in various workflow and handler classes for immutability

Author: sharrlotte

src/main/java/mindustrytool/handler/ApiGateway.java

@@ -88,7 +88,7 @@ private Builder setHeaders(Builder builder) {
 
     private URI path(String... path) {
         var uri = URI.create("http://server-manager:8088/internal-api/v1/" + Strings.join("/", path));
-        Log.debug("[REQUEST]: " + uri.toString());
+        Log.debug("[REQUEST]: " + uri);
 
         return uri;
     }

src/main/java/mindustrytool/handler/ClientCommandHandler.java

@@ -36,7 +36,7 @@ public ClientCommandHandler(ServerController controller) {
         Log.info("Client command handler created: " + this);
     }
 
-    private static boolean isPreparingForNewWave = false;
+    private static final boolean isPreparingForNewWave = false;
     private static short waveVoted = 0;
 
     @Getter

src/main/java/mindustrytool/handler/EventHandler.java

@@ -65,7 +65,7 @@ public EventHandler(ServerController controller) {
     }
 
     private List<ServerResponseData> servers = new ArrayList<>();
-    private List<ServerCore> serverCores = new ArrayList<>();
+    private final List<ServerCore> serverCores = new ArrayList<>();
 
     int page = 0;
     int gap = 50;
@@ -136,7 +136,7 @@ public void init() {
                                             : "[red]" + server.getStatus();
 
                                     var mods = server.getMods();
-                                    mods.removeIf(m -> m.trim().toLowerCase().equals("mindustrytoolplugin"));
+                                    mods.removeIf(m -> m.trim().equalsIgnoreCase("mindustrytoolplugin"));
 
                                     String message = //
                                             "%s (Tap core to join)\n\n".formatted(server.getName()) //
@@ -297,7 +297,7 @@ private void setName(Player player, String name, int level) {
     }
 
     public String getIconBaseOnLevel(int level) {
-        var index = (int) (level / 3);
+        var index = level / 3;
 
         if (index >= icons.size()) {
             index = icons.size() - 1;
@@ -630,7 +630,7 @@ public void sendServerList(Player player, int page) {
                         server.getName());
 
                 var mods = server.getMods();
-                mods.removeIf(m -> m.trim().toLowerCase().equals("mindustrytoolplugin"));
+                mods.removeIf(m -> m.trim().equalsIgnoreCase("mindustrytoolplugin"));
 
                 if (server.getMapName() == null) {
                     options.add(List.of(HudUtils.option(valid, "[yellow]%s".formatted(server.getName())),

src/main/java/mindustrytool/handler/HttpServer.java

@@ -419,7 +419,6 @@ public void init() {
             } catch (WorkflowError e) {
                 Log.err("Failed to load workflow", e);
                 context.status(400).json(Map.of("message", "Failed to load workflow: " + e.getMessage()));
-                return;
             }
         });
 

src/main/java/mindustrytool/handler/RtvVoteHandler.java

@@ -79,7 +79,6 @@ public void check(int mapId) {
             Vars.maps.setNextMapOverride(getMaps().get(mapId));
             reset();
             Events.fire(new EventType.GameOverEvent(Team.crux));
-            return;
         }
     }
 }

src/main/java/mindustrytool/handler/ServerCommandHandler.java

@@ -31,7 +31,7 @@ public ServerCommandHandler(ServerController controller) {
     @Getter
     private CommandHandler handler;
 
-    private List<PrevCommand> prevCommands = new ArrayList<>();
+    private final List<PrevCommand> prevCommands = new ArrayList<>();
 
     public void execute(String command, Consumer<CommandResponse> callback) {
         Core.app.post(() -> {

src/main/java/mindustrytool/handler/SessionHandler.java

@@ -8,7 +8,7 @@
 import mindustrytool.type.Session;
 
 public class SessionHandler {
-    private HashMap<String, Session> data = new HashMap<>();
+    private final HashMap<String, Session> data = new HashMap<>();
 
     public HashMap<String, Session> get() {
         return data;

src/main/java/mindustrytool/workflow/ESupplier.java

@@ -3,6 +3,6 @@
 @FunctionalInterface
 public interface ESupplier<T> {
 
-    public T get() throws Exception;
+    T get() throws Exception;
 
 }

src/main/java/mindustrytool/workflow/Workflow.java

@@ -54,7 +54,7 @@ public class Workflow {
     @Getter
     public WorkflowContext context;
 
-    private Queue<SseClient> workflowEventConsumers = new ConcurrentLinkedQueue<>();
+    private final Queue<SseClient> workflowEventConsumers = new ConcurrentLinkedQueue<>();
 
     public Queue<SseClient> getWorkflowEventConsumers() {
         return workflowEventConsumers;

src/main/java/mindustrytool/workflow/nodes/DisplayLabelWorkflow.java

@@ -7,22 +7,22 @@
 import mindustrytool.workflow.WorkflowUnit;
 
 public class DisplayLabelWorkflow extends WorkflowNode {
-    private WorkflowField<Player, Void> playerField = new WorkflowField<Player, Void>("player")
+    private final WorkflowField<Player, Void> playerField = new WorkflowField<Player, Void>("player")
             .consume(new FieldConsumer<>(Player.class).notRequired());
 
-    private WorkflowField<String, Void> messageField = new WorkflowField<String, Void>("message")
+    private final WorkflowField<String, Void> messageField = new WorkflowField<String, Void>("message")
             .consume(new FieldConsumer<>(String.class)
                     .defaultValue("Hello"));
 
-    private WorkflowField<Float, Void> xField = new WorkflowField<Float, Void>("x")
+    private final WorkflowField<Float, Void> xField = new WorkflowField<Float, Void>("x")
             .consume(new FieldConsumer<>(Float.class)
                     .defaultValue(0f));
 
-    private WorkflowField<Float, Void> yField = new WorkflowField<Float, Void>("y")
+    private final WorkflowField<Float, Void> yField = new WorkflowField<Float, Void>("y")
             .consume(new FieldConsumer<>(Float.class)
                     .defaultValue(0f));
 
-    private WorkflowField<Float, Void> durationField = new WorkflowField<Float, Void>("duration")
+    private final WorkflowField<Float, Void> durationField = new WorkflowField<Float, Void>("duration")
             .consume(new FieldConsumer<>(Float.class)
                     .unit(WorkflowUnit.SECOND)
                     .defaultValue(0f));