Skip to content

Commit 7b34041

Browse files
committed
refactor(server): adjust thread pool and timeout configurations
- Use underscore notation for better readability of numeric literals - Set async timeout to 5 seconds for better request handling - Configure server stop timeout to gracefully handle existing requests
1 parent 50c8e14 commit 7b34041

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ dependencies{
4545
compileOnly files('lib/MindustryToolPluginLoader.jar')
4646
implementation 'com.fasterxml.jackson.core:jackson-databind:2.16.2'
4747

48-
implementation 'io.javalin:javalin:6.3.0'
48+
implementation 'io.javalin:javalin:6.7.0'
4949
implementation 'com.github.ben-manes.caffeine:caffeine:2.9.3'
5050
implementation 'org.slf4j:slf4j-simple:2.0.16'
5151
implementation "org.reflections:reflections:0.10.2"

src/main/java/mindustrytool/handler/HttpServer.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,13 @@ public void init() {
8686

8787
int maxThreads = 20;
8888
int minThreads = 1;
89-
int idleTimeoutMillis = 20000;
90-
89+
int idleTimeoutMillis = 20_000;
90+
// to finish
91+
config.http.asyncTimeout = 5_000;
9192
config.useVirtualThreads = true;
93+
9294
config.jetty.threadPool = new QueuedThreadPool(maxThreads, minThreads, idleTimeoutMillis);
95+
config.jetty.modifyServer(server -> server.setStopTimeout(5_000)); // wait 5 seconds for existing requests
9396

9497
config.registerPlugin(new RouteOverviewPlugin());
9598

0 commit comments

Comments
 (0)