Skip to content

Commit cfeab74

Browse files
authored
Remove deprecations from mapping methods (#58)
Older versions of Forge are still open to recieve CoreMods updates
1 parent aa592c8 commit cfeab74

File tree

1 file changed

+6
-5
lines changed
  • src/main/java/net/minecraftforge/coremod/api

1 file changed

+6
-5
lines changed

src/main/java/net/minecraftforge/coremod/api/ASMAPI.java

+6-5
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,10 @@ public static LdcInsnNode buildNumberLdcInsnNode(final Number value, final Numbe
142142
* @param name The SRG name of the method
143143
* @return The mapped name of the method
144144
*
145-
* @deprecated Forge no longer uses SRG names in production
145+
* @apiNote As of Minecraft 1.20.4, Forge no longer uses SRG names in production. While the mapping system will
146+
* still work for sake of backwards-compatibility, you should not be using this method if you are on 1.20.4 or
147+
* later.
146148
*/
147-
@Deprecated(forRemoval = true, since = "5.1")
148149
public static String mapMethod(String name) {
149150
return map(name, INameMappingService.Domain.METHOD);
150151
}
@@ -155,14 +156,14 @@ public static String mapMethod(String name) {
155156
* @param name The SRG name of the field
156157
* @return The mapped name of the field
157158
*
158-
* @deprecated Forge no longer uses SRG names in production
159+
* @apiNote As of Minecraft 1.20.4, Forge no longer uses SRG names in production. While the mapping system will
160+
* still work for sake of backwards-compatibility, you should not be using this method if you are on 1.20.4 or
161+
* later.
159162
*/
160-
@Deprecated(forRemoval = true, since = "5.1")
161163
public static String mapField(String name) {
162164
return map(name, INameMappingService.Domain.FIELD);
163165
}
164166

165-
@Deprecated(forRemoval = true, since = "5.1")
166167
private static String map(String name, INameMappingService.Domain domain) {
167168
return Optional.ofNullable(Launcher.INSTANCE).
168169
map(Launcher::environment).

0 commit comments

Comments
 (0)