Fail to generate sources artifact when certain AT is present

[Yeregorix]

ForgeGradle fails to generate the Minecraft sources artifact when a certain AT is present.
To reproduce, download Forge MDK, add AT public net.minecraft.server.level.ServerLevel$EntityCallbacks and try to see the sources of a MC class. I'm using IntelliJ IDEA.

Logs : https://pastebin.com/PSR8V2Un

[Jonathing]

Looks like DiffPatch is failing when trying to patch when that class's access is transformed. This won't be an issue for FG7 since ATs are artifact transforms now, but should still look at this anyways. I'm hoping I don't have to re-arrange the MCP setup process in FG6.

[LexManos]

You can run with systemProp.net.minecraftforge.gradle.repo.debug=true in your gradle.properties to get more debug information.
Without looking into it, I'm going to bet you didnt AT the default constructor for that class and thus its decompiling with a whole new method. Which is screwing up the patching tool.
So, AT the constructor as well and try again.

[Jonathing]

In theory you shouldn't need to do that, so this is still a bug. But I think that workaround will do the trick.

[LexManos]

Runtime yes, patch time as it's dealing with decompiler source. No.
Its not a bug. Its just an issue with doing any asm modifications to pre-decompiled jars.

Using the new plugin will bypass the issue at the cost of not seeing your access changes in the source.

Like any asm hacks, you just need to know the qwerks and adapt.