Skip to content

Commit 324c7d4

Browse files
committed
Make partition_functions_for_all_configurations a LazyProperty
1 parent 38d1cdf commit 324c7d4

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

qha/multi_configurations/different_phonon_dos.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ def partition_functions_for_each_configuration(self):
127127
exp = np.vectorize(bigfloat.exp)
128128
return exp(-self.aligned_free_energies_for_each_configuration / (K * self.temperature))
129129

130+
@LazyProperty
130131
def partition_functions_for_all_configurations(self):
131132
"""
132133
Sum the partition functions for all configurations.
@@ -164,5 +165,5 @@ def get_free_energies(self):
164165
raise ImportError("Install ``bigfloat`` package to use {0} object!".format(self.__class__.__name__))
165166

166167
with bigfloat.precision(self.precision):
167-
log_z = np.array([bigfloat.log(d) for d in self.partition_functions_for_all_configurations()], dtype=float)
168+
log_z = np.array([bigfloat.log(d) for d in self.partition_functions_for_all_configurations], dtype=float)
168169
return -K * self.temperature * log_z

qha/tests/test_different_phonon_dos.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def test_partition_function(self):
7272
(52, 6)) # (# of configurations, # of volumes)
7373
self.assertEqual(self.partition_function.partition_functions_for_each_configuration.shape,
7474
(52, 6)) # (# of configurations, # of volumes)
75-
self.assertEqual(self.partition_function.partition_functions_for_all_configurations().shape,
75+
self.assertEqual(self.partition_function.partition_functions_for_all_configurations.shape,
7676
(6,)) # (# of volumes,)
7777
np.testing.assert_array_almost_equal(self.partition_function.get_free_energies(),
7878
[-550.74580132, -550.70964062, -550.37436235, -549.87365787, -549.43586034,

0 commit comments

Comments
 (0)