Skip to content

Commit 48c816c

Browse files
Minipadaclaude
andcommitted
docs: confirm full colcon build + colcon test pass after Fluent Bit removal
Ran the real verification progress.txt had left open: a fresh colcon build across all 14 remaining packages via tools/e2e/scripts/build.sh, then colcon test against live Postgres/RustFS test stores via tools/e2e/scripts/test.sh (the same scripts ci.yaml calls) — 84 tests, 0 failures. Closes out acceptance criteria 3 and 4 with an actual run instead of just inspection. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01StNXjcK7b1kY2KYRd8qN6N Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
1 parent c4d3846 commit 48c816c

1 file changed

Lines changed: 18 additions & 9 deletions

File tree

progress.txt

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -996,12 +996,21 @@ Bridge + Vector data plane (#242-#249) fully replaces it, per ADRs 0001/0003 and
996996
harness #249 built) against the full workspace, reusing that session's cached
997997
`dc-workspace` image layers — rosdep resolved and installed the full dependency set
998998
with no complaint about the removed packages (no dangling `dc_destinations`/
999-
`fluent_bit_*` depends anywhere, confirmed by grep beforehand too), and the build
1000-
reached and passed `dc_lifecycle_manager`/`dc_group`/`dc_services` before this PR was
1001-
opened; **the full build (through `dc_measurements`, `dc_bridge`, and `colcon test`)
1002-
was still running in the background when this PR was opened at the user's request —
1003-
see the next progress.txt update, or the session's actual commit history, for
1004-
whether it finished clean.** `pre-commit` was not re-run in this sandbox (same
1005-
environment-gap skips as every prior DC 2.0 slice: `build-doc`, `poetry-requirements`,
1006-
`pycln`, `flake8`); the `go-fmt` hook removal itself needs no verification since no
1007-
Go files remain for it to have ever run against.
999+
`fluent_bit_*` depends anywhere, confirmed by grep beforehand too). **All 14
1000+
remaining `dc_*`/vendor packages built clean** (`aws_sdk_vendor`, `dc_bridge`,
1001+
`dc_bringup`, `dc_cli`, `dc_common`, `dc_core`, `dc_description`, `dc_group`,
1002+
`dc_interfaces`, `dc_lifecycle_manager`, `dc_measurements`, `dc_services`,
1003+
`dc_util`, `vector_vendor` — `dc_demos`/`dc_simulation` stay `COLCON_IGNORE`d for
1004+
the unrelated Gazebo-Classic reason, #268). Then started the CI-equivalent
1005+
Postgres+RustFS test stores (`podman compose -f tools/e2e/compose.test.yaml up -d`,
1006+
`PODMAN_COMPOSE_PROVIDER=podman-compose` — the docker-compose cli-plugin fallback
1007+
needs a podman API socket that isn't running in this sandbox) and ran `tools/e2e/
1008+
scripts/test.sh` (the same script `ci.yaml` calls): **`colcon test` — 84 tests, 0
1009+
errors, 0 failures, 0 skipped**, including `dc_bridge`'s store-backed tests against
1010+
the real stores (which hard-fail rather than skip per the #246 follow-up decision,
1011+
so this run genuinely exercised them, not a skip path). Stores torn down
1012+
afterward. This closes acceptance criteria 3 ("Full colcon build and all tests
1013+
pass after removal") and 4 ("Go toolchain no longer required") for real, not just
1014+
by inspection. `pre-commit` was not re-run in this sandbox (same environment-gap
1015+
skips as every prior DC 2.0 slice: `build-doc`, `poetry-requirements`, `pycln`,
1016+
`flake8`).

0 commit comments

Comments
 (0)