Skip to content

Commit fc88399

Browse files
Minipadaclaude
andcommitted
fix(e2e): pin rustfs/rustfs to a digest instead of :latest
:latest is a floating tag — an upstream push could silently change what CI and the harness run against, with no diff to review. Pinned both references (compose.test.yaml's stable test store, run.sh's native-podman harness store) to the digest :latest currently resolves to (1.0.0-beta.11, confirmed via Docker Hub's tags API and a verified podman pull), with a comment noting the version and where to look up a new digest when bumping deliberately. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0155z4WEezE9gofR1zkHbMxK Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
1 parent f612e46 commit fc88399

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

tools/e2e/compose.test.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ services:
2727
retries: 30
2828

2929
rustfs:
30-
image: docker.io/rustfs/rustfs:latest
30+
# rustfs/rustfs 1.0.0-beta.11 — pinned by digest, not :latest, so an upstream
31+
# image change can't silently alter CI/local test behavior. Bump deliberately:
32+
# check https://hub.docker.com/r/rustfs/rustfs/tags for the new digest.
33+
image: docker.io/rustfs/rustfs@sha256:84ce557a0245a06a9aae5516f55ee0f007fca78d41df356f419306fdc0cb168c
3134
container_name: dc_rustfs_test
3235
network_mode: host

tools/e2e/scripts/run.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,12 @@ podman run -d --network host --name "$PG_C" \
127127
-v dc_e2e_pgdata:/var/lib/postgresql/data \
128128
-v "$E2E_DIR/sql/init.sql:/docker-entrypoint-initdb.d/init.sql:ro" \
129129
docker.io/library/postgres:13 >/dev/null
130+
# rustfs/rustfs 1.0.0-beta.11 — pinned by digest, not :latest, so an upstream image
131+
# change can't silently alter harness behavior. Bump deliberately: check
132+
# https://hub.docker.com/r/rustfs/rustfs/tags for the new digest.
130133
podman run -d --network host --name "$RUSTFS_C" \
131134
-v dc_e2e_rustfs_data:/data \
132-
docker.io/rustfs/rustfs:latest >/dev/null
135+
docker.io/rustfs/rustfs@sha256:84ce557a0245a06a9aae5516f55ee0f007fca78d41df356f419306fdc0cb168c >/dev/null
133136

134137
timeout 60 bash -c "until podman exec $PG_C pg_isready -U dc >/dev/null 2>&1; do sleep 1; done" \
135138
|| { log "Postgres never became ready"; exit 1; }

0 commit comments

Comments
 (0)