Change checks

Author: MioVisman

addons/security_for_login.php

@@ -142,7 +142,7 @@ function hook_login_before_validation()
 			return;
 		}
 
-		if ($cur_form['form_ip'] != get_remote_address())
+		if ($cur_form['form_ip'] !== get_remote_address())
 			$errors[] = security_msg('4');
 
 		if ($now - $this->time_min < $cur_form['form_time'])

addons/security_for_post.php

@@ -138,7 +138,7 @@ function hook_post_after_validation()
 			return;
 		}
 
-		if ($cur_form['form_ip'] != get_remote_address())
+		if ($cur_form['form_ip'] !== get_remote_address())
 			$errors[] = security_msg('4');
 
 		if ($now - $this->time_min < $cur_form['form_time'])

addons/security_for_register.php

@@ -124,7 +124,7 @@ function hook_register_after_validation()
 			return;
 		}
 
-		if (!isset($_POST['req_user']) || !isset($_POST['req_email1']) || !isset($_POST['timezone']) || !isset($_POST['email_setting']))
+		if (!isset($_POST['req_user'], $_POST['req_email1'], $_POST['timezone'], $_POST['email_setting']) || (empty($_POST['language']) && count(forum_list_langs()) > 1))
 			$errors[] = security_msg('1');
 
 		if (security_test_browser())
@@ -139,7 +139,7 @@ function hook_register_after_validation()
 			return;
 		}
 
-		if ($cur_form['form_ip'] != get_remote_address())
+		if ($cur_form['form_ip'] !== get_remote_address())
 			$errors[] = security_msg('4');
 
 		if ($now - $this->time_min < $cur_form['form_time'])

include/security.php

@@ -236,7 +236,7 @@ function security_show_captcha(int $tabindex, bool $acaptcha = true, bool $qcapt
 
 function security_test_browser()
 {
-		return empty($_SERVER['HTTP_ACCEPT_CHARSET']) && empty($_SERVER['HTTP_ACCEPT_ENCODING']) && empty($_SERVER['HTTP_ACCEPT_LANGUAGE']);
+	return empty($_SERVER['HTTP_ACCEPT']) || '*/*' == $_SERVER['HTTP_ACCEPT'] || empty($_SERVER['HTTP_ACCEPT_ENCODING']) || empty($_SERVER['HTTP_ACCEPT_LANGUAGE']) || empty($_SERVER['HTTP_ORIGIN']);
 }
 
 

register.php

@@ -106,7 +106,7 @@
 
 	if (!is_valid_email($email1))
 		$errors[] = $lang_common['Invalid email'];
-	else if ($pun_config['o_regs_verify'] == '1' && $email1 != $email2)
+	else if ($pun_config['o_regs_verify'] == '1' && $email1 !== $email2)
 		$errors[] = $lang_register['Email not match'];
 
 	// Check if it's a banned email address