Async spawning to better support Addressables

[James-Frowen]

Please explain the suggested feature in detail.

Addressables allows prefabs to be loaded from asset bundles at runtime. Prefabs are normally spawned via

Addressables.InstantiateAsync("AssetAddress");

or

Addressables.LoadAssetAsync<GameObject>("AssetAddress");

Both of these methods are asynchronous and have a completed event when they are finished.

How exactly does this keep you from releasing your game right now?

With the current spawn handlers within mirror it is not possible to call these methods as the handlers return a result right away.

The alternative is to list the prefab early to make sure they exist by the time mirror wants to spawn them, this reducing some of the benefits of being able to load and unload assets when they are needed.

Can you suggest a possible solution?

Add another version of the spawnHandlers that does not return the game object right away, but instead passes a callback into the handler. That callback would then be called by the user's handler after InstantiateAsync has finished. The callback would then apply the spawn message.

One possible problem with this may be future messages being received on the client before they have finished loading the prefab. We may need to add a way to queue up messages for a netId and apply them after the callback is called.

[MrGadget1024]

Until we do something more concrete on this, WaitForCompletion makes it synchronous, so your custom spawn handler can effectively block for the loading of the addressable and return it.

[James-Frowen]

WaitForCompletion will only work if you have pre-loaded the bundle, otherwise it will block the main thread till it is loaded (which could take seconds).

I've found the best thing to do is load the prefabs ahead of time and then register them with Mirror when they are loaded.

[FakeByte]

WaitForCompletion will only work if you have pre-loaded the bundle, otherwise it will block the main thread till it is loaded (which could take seconds).

I've found the best thing to do is load the prefabs ahead of time and then register them with Mirror when they are loaded.

We load the catalog and then use WaitForCompletion to load specific prefabs from bundles based on their paths, it is fast for us, but I guess it depends on what you load.

[MrGadget1024]

Reopening - we really need to deal with this case.

[VulgoRox]

This is a very important feature, really need it!
My current workaround for this is having a "ghost" prefab, that deal with all the sync while the main prefab is loading.

[MrGadget1024]

@VulgoRox Does WaitForCompletion as described in other comments work for you?