-
Notifications
You must be signed in to change notification settings - Fork 20
Open
Description
Hello,
First of all, thank you for working on that script. It works well.
After tweaking my settings a bit on node-red (i was trying to automate my heatpump), i noticed i was getting errors when i was setting my temperature lower than 18C. My heatpump support a temperature range of 16 - 32. The entity on home assistant confirms this.
I noticed that you placed a low ceiling of 180 in splitAC.py (line 180ish). Here's a snippet :
def changeTemperature(self,newTemperature):
## set temperature for degree C
if not isinstance(newTemperature,int) and not isinstance(newTemperature,float):
raise Exception('Wrong usage of method')
## Fixing temps if not given as multiplies of 10 less than 180
if newTemperature < 180:
newTemperature = newTemperature * 10
if (newTemperature >= 180 and newTemperature <= 320):
self.adjust_temperature = newTemperature
else:
raise Exception('out of range temperature!!')
After changing 180 for 160, i don't have any problems on my end anymore.
Should i push this change to the repo, or was the limit of 180 there for some reason?
Thanks again for your work
Metadata
Metadata
Assignees
Labels
No labels