Skip to content

Commit c9635ce

Browse files
committed
[Fix] (Texture): Correct TEXTURE_CUBE_MAP handling.
1 parent 3f0d7d9 commit c9635ce

2 files changed

Lines changed: 19 additions & 19 deletions

File tree

src/main/cpp/gl/texture.cpp

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ GLenum ConvertTextureTargetToGLEnum(TextureTarget target) {
5656
case TextureTarget::PROXY_TEXTURE_RECTANGLE: return GL_PROXY_TEXTURE_RECTANGLE;
5757
case TextureTarget::TEXTURE_CUBE_MAP: return GL_TEXTURE_CUBE_MAP;
5858
case TextureTarget::PROXY_TEXTURE_CUBE_MAP: return GL_PROXY_TEXTURE_CUBE_MAP;
59-
case TextureTarget::TEXTURE_CUBE_MAP_POSITIVE_X: return GL_TEXTURE_CUBE_MAP_POSITIVE_X;
60-
case TextureTarget::TEXTURE_CUBE_MAP_NEGATIVE_X: return GL_TEXTURE_CUBE_MAP_NEGATIVE_X;
61-
case TextureTarget::TEXTURE_CUBE_MAP_POSITIVE_Y: return GL_TEXTURE_CUBE_MAP_POSITIVE_Y;
62-
case TextureTarget::TEXTURE_CUBE_MAP_NEGATIVE_Y: return GL_TEXTURE_CUBE_MAP_NEGATIVE_Y;
63-
case TextureTarget::TEXTURE_CUBE_MAP_POSITIVE_Z: return GL_TEXTURE_CUBE_MAP_POSITIVE_Z;
64-
case TextureTarget::TEXTURE_CUBE_MAP_NEGATIVE_Z: return GL_TEXTURE_CUBE_MAP_NEGATIVE_Z;
59+
// case TextureTarget::TEXTURE_CUBE_MAP_POSITIVE_X: return GL_TEXTURE_CUBE_MAP_POSITIVE_X;
60+
// case TextureTarget::TEXTURE_CUBE_MAP_NEGATIVE_X: return GL_TEXTURE_CUBE_MAP_NEGATIVE_X;
61+
// case TextureTarget::TEXTURE_CUBE_MAP_POSITIVE_Y: return GL_TEXTURE_CUBE_MAP_POSITIVE_Y;
62+
// case TextureTarget::TEXTURE_CUBE_MAP_NEGATIVE_Y: return GL_TEXTURE_CUBE_MAP_NEGATIVE_Y;
63+
// case TextureTarget::TEXTURE_CUBE_MAP_POSITIVE_Z: return GL_TEXTURE_CUBE_MAP_POSITIVE_Z;
64+
// case TextureTarget::TEXTURE_CUBE_MAP_NEGATIVE_Z: return GL_TEXTURE_CUBE_MAP_NEGATIVE_Z;
6565
case TextureTarget::TEXTURE_CUBE_MAP_ARRAY: return GL_TEXTURE_CUBE_MAP_ARRAY;
6666
case TextureTarget::PROXY_TEXTURE_CUBE_MAP_ARRAY: return GL_PROXY_TEXTURE_CUBE_MAP_ARRAY;
6767
case TextureTarget::TEXTURE_BUFFER: return GL_TEXTURE_BUFFER;
@@ -87,14 +87,14 @@ TextureTarget ConvertGLEnumToTextureTarget(GLenum target) {
8787
case GL_PROXY_TEXTURE_3D: return TextureTarget::PROXY_TEXTURE_3D;
8888
case GL_TEXTURE_RECTANGLE: return TextureTarget::TEXTURE_RECTANGLE;
8989
case GL_PROXY_TEXTURE_RECTANGLE: return TextureTarget::PROXY_TEXTURE_RECTANGLE;
90-
case GL_TEXTURE_CUBE_MAP: return TextureTarget::TEXTURE_CUBE_MAP;
9190
case GL_PROXY_TEXTURE_CUBE_MAP: return TextureTarget::PROXY_TEXTURE_CUBE_MAP;
92-
case GL_TEXTURE_CUBE_MAP_POSITIVE_X: return TextureTarget::TEXTURE_CUBE_MAP_POSITIVE_X;
93-
case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: return TextureTarget::TEXTURE_CUBE_MAP_NEGATIVE_X;
94-
case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: return TextureTarget::TEXTURE_CUBE_MAP_POSITIVE_Y;
95-
case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: return TextureTarget::TEXTURE_CUBE_MAP_NEGATIVE_Y;
96-
case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: return TextureTarget::TEXTURE_CUBE_MAP_POSITIVE_Z;
97-
case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: return TextureTarget::TEXTURE_CUBE_MAP_NEGATIVE_Z;
91+
case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
92+
case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
93+
case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
94+
case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
95+
case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
96+
case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
97+
case GL_TEXTURE_CUBE_MAP: return TextureTarget::TEXTURE_CUBE_MAP;
9898
case GL_TEXTURE_CUBE_MAP_ARRAY: return TextureTarget::TEXTURE_CUBE_MAP_ARRAY;
9999
case GL_PROXY_TEXTURE_CUBE_MAP_ARRAY: return TextureTarget::PROXY_TEXTURE_CUBE_MAP_ARRAY;
100100
case GL_TEXTURE_BUFFER: return TextureTarget::TEXTURE_BUFFER;

src/main/cpp/gl/texture.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@ enum class TextureTarget : unsigned int {
6161
PROXY_TEXTURE_RECTANGLE,
6262
TEXTURE_CUBE_MAP,
6363
PROXY_TEXTURE_CUBE_MAP,
64-
TEXTURE_CUBE_MAP_POSITIVE_X,
65-
TEXTURE_CUBE_MAP_NEGATIVE_X,
66-
TEXTURE_CUBE_MAP_POSITIVE_Y,
67-
TEXTURE_CUBE_MAP_NEGATIVE_Y,
68-
TEXTURE_CUBE_MAP_POSITIVE_Z,
69-
TEXTURE_CUBE_MAP_NEGATIVE_Z,
64+
// TEXTURE_CUBE_MAP_POSITIVE_X,
65+
// TEXTURE_CUBE_MAP_NEGATIVE_X,
66+
// TEXTURE_CUBE_MAP_POSITIVE_Y,
67+
// TEXTURE_CUBE_MAP_NEGATIVE_Y,
68+
// TEXTURE_CUBE_MAP_POSITIVE_Z,
69+
// TEXTURE_CUBE_MAP_NEGATIVE_Z,
7070
TEXTURE_CUBE_MAP_ARRAY,
7171
PROXY_TEXTURE_CUBE_MAP_ARRAY,
7272
TEXTURE_BUFFER,

0 commit comments

Comments
 (0)