Commit 3306b1c
fix: add missing Popover import in DetailHeader (#476)
* fix: add missing Popover import in DetailHeader
The TagsInline component uses Popover to display hidden tags when
they overflow the container width, but Popover was not imported from
antd. This caused a runtime error when datasets had many tags (>5),
triggering ErrorBoundary and redirecting users to homepage.
Root cause: Line 3 imported Card, Button, Tag, Tooltip, Modal but
missing Popover, while Popover was used at lines 193-215.
Fix: Add Popover to the antd import statement.
* fix: correct Tag id type from number to string (UUID)
The backend returns Tag objects with UUID string IDs, but frontend components
AddTagPopover and DetailHeader defined Tag interface with id: number, causing
type mismatch and potential display issues.
Changes:
- AddTagPopover.tsx: interface Tag { id: number } → { id: string }
- DetailHeader.tsx: TagConfig and TagsInline interfaces updated to id: string
This aligns with:
- Backend: TagResponse.java returns UUID string
- dataset.model.ts: TagItem interface already correctly defines id: string
---------
Co-authored-by: jason <jason@example.com>1 parent 7f61ca5 commit 3306b1c
2 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
0 commit comments