fix(pd): initialize model metadata on master

Author: hiworldwzj

lightllm/server/api_http.py

@@ -98,6 +98,9 @@ def set_args(self, args: StartArgs):
         CompletionRequest.load_generation_cfg(args.model_dir)
         ChatCompletionRequest.load_generation_cfg(args.model_dir)
 
+        if self.model_created is None:
+            self.model_created = int(time.time())
+
         if args.run_mode == "pd_master":
             self.metric_client = MetricClient(get_shm_port_args().metric_port)
             self.httpserver_manager = HttpServerManagerForPDMaster(
@@ -108,8 +111,6 @@ def set_args(self, args: StartArgs):
             self.httpserver_manager = HttpServerManager(args=args)
             dp_size_in_node = max(1, args.dp // args.nnodes)  # 兼容多机纯tp的运行模式，这时候 1 // 2 == 0, 需要兼容
             self.shared_token_load = TokenLoad(f"{get_unique_server_name()}_shared_token_load", dp_size_in_node)
-            if self.model_created is None:
-                self.model_created = int(time.time())
 
 
 g_objs = G_Objs()

unit_tests/server/test_pd_master_mode.py

@@ -8,6 +8,30 @@
 from lightllm.server.httpserver_for_pd_master.manager import HttpServerManagerForPDMaster, PDManager
 
 
+def test_pd_master_models_endpoint_has_created_timestamp(monkeypatch):
+    from lightllm.server import api_http
+
+    args = StartArgs(run_mode="pd_master", model_dir="/tmp/test-model", model_name="test-model")
+    manager = SimpleNamespace(get_real_supported_max_req_total_len=lambda: 1024)
+    monkeypatch.setattr(api_http, "init_tokenizer", lambda *_args, **_kwargs: None)
+    monkeypatch.setattr(api_http.SamplingParams, "load_generation_cfg", lambda _model_dir: None)
+    monkeypatch.setattr(api_http.CompletionRequest, "load_generation_cfg", lambda _model_dir: None)
+    monkeypatch.setattr(api_http.ChatCompletionRequest, "load_generation_cfg", lambda _model_dir: None)
+    monkeypatch.setattr(api_http, "MetricClient", lambda _port: object())
+    monkeypatch.setattr(api_http, "get_shm_port_args", lambda: SimpleNamespace(metric_port=1234))
+    monkeypatch.setattr(api_http, "HttpServerManagerForPDMaster", lambda args: manager)
+    monkeypatch.setattr(api_http, "get_unique_server_name", lambda: "test-server")
+    monkeypatch.setattr(api_http.setproctitle, "setproctitle", lambda _title: None)
+    monkeypatch.setattr(api_http.time, "time", lambda: 1234.9)
+
+    global_objs = api_http.G_Objs()
+    global_objs.set_args(args)
+    monkeypatch.setattr(api_http, "g_objs", global_objs)
+
+    response = asyncio.run(api_http.get_models(None))
+    assert response.data[0].created == 1234
+
+
 def test_elastic_pd_nodes_are_ready_with_at_least_one_node_of_each_role():
     manager = PDManager(StartArgs(pd_master_mode="elastic"))
     assert manager.is_pd_nodes_ready() is False